nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use plain sql for update_all to fix postgres

Browse source 
also added a migration model
This commit is contained in:
Benjamin Neff 2016-03-04 14:19:59 +01:00
parent 7011f2961d
commit c778fc4232
1 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
db/migrate/20160225232049_link_share_visibilities_with_user.rb
View file

@ -1,12 +1,21 @@
class LinkShareVisibilitiesWithUser < ActiveRecord::Migration class LinkShareVisibilitiesWithUser < ActiveRecord::Migration
class ShareVisibility < ActiveRecord::Base
end
def up def up
cleanup_deleted_share_visibilities cleanup_deleted_share_visibilities
remove_columns :share_visibilities, :created_at, :updated_at remove_columns :share_visibilities, :created_at, :updated_at
add_column :share_visibilities, :user_id, :integer add_column :share_visibilities, :user_id, :integer
# update_all from AR doesn't work with postgres, see: https://github.com/rails/rails/issues/13496
if AppConfig.postgres?
execute "UPDATE share_visibilities SET user_id = contacts.user_id " \
"FROM contacts WHERE contacts.id = share_visibilities.contact_id"
else
ShareVisibility.joins("INNER JOIN contacts ON share_visibilities.contact_id = contacts.id") ShareVisibility.joins("INNER JOIN contacts ON share_visibilities.contact_id = contacts.id")
.update_all("share_visibilities.user_id = contacts.user_id") .update_all("share_visibilities.user_id = contacts.user_id")
end
remove_foreign_key :share_visibilities, name: :post_visibilities_contact_id_fk remove_foreign_key :share_visibilities, name: :post_visibilities_contact_id_fk
@ -31,8 +40,13 @@ class LinkShareVisibilitiesWithUser < ActiveRecord::Migration
def down def down
add_column :share_visibilities, :contact_id, :integer add_column :share_visibilities, :contact_id, :integer
if AppConfig.postgres?
execute "UPDATE share_visibilities SET contact_id = contacts.id " \
"FROM contacts WHERE contacts.user_id = share_visibilities.user_id"
else
ShareVisibility.joins("INNER JOIN contacts ON share_visibilities.user_id = contacts.user_id") ShareVisibility.joins("INNER JOIN contacts ON share_visibilities.user_id = contacts.user_id")
.update_all("share_visibilities.contact_id = contacts.id") .update_all("share_visibilities.contact_id = contacts.id")
end
remove_foreign_key :share_visibilities, name: :share_visibilities_user_id_fk remove_foreign_key :share_visibilities, name: :share_visibilities_user_id_fk