From c85209a22c213ec5486cef277ba86fee1ea69ef1 Mon Sep 17 00:00:00 2001 From: Maxwell Salzberg Date: Fri, 7 Oct 2011 12:59:07 -0700 Subject: [PATCH] strip whitespace in name call --- app/models/person.rb | 2 +- spec/models/person_spec.rb | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/models/person.rb b/app/models/person.rb index 78f56db82..b93e015ce 100644 --- a/app/models/person.rb +++ b/app/models/person.rb @@ -146,7 +146,7 @@ class Person < ActiveRecord::Base end def self.name_from_attrs(first_name, last_name, diaspora_handle) - first_name.blank? ? diaspora_handle : "#{first_name.to_s} #{last_name.to_s}" + first_name.blank? ? diaspora_handle : "#{first_name.to_s.strip} #{last_name.to_s.strip}" end def first_name diff --git a/spec/models/person_spec.rb b/spec/models/person_spec.rb index cbc68cda5..e77413de4 100644 --- a/spec/models/person_spec.rb +++ b/spec/models/person_spec.rb @@ -164,12 +164,19 @@ describe Person do end end - context '#name' do + describe '#name' do it 'calls Person.name_from_attrs' do profile = alice.person.profile Person.should_receive(:name_from_attrs).with(profile.first_name, profile.last_name, profile.person.diaspora_handle) alice.name end + + it "strips endline whitespace" do + profile = alice.person.profile + profile.first_name = "maxwell " + profile.last_name = "salzberg " + alice.name.should == "maxwell salzberg" + end end describe 'XML' do