nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid RecordNotFound exception thrown by find method when invalid person_id

Browse source
This commit is contained in:
Gonzalo Rodriguez 2011-08-27 02:45:58 -03:00
parent d084c708b6
commit cc1add81b0
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/people_controller.rb
View file

@ -141,7 +141,7 @@ class PeopleController < ApplicationController
end end
def contacts def contacts
@person = Person.find(params[:person_id]) @person = Person.find_by_id(params[:person_id])
if @person if @person
@contact = current_user.contact_for(@person) @contact = current_user.contact_for(@person)
@aspect = :profile @aspect = :profile

6
spec/controllers/people_controller_spec.rb
View file

@ -322,6 +322,12 @@ describe PeopleController do
assigns(:contacts_of_contact).should == contacts assigns(:contacts_of_contact).should == contacts
response.should be_success response.should be_success
end end
it 'shows an error when invalid person id' do
get :contacts, :person_id => 'foo'
flash[:error].should be_present
response.should redirect_to people_path
end
end end
describe '#webfinger' do describe '#webfinger' do