diff --git a/app/mailers/notification_mailers/base.rb b/app/mailers/notification_mailers/base.rb index 4393229cc..a8496df47 100644 --- a/app/mailers/notification_mailers/base.rb +++ b/app/mailers/notification_mailers/base.rb @@ -34,13 +34,13 @@ module NotificationMailers def default_headers headers = { - from: AppConfig.mail.sender_address.get, + from: "\"#{AppConfig.settings.pod_name}\" <#{AppConfig.mail.sender_address}>", host: "#{AppConfig.pod_uri.host}", to: name_and_address(@recipient.name, @recipient.email) } return headers if @sender.blank? sender_in_header = @sender.profile.full_name.empty? ? @sender.username : @sender.name - headers[:from] = "\"Diaspora* (#{sender_in_header})\" <#{AppConfig.mail.sender_address}>" + headers[:from] = "\"#{AppConfig.settings.pod_name} (#{sender_in_header})\" <#{AppConfig.mail.sender_address}>" headers end diff --git a/app/mailers/report_mailer.rb b/app/mailers/report_mailer.rb index dbb3c2f12..498413367 100644 --- a/app/mailers/report_mailer.rb +++ b/app/mailers/report_mailer.rb @@ -1,5 +1,5 @@ class ReportMailer < ActionMailer::Base - default from: AppConfig.mail.sender_address + default from: "\"#{AppConfig.settings.pod_name}\" <#{AppConfig.mail.sender_address}>" def self.new_report(report_id) report = Report.find_by_id(report_id) diff --git a/spec/mailers/notifier_spec.rb b/spec/mailers/notifier_spec.rb index 74f65840f..6594f8408 100644 --- a/spec/mailers/notifier_spec.rb +++ b/spec/mailers/notifier_spec.rb @@ -1,5 +1,7 @@ describe Notifier, type: :mailer do let(:person) { FactoryGirl.create(:person) } + let(:pod_name) { AppConfig.settings.pod_name } + before do Notifier.deliveries = [] @@ -246,7 +248,7 @@ describe Notifier, type: :mailer do end it "FROM: contains the sender's name" do - expect(@mail["From"].to_s).to eq("\"Diaspora* (#{@cnv.author.name})\" <#{AppConfig.mail.sender_address}>") + expect(@mail["From"].to_s).to eq("\"#{pod_name} (#{@cnv.author.name})\" <#{AppConfig.mail.sender_address}>") end it "should use a generic subject" do @@ -290,7 +292,7 @@ describe Notifier, type: :mailer do end it "FROM: contains the sender's name" do - expect(comment_mail["From"].to_s).to eq("\"Diaspora* (#{eve.name})\" <#{AppConfig.mail.sender_address}>") + expect(comment_mail["From"].to_s).to eq("\"#{pod_name} (#{eve.name})\" <#{AppConfig.mail.sender_address}>") end it "SUBJECT: has a snippet of the post contents, without markdown and without newlines" do @@ -331,7 +333,7 @@ describe Notifier, type: :mailer do end it "FROM: has the name of person commenting as the sender" do - expect(comment_mail["From"].to_s).to eq("\"Diaspora* (#{eve.name})\" <#{AppConfig.mail.sender_address}>") + expect(comment_mail["From"].to_s).to eq("\"#{pod_name} (#{eve.name})\" <#{AppConfig.mail.sender_address}>") end it "SUBJECT: has a snippet of the post contents, without markdown and without newlines" do @@ -386,7 +388,7 @@ describe Notifier, type: :mailer do end it "FROM: contains the sender's name" do - expect(mail["From"].to_s).to eq("\"Diaspora* (#{bob.name})\" <#{AppConfig.mail.sender_address}>") + expect(mail["From"].to_s).to eq("\"#{pod_name} (#{bob.name})\" <#{AppConfig.mail.sender_address}>") end it "SUBJECT: does not show the limited post" do @@ -411,7 +413,7 @@ describe Notifier, type: :mailer do end it "FROM: contains the sender's name" do - expect(mail["From"].to_s).to eq("\"Diaspora* (#{bob.name})\" <#{AppConfig.mail.sender_address}>") + expect(mail["From"].to_s).to eq("\"#{pod_name} (#{bob.name})\" <#{AppConfig.mail.sender_address}>") end it "SUBJECT: does not show the limited post" do @@ -442,7 +444,7 @@ describe Notifier, type: :mailer do end it "FROM: contains the sender's name" do - expect(mail["From"].to_s).to eq("\"Diaspora* (#{bob.name})\" <#{AppConfig.mail.sender_address}>") + expect(mail["From"].to_s).to eq("\"#{pod_name} (#{bob.name})\" <#{AppConfig.mail.sender_address}>") end it "SUBJECT: does not show the limited post" do @@ -478,8 +480,8 @@ describe Notifier, type: :mailer do expect(@confirm_email.to).to eq([bob.unconfirmed_email]) end - it "FROM: header should be the default sender address" do - expect(@confirm_email["From"].to_s).to eq(AppConfig.mail.sender_address.to_s) + it "FROM: header should be the pod name with default sender address" do + expect(@confirm_email["From"].to_s).to eq("#{pod_name} <#{AppConfig.mail.sender_address}>") end it "has the unconfirmed email in the subject" do @@ -506,8 +508,8 @@ describe Notifier, type: :mailer do expect(email.to).to eq([alice.email]) end - it "FROM: header should be the default sender address" do - expect(email["From"].to_s).to eq(AppConfig.mail.sender_address.to_s) + it "FROM: header should be the pod name + default sender address" do + expect(email["From"].to_s).to eq("#{pod_name} <#{AppConfig.mail.sender_address}>") end it "has the correct subject" do @@ -544,10 +546,10 @@ describe Notifier, type: :mailer do }.to_not raise_error end - it "FROM: header should be 'Diaspora* (username)' when there is no first and last name" do + it "FROM: header should be 'pod_name (username)' when there is no first and last name" do bob.person.profile.update_attributes(first_name: "", last_name: "") mail = Notifier.send_notification("started_sharing", alice.id, bob.person.id) - expect(mail["From"].to_s).to eq("\"Diaspora* (#{bob.person.username})\" <#{AppConfig.mail.sender_address}>") + expect(mail["From"].to_s).to eq("\"#{pod_name} (#{bob.person.username})\" <#{AppConfig.mail.sender_address}>") end end end diff --git a/spec/mailers/report_spec.rb b/spec/mailers/report_spec.rb index 906575b80..96699f562 100644 --- a/spec/mailers/report_spec.rb +++ b/spec/mailers/report_spec.rb @@ -41,9 +41,10 @@ describe Report, type: :mailer do expect(ActionMailer::Base.deliveries[1].to[0]).to include(@user2.email) end - it "FROM: header should be the default sender address" do + it "FROM: header should be the pod name + default sender address" do ReportMailer.new_report(@post_report.id).each(&:deliver_now) - expect(ReportMailer.default[:from].to_s).to eq(AppConfig.mail.sender_address.to_s) + pod_name = AppConfig.settings.pod_name + expect(ReportMailer.default[:from].to_s).to eq("\"#{pod_name}\" <#{AppConfig.mail.sender_address}>") end it "should send mail in recipent's prefered language" do