nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Blow out the visible_posts specs so I can more easily see what it's doing

Browse source
This commit is contained in:
Sarah Mei 2011-09-08 11:58:14 -07:00
parent 1363021859
commit d1604a5bb5
1 changed files with 57 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

96
spec/models/user/querying_spec.rb
View file

@ -13,16 +13,37 @@ describe User do
end end
describe "#visible_posts" do describe "#visible_posts" do
it "returns all the posts the user can see" do it "contains your public posts" do
self_post = alice.post(:status_message, :text => "hi", :to => @alices_aspect.id) public_post = alice.post(:status_message, :text => "hi", :to => @alices_aspect.id, :public => true)
visible_post = bob.post(:status_message, :text => "hello", :to => @bobs_aspect.id) alice.visible_posts.should include(public_post)
end
it "contains your non-public posts" do
private_post = alice.post(:status_message, :text => "hi", :to => @alices_aspect.id, :public => false)
alice.visible_posts.should include(private_post)
end
it "contains public posts from people you're following" do
dogs = bob.aspects.create(:name => "dogs")
bobs_public_post = bob.post(:status_message, :text => "hello", :public => true, :to => dogs.id)
alice.visible_posts.should include(bobs_public_post)
end
it "contains non-public posts from people who are following you" do
bobs_post = bob.post(:status_message, :text => "hello", :to => @bobs_aspect.id)
alice.visible_posts.should include(bobs_post)
end
it "does not contain non-public posts from aspects you're not in" do
dogs = bob.aspects.create(:name => "dogs") dogs = bob.aspects.create(:name => "dogs")
invisible_post = bob.post(:status_message, :text => "foobar", :to => dogs.id) invisible_post = bob.post(:status_message, :text => "foobar", :to => dogs.id)
alice.visible_posts.should_not include(invisible_post)
end
it "does not contain duplicate posts" do
bobs_other_aspect = bob.aspects.create(:name => "cat people")
bob.add_contact_to_aspect(bob.contact_for(alice.person), bobs_other_aspect)
bob.aspects_with_person(alice.person).should =~ [@bobs_aspect, bobs_other_aspect]
stream = alice.visible_posts bobs_post = bob.post(:status_message, :text => "hai to all my people", :to => [@bobs_aspect.id, bobs_other_aspect.id])
stream.should include(self_post)
stream.should include(visible_post) alice.visible_posts.length.should == 1
stream.should_not include(invisible_post) alice.visible_posts.should include(bobs_post)
end end
context 'with many posts' do context 'with many posts' do
before do before do
@ -41,44 +62,42 @@ describe User do
end end
it 'works' do #This is in one spec to save time it 'works' do #This is in one spec to save time
bob.visible_posts.length.should == 15 #it returns 15 by default bob.visible_posts.length.should == 15 #it returns 15 by default
bob.visible_posts.should == bob.visible_posts(:by_members_of => bob.aspects.map{|a| a.id}) # it is the same when joining through aspects bob.visible_posts.should == bob.visible_posts(:by_members_of => bob.aspects.map { |a| a.id }) # it is the same when joining through aspects
bob.visible_posts.sort_by{|p| p.updated_at}.map{|p| p.id}.should == bob.visible_posts.map{|p| p.id}.reverse #it is sorted updated_at desc by default bob.visible_posts.sort_by { |p| p.updated_at }.map { |p| p.id }.should == bob.visible_posts.map { |p| p.id }.reverse #it is sorted updated_at desc by default
opts = {:limit => 40} opts = {:limit => 40}
bob.visible_posts(opts).length.should == 40 #it takes a limit bob.visible_posts(opts).length.should == 40 #it takes a limit
bob.visible_posts(opts).should == bob.visible_posts(opts.merge(:by_members_of => bob.aspects.map{|a| a.id})) bob.visible_posts(opts).should == bob.visible_posts(opts.merge(:by_members_of => bob.aspects.map { |a| a.id }))
bob.visible_posts(opts).sort_by{|p| p.updated_at}.map{|p| p.id}.should == bob.visible_posts(opts).map{|p| p.id}.reverse bob.visible_posts(opts).sort_by { |p| p.updated_at }.map { |p| p.id }.should == bob.visible_posts(opts).map { |p| p.id }.reverse
last_time_of_last_page = bob.visible_posts.last.updated_at last_time_of_last_page = bob.visible_posts.last.updated_at
opts = {:max_time => last_time_of_last_page} opts = {:max_time => last_time_of_last_page}
bob.visible_posts(opts).length.should == 15 bob.visible_posts(opts).length.should == 15
bob.visible_posts(opts).map{|p| p.id}.should == bob.visible_posts(opts.merge(:by_members_of => bob.aspects.map{|a| a.id})).map{|p| p.id} bob.visible_posts(opts).map { |p| p.id }.should == bob.visible_posts(opts.merge(:by_members_of => bob.aspects.map { |a| a.id })).map { |p| p.id }
bob.visible_posts(opts).sort_by{|p| p.updated_at}.map{|p| p.id}.should == bob.visible_posts(opts).map{|p| p.id}.reverse bob.visible_posts(opts).sort_by { |p| p.updated_at }.map { |p| p.id }.should == bob.visible_posts(opts).map { |p| p.id }.reverse
bob.visible_posts(opts).map{|p|p.id}.should == bob.visible_posts(:limit => 40)[15...30].map{|p|p.id} #pagination should return the right posts bob.visible_posts(opts).map { |p| p.id }.should == bob.visible_posts(:limit => 40)[15...30].map { |p| p.id } #pagination should return the right posts
opts = {:max_time => last_time_of_last_page.to_i} opts = {:max_time => last_time_of_last_page.to_i}
bob.visible_posts(opts).length.should == 15 bob.visible_posts(opts).length.should == 15
bob.visible_posts(opts).map{|p| p.id}.should == bob.visible_posts(opts.merge(:by_members_of => bob.aspects.map{|a| a.id})).map{|p| p.id} bob.visible_posts(opts).map { |p| p.id }.should == bob.visible_posts(opts.merge(:by_members_of => bob.aspects.map { |a| a.id })).map { |p| p.id }
bob.visible_posts(opts).sort_by{|p| p.updated_at}.map{|p| p.id}.should == bob.visible_posts(opts).map{|p| p.id}.reverse bob.visible_posts(opts).sort_by { |p| p.updated_at }.map { |p| p.id }.should == bob.visible_posts(opts).map { |p| p.id }.reverse
bob.visible_posts(opts).map{|p|p.id}.should == bob.visible_posts(:limit => 40)[15...30].map{|p|p.id} #pagination should return the right posts bob.visible_posts(opts).map { |p| p.id }.should == bob.visible_posts(:limit => 40)[15...30].map { |p| p.id } #pagination should return the right posts
end end
end end
end
context 'with two posts' do context 'with two posts' do
before do before do
connect_users(eve, @eves_aspect, alice, @alices_aspect) connect_users(eve, @eves_aspect, alice, @alices_aspect)
aspect3 = alice.aspects.create(:name => "Snoozers") aspect3 = alice.aspects.create(:name => "Snoozers")
@status_message1 = eve.post :status_message, :text => "hi", :to => @eves_aspect.id @status_message1 = eve.post :status_message, :text => "hi", :to => @eves_aspect.id
@status_message2 = eve.post :status_message, :text => "hey", :public => true , :to => @eves_aspect.id @status_message2 = eve.post :status_message, :text => "hey", :public => true, :to => @eves_aspect.id
@status_message3 = alice.post :status_message, :text => "hey", :public => true , :to => @alices_aspect.id @status_message3 = alice.post :status_message, :text => "hey", :public => true, :to => @alices_aspect.id
@status_message4 = eve.post :status_message, :text => "blah", :public => true , :to => @eves_aspect.id @status_message4 = eve.post :status_message, :text => "blah", :public => true, :to => @eves_aspect.id
@status_message5 = alice.post :status_message, :text => "secrets", :to => aspect3.id @status_message5 = alice.post :status_message, :text => "secrets", :to => aspect3.id
@pending_status_message = eve.post :status_message, :text => "hey", :public => true , :to => @eves_aspect.id, :pending => true @pending_status_message = eve.post :status_message, :text => "hey", :public => true, :to => @eves_aspect.id, :pending => true
end end
describe "#visible_posts" do
it "queries by person id" do it "queries by person id" do
query = eve.visible_posts.where(:author_id => eve.person.id) query = eve.visible_posts.where(:author_id => eve.person.id)
query.include?(@status_message1).should == true query.include?(@status_message1).should == true
@ -116,24 +135,23 @@ describe User do
eve.visible_posts.should_not include @pending_status_message eve.visible_posts.should_not include @pending_status_message
end end
it '#find_visible_post_by_id' do
eve.find_visible_post_by_id(@status_message1.id).should == @status_message1
eve.find_visible_post_by_id(@status_message5.id).should == nil
end
it 'is not emptied by a load of pending photos' do it 'is not emptied by a load of pending photos' do
15.times { 15.times {
eve.build_post(:photo, :pending => true, :user_file=> File.open(photo_fixture_name), :to => eve.aspect_ids, :updated_at => Time.now + 1.day).save! eve.build_post(:photo, :pending => true, :user_file=> File.open(photo_fixture_name), :to => eve.aspect_ids, :updated_at => Time.now + 1.day).save!
} }
query = eve.visible_posts query = eve.visible_posts
query.map{|p| p.id}.should =~ [@status_message1, @status_message2, @status_message3, @status_message4].map{|p| p.id} query.map { |p| p.id }.should =~ [@status_message1, @status_message2, @status_message3, @status_message4].map { |p| p.id }
end end
it 'is not emptied by a load of photos' do it 'is not emptied by a load of photos' do
15.times { 15.times {
eve.build_post(:photo, :pending => false, :user_file=> File.open(photo_fixture_name), :to => eve.aspect_ids, :updated_at => Time.now + 1.day).save! eve.build_post(:photo, :pending => false, :user_file=> File.open(photo_fixture_name), :to => eve.aspect_ids, :updated_at => Time.now + 1.day).save!
} }
query = eve.visible_posts(:type => 'StatusMessage') query = eve.visible_posts(:type => 'StatusMessage')
query.map{|p| p.id}.should =~ [@status_message1, @status_message2, @status_message3, @status_message4].map{|p| p.id} query.map { |p| p.id }.should =~ [@status_message1, @status_message2, @status_message3, @status_message4].map { |p| p.id }
end
it '#find_visible_post_by_id' do
eve.find_visible_post_by_id(@status_message1.id).should == @status_message1
eve.find_visible_post_by_id(@status_message5.id).should == nil
end end
end end
end end
@ -284,7 +302,7 @@ describe User do
msg4.created_at = Time.now+14 msg4.created_at = Time.now+14
msg4.save! msg4.save!
alice.posts_from(@user3.person).map{|p| p.id}.should == [msg4, msg3, @public_message].map{|p| p.id} alice.posts_from(@user3.person).map { |p| p.id }.should == [msg4, msg3, @public_message].map { |p| p.id }
end end
end end
end end