From d4a2d5708c78059c6ce47a9701b95b9c961deca2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonne=20Ha=C3=9F?= Date: Sun, 31 Aug 2014 21:29:46 +0200 Subject: [PATCH] Hide welcome to diaspora after all popovers are closed As a side effect stabilizes signs up cuke --- .../javascripts/app/views/publisher/getting_started_view.js | 4 +++- features/desktop/signs_up.feature | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/app/views/publisher/getting_started_view.js b/app/assets/javascripts/app/views/publisher/getting_started_view.js index bd45bf5d4..f3e6142cd 100644 --- a/app/assets/javascripts/app/views/publisher/getting_started_view.js +++ b/app/assets/javascripts/app/views/publisher/getting_started_view.js @@ -61,7 +61,9 @@ app.views.PublisherGettingStarted = Backbone.View.extend({ close.click(function() { if( $('.popover').length==1 ) { - $.get('/getting_started_completed'); + $.get('/getting_started_completed', {success: function() { + $("#welcome-to-diaspora, #welcome-to-diaspora~br").remove(); + }}); } el.popover('hide'); return false; diff --git a/features/desktop/signs_up.feature b/features/desktop/signs_up.feature index 1af82b89c..1ab057369 100644 --- a/features/desktop/signs_up.feature +++ b/features/desktop/signs_up.feature @@ -44,7 +44,6 @@ Feature: new user registration And I have turned off jQuery effects And I wait for the popovers to appear And I click close on all the popovers - And I go to the home page Then I should not see "Welcome to diaspora*" Scenario: user fills in bogus data - client side validation