diff --git a/Gemfile b/Gemfile
index 97238ec9e..9bae8b44f 100644
--- a/Gemfile
+++ b/Gemfile
@@ -12,7 +12,7 @@ gem "unicorn", "4.9.0", require: false
# Federation
-gem "diaspora_federation-rails", "0.0.9"
+gem "diaspora_federation-rails", "0.0.10"
# API and JSON
@@ -283,7 +283,7 @@ group :test do
gem "webmock", "1.22.1", require: false
gem "shoulda-matchers", "3.0.0"
- gem "diaspora_federation-test", "0.0.9"
+ gem "diaspora_federation-test", "0.0.10"
end
group :development, :test do
diff --git a/Gemfile.lock b/Gemfile.lock
index 18de5780a..e4f4437eb 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -154,17 +154,17 @@ GEM
eventmachine (~> 1.0.8)
http_parser.rb (~> 0.6)
nokogiri (~> 1.6)
- diaspora_federation (0.0.9)
+ diaspora_federation (0.0.10)
faraday (~> 0.9.0)
faraday_middleware (~> 0.10.0)
- nokogiri (~> 1.6, >= 1.6.6.4)
+ nokogiri (~> 1.6, >= 1.6.7.1)
typhoeus (~> 0.7)
valid (~> 1.0)
- diaspora_federation-rails (0.0.9)
- diaspora_federation (= 0.0.9)
+ diaspora_federation-rails (0.0.10)
+ diaspora_federation (= 0.0.10)
rails (~> 4.2)
- diaspora_federation-test (0.0.9)
- diaspora_federation (= 0.0.9)
+ diaspora_federation-test (0.0.10)
+ diaspora_federation (= 0.0.10)
factory_girl (~> 4.5.0)
diff-lcs (1.2.5)
docile (1.1.5)
@@ -822,8 +822,8 @@ DEPENDENCIES
devise-token_authenticatable (~> 0.4.0)
devise_lastseenable (= 0.0.6)
diaspora-vines (~> 0.2.0.develop)
- diaspora_federation-rails (= 0.0.9)
- diaspora_federation-test (= 0.0.9)
+ diaspora_federation-rails (= 0.0.10)
+ diaspora_federation-test (= 0.0.10)
entypo-rails (= 3.0.0.pre.rc2)
eye (= 0.7)
factory_girl_rails (= 4.5.0)
diff --git a/app/controllers/publics_controller.rb b/app/controllers/publics_controller.rb
deleted file mode 100644
index cca482bbd..000000000
--- a/app/controllers/publics_controller.rb
+++ /dev/null
@@ -1,53 +0,0 @@
-# Copyright (c) 2010-2011, Diaspora Inc. This file is
-# licensed under the Affero General Public License version 3 or later. See
-# the COPYRIGHT file.
-
-class PublicsController < ApplicationController
- include Diaspora::Parser
-
- skip_before_action :set_header_data
- skip_before_action :set_grammatical_gender
- before_action :check_for_xml, :only => [:receive, :receive_public]
- before_action :authenticate_user!, :only => [:index]
-
- respond_to :html
- respond_to :xml, :only => :post
-
- layout false
-
- def hub
- render :text => params['hub.challenge'], :status => 202, :layout => false
- end
-
- def receive_public
- logger.info "received a public message"
- Workers::ReceiveUnencryptedSalmon.perform_async(CGI::unescape(params[:xml]))
- render :nothing => true, :status => :ok
- end
-
- def receive
- person = Person.find_by_guid(params[:guid])
-
- if person.nil? || person.owner_id.nil?
- logger.error "Received post for nonexistent person #{params[:guid]}"
- render :nothing => true, :status => 404
- return
- end
-
- @user = person.owner
-
- logger.info "received a private message for user: #{@user.id}"
- Workers::ReceiveEncryptedSalmon.perform_async(@user.id, CGI::unescape(params[:xml]))
-
- render :nothing => true, :status => 202
- end
-
- private
-
- def check_for_xml
- if params[:xml].nil?
- render :nothing => true, :status => 422
- return
- end
- end
-end
diff --git a/app/models/person.rb b/app/models/person.rb
index 398740fa3..f4c2c49a7 100644
--- a/app/models/person.rb
+++ b/app/models/person.rb
@@ -317,36 +317,6 @@ class Person < ActiveRecord::Base
self
end
- def webfinger
- DiasporaFederation::Discovery::WebFinger.new(
- acct_uri: "acct:#{diaspora_handle}",
- alias_url: AppConfig.url_to("/people/#{guid}"),
- hcard_url: AppConfig.url_to(DiasporaFederation::Engine.routes.url_helpers.hcard_path(guid)),
- seed_url: AppConfig.pod_uri,
- profile_url: profile_url,
- atom_url: atom_url,
- salmon_url: receive_url,
- guid: guid,
- public_key: serialized_public_key
- )
- end
-
- def hcard
- DiasporaFederation::Discovery::HCard.new(
- guid: guid,
- nickname: username,
- full_name: "#{profile.first_name} #{profile.last_name}".strip,
- url: AppConfig.pod_uri,
- photo_large_url: image_url,
- photo_medium_url: image_url(:thumb_medium),
- photo_small_url: image_url(:thumb_small),
- public_key: serialized_public_key,
- searchable: searchable,
- first_name: profile.first_name,
- last_name: profile.last_name
- )
- end
-
protected
def clean_url
diff --git a/config/initializers/diaspora_federation.rb b/config/initializers/diaspora_federation.rb
index b9f3670d0..4d63aebd2 100644
--- a/config/initializers/diaspora_federation.rb
+++ b/config/initializers/diaspora_federation.rb
@@ -8,12 +8,39 @@ DiasporaFederation.configure do |config|
config.define_callbacks do
on :fetch_person_for_webfinger do |handle|
person = Person.find_local_by_diaspora_handle(handle)
- person.webfinger if person
+ if person
+ DiasporaFederation::Discovery::WebFinger.new(
+ acct_uri: "acct:#{person.diaspora_handle}",
+ alias_url: AppConfig.url_to("/people/#{person.guid}"),
+ hcard_url: AppConfig.url_to(DiasporaFederation::Engine.routes.url_helpers.hcard_path(person.guid)),
+ seed_url: AppConfig.pod_uri,
+ profile_url: person.profile_url,
+ atom_url: person.atom_url,
+ salmon_url: person.receive_url,
+ subscribe_url: AppConfig.url_to("/people?q={uri}"),
+ guid: person.guid,
+ public_key: person.serialized_public_key
+ )
+ end
end
on :fetch_person_for_hcard do |guid|
person = Person.find_local_by_guid(guid)
- person.hcard if person
+ if person
+ DiasporaFederation::Discovery::HCard.new(
+ guid: person.guid,
+ nickname: person.username,
+ full_name: "#{person.profile.first_name} #{person.profile.last_name}".strip,
+ url: AppConfig.pod_uri,
+ photo_large_url: person.image_url,
+ photo_medium_url: person.image_url(:thumb_medium),
+ photo_small_url: person.image_url(:thumb_small),
+ public_key: person.serialized_public_key,
+ searchable: person.searchable,
+ first_name: person.profile.first_name,
+ last_name: person.profile.last_name
+ )
+ end
end
on :save_person_after_webfinger do |person|
@@ -63,5 +90,24 @@ DiasporaFederation.configure do |config|
on :fetch_entity_author_id_by_guid do |entity_type, guid|
entity_type.constantize.where(guid: guid).joins(:author).pluck(:diaspora_handle).first
end
+
+ on :queue_public_receive do |xml|
+ Workers::ReceiveUnencryptedSalmon.perform_async(xml)
+ end
+
+ on :queue_private_receive do |guid, xml|
+ person = Person.find_by_guid(guid)
+
+ if person.nil? || person.owner_id.nil?
+ false
+ else
+ Workers::ReceiveEncryptedSalmon.perform_async(person.owner.id, xml)
+ true
+ end
+ end
+
+ on :save_entity_after_receive do
+ # TODO
+ end
end
end
diff --git a/config/routes.rb b/config/routes.rb
index 4a4d5a778..4babaf630 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -18,6 +18,7 @@ Diaspora::Application.routes.draw do
mount Sidekiq::Web => '/sidekiq', :as => 'sidekiq'
end
+ # Federation
mount DiasporaFederation::Engine => "/"
get "/atom.xml" => redirect('http://blog.diasporafoundation.org/feed/atom') #too many stupid redirects :()
@@ -187,17 +188,6 @@ Diaspora::Application.routes.draw do
get '/u/:username' => 'people#show', :as => 'user_profile', :constraints => { :username => /[^\/]+/ }
get '/u/:username/profile_photo' => 'users#user_photo', :constraints => { :username => /[^\/]+/ }
-
- # Federation
-
- controller :publics do
- post 'receive/users/:guid' => :receive
- post 'receive/public' => :receive_public
- get 'hub' => :hub
- end
-
-
-
# External
resources :services, :only => [:index, :destroy]
diff --git a/spec/controllers/publics_controller_spec.rb b/spec/controllers/publics_controller_spec.rb
deleted file mode 100644
index 5b105688b..000000000
--- a/spec/controllers/publics_controller_spec.rb
+++ /dev/null
@@ -1,79 +0,0 @@
-# Copyright (c) 2010-2011, Diaspora Inc. This file is
-# licensed under the Affero General Public License version 3 or later. See
-# the COPYRIGHT file.
-
-require 'spec_helper'
-
-describe PublicsController, :type => :controller do
- let(:fixture_path) { Rails.root.join('spec', 'fixtures') }
- before do
- @user = alice
- @person = FactoryGirl.create(:person)
- end
-
- describe '#receive_public' do
- it 'succeeds' do
- post :receive_public, :xml => ""
- expect(response).to be_success
- end
-
- it 'returns a 422 if no xml is passed' do
- post :receive_public
- expect(response.code).to eq('422')
- end
-
- it 'enqueues a ReceiveUnencryptedSalmon job' do
- xml = "stuff"
- expect(Workers::ReceiveUnencryptedSalmon).to receive(:perform_async).with(xml)
- post :receive_public, :xml => xml
- end
- end
-
- describe '#receive' do
- let(:xml) { "" }
-
- it 'succeeds' do
- post :receive, "guid" => @user.person.guid.to_s, "xml" => xml
- expect(response).to be_success
- end
-
- it 'enqueues a receive job' do
- expect(Workers::ReceiveEncryptedSalmon).to receive(:perform_async).with(@user.id, xml).once
- post :receive, "guid" => @user.person.guid.to_s, "xml" => xml
- end
-
- it 'unescapes the xml before sending it to receive_salmon' do
- aspect = @user.aspects.create(:name => 'foo')
- post1 = @user.post(:status_message, :text => 'moms', :to => [aspect.id])
- xml2 = post1.to_diaspora_xml
- user2 = FactoryGirl.create(:user)
-
- salmon_factory = Salmon::EncryptedSlap.create_by_user_and_activity(@user, xml2)
- enc_xml = salmon_factory.xml_for(user2.person)
-
- expect(Workers::ReceiveEncryptedSalmon).to receive(:perform_async).with(@user.id, enc_xml).once
- post :receive, "guid" => @user.person.guid.to_s, "xml" => CGI::escape(enc_xml)
- end
-
- it 'returns a 422 if no xml is passed' do
- post :receive, "guid" => @person.guid.to_s
- expect(response.code).to eq('422')
- end
-
- it 'returns a 404 if no user is found' do
- post :receive, "guid" => @person.guid.to_s, "xml" => xml
- expect(response).to be_not_found
- end
- it 'returns a 404 if no person is found' do
- post :receive, :guid => '2398rq3948yftn', :xml => xml
- expect(response).to be_not_found
- end
- end
-
- describe '#hub' do
- it 'succeeds' do
- get :hub
- expect(response).to be_success
- end
- end
-end
diff --git a/spec/factories.rb b/spec/factories.rb
index 056bb1928..9adf5534b 100644
--- a/spec/factories.rb
+++ b/spec/factories.rb
@@ -10,6 +10,9 @@ def r_str
SecureRandom.hex(3)
end
+require "diaspora_federation/test"
+DiasporaFederation::Test::Factories.federation_factories
+
FactoryGirl.define do
factory :profile do
sequence(:first_name) { |n| "Robert#{n}#{r_str}" }
diff --git a/spec/federation_callbacks_spec.rb b/spec/federation_callbacks_spec.rb
index 7c5cd9640..a775d5ecc 100644
--- a/spec/federation_callbacks_spec.rb
+++ b/spec/federation_callbacks_spec.rb
@@ -13,6 +13,7 @@ describe "diaspora federation callbacks" do
expect(wf.profile_url).to eq(person.profile_url)
expect(wf.atom_url).to eq(person.atom_url)
expect(wf.salmon_url).to eq(person.receive_url)
+ expect(wf.subscribe_url).to eq(AppConfig.url_to("/people?q={uri}"))
expect(wf.guid).to eq(person.guid)
expect(wf.public_key).to eq(person.serialized_public_key)
end
@@ -149,121 +150,150 @@ describe "diaspora federation callbacks" do
end
end
- def create_a_local_person
- FactoryGirl.create(:user).person
- end
+ let(:local_person) { FactoryGirl.create(:user).person }
+ let(:remote_person) { FactoryGirl.create(:person) }
+ let(:post_by_a_local_person) { FactoryGirl.create(:status_message, author: local_person) }
+ let(:post_by_a_remote_person) { FactoryGirl.create(:status_message, author: remote_person) }
- def create_a_remote_person
- FactoryGirl.create(:person)
- end
-
- def create_post_by_a_local_person
- FactoryGirl.create(:status_message, author: create_a_local_person).guid
- end
-
- def create_post_by_a_remote_person
- FactoryGirl.create(:status_message, author: create_a_remote_person).guid
- end
-
- describe :fetch_private_key_by_diaspora_id do
+ describe ":fetch_private_key_by_diaspora_id" do
it "returns a private key for a local user" do
- expect(
- DiasporaFederation.callbacks.trigger(described_class, create_a_local_person.diaspora_handle)
- ).not_to be_nil
+ key = DiasporaFederation.callbacks.trigger(:fetch_private_key_by_diaspora_id, local_person.diaspora_handle)
+ expect(key).to be_a(OpenSSL::PKey::RSA)
+ expect(key.to_s).to eq(local_person.owner.serialized_private_key)
end
it "returns nil for a remote user" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, create_a_remote_person.diaspora_handle)
+ DiasporaFederation.callbacks.trigger(:fetch_private_key_by_diaspora_id, remote_person.diaspora_handle)
).to be_nil
end
it "returns nil for an unknown id" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, FactoryGirl.generate(:diaspora_id))
+ DiasporaFederation.callbacks.trigger(:fetch_private_key_by_diaspora_id, FactoryGirl.generate(:diaspora_id))
).to be_nil
end
end
- describe :fetch_author_private_key_by_entity_guid do
+ describe ":fetch_author_private_key_by_entity_guid" do
it "returns a private key for a post by a local user" do
- expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", create_post_by_a_local_person)
- ).not_to be_nil
+ key = DiasporaFederation.callbacks.trigger(:fetch_author_private_key_by_entity_guid,
+ "Post", post_by_a_local_person.guid)
+ expect(key).to be_a(OpenSSL::PKey::RSA)
+ expect(key.to_s).to eq(post_by_a_local_person.author.owner.serialized_private_key)
end
it "returns nil for a post by a remote user" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", create_post_by_a_remote_person)
+ DiasporaFederation.callbacks.trigger(:fetch_author_private_key_by_entity_guid,
+ "Post", post_by_a_remote_person.guid)
).to be_nil
end
it "returns nil for an unknown post" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", FactoryGirl.generate(:guid))
+ DiasporaFederation.callbacks.trigger(:fetch_author_private_key_by_entity_guid,
+ "Post", FactoryGirl.generate(:guid))
).to be_nil
end
end
- describe :fetch_public_key_by_diaspora_id do
+ describe ":fetch_public_key_by_diaspora_id" do
it "returns a public key for a person" do
- expect(
- DiasporaFederation.callbacks.trigger(described_class, create_a_remote_person.diaspora_handle)
- ).not_to be_nil
+ key = DiasporaFederation.callbacks.trigger(:fetch_public_key_by_diaspora_id, remote_person.diaspora_handle)
+ expect(key).to be_a(OpenSSL::PKey::RSA)
+ expect(key.to_s).to eq(remote_person.serialized_public_key)
end
it "returns nil for an unknown person" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, FactoryGirl.generate(:diaspora_id))
+ DiasporaFederation.callbacks.trigger(:fetch_public_key_by_diaspora_id, FactoryGirl.generate(:diaspora_id))
).to be_nil
end
end
- describe :fetch_author_public_key_by_entity_guid do
+ describe ":fetch_author_public_key_by_entity_guid" do
it "returns a public key for a known post" do
- expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", create_post_by_a_remote_person)
- ).not_to be_nil
+ key = DiasporaFederation.callbacks.trigger(:fetch_author_public_key_by_entity_guid,
+ "Post", post_by_a_remote_person.guid)
+ expect(key).to be_a(OpenSSL::PKey::RSA)
+ expect(key.to_s).to eq(post_by_a_remote_person.author.serialized_public_key)
end
it "returns nil for an unknown post" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", FactoryGirl.generate(:guid))
+ DiasporaFederation.callbacks.trigger(:fetch_author_public_key_by_entity_guid,
+ "Post", FactoryGirl.generate(:guid))
).to be_nil
end
end
- describe :entity_author_is_local? do
+ describe ":entity_author_is_local?" do
it "returns true for a post by a local user" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", create_post_by_a_local_person)
- ).to be(true)
+ DiasporaFederation.callbacks.trigger(:entity_author_is_local?, "Post", post_by_a_local_person.guid)
+ ).to be_truthy
end
it "returns false for a post by a remote user" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", create_post_by_a_remote_person)
- ).to be(false)
+ DiasporaFederation.callbacks.trigger(:entity_author_is_local?, "Post", post_by_a_remote_person.guid)
+ ).to be_falsey
end
it "returns false for a unknown post" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", FactoryGirl.generate(:diaspora_id))
- ).to be(false)
+ DiasporaFederation.callbacks.trigger(:entity_author_is_local?, "Post", FactoryGirl.generate(:diaspora_id))
+ ).to be_falsey
end
end
- describe :fetch_entity_author_id_by_guid do
+ describe ":fetch_entity_author_id_by_guid" do
it "returns id for a existing guid" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", create_post_by_a_remote_person)
- ).not_to be_nil
+ DiasporaFederation.callbacks.trigger(:fetch_entity_author_id_by_guid, "Post", post_by_a_remote_person.guid)
+ ).not_to eq(post_by_a_remote_person.author_id)
end
it "returns nil for a non-existing guid" do
expect(
- DiasporaFederation.callbacks.trigger(described_class, "Post", FactoryGirl.generate(:guid))
+ DiasporaFederation.callbacks.trigger(:fetch_entity_author_id_by_guid, "Post", FactoryGirl.generate(:guid))
).to be_nil
end
end
+
+ describe ":queue_public_receive" do
+ it "enqueues a ReceiveUnencryptedSalmon job" do
+ xml = ""
+ expect(Workers::ReceiveUnencryptedSalmon).to receive(:perform_async).with(xml)
+
+ DiasporaFederation.callbacks.trigger(:queue_public_receive, xml)
+ end
+ end
+
+ describe ":queue_private_receive" do
+ let(:xml) { "" }
+
+ it "returns true if the user is found" do
+ result = DiasporaFederation.callbacks.trigger(:queue_private_receive, alice.person.guid, xml)
+ expect(result).to be_truthy
+ end
+
+ it "enqueues a ReceiveEncryptedSalmon job" do
+ expect(Workers::ReceiveEncryptedSalmon).to receive(:perform_async).with(alice.id, xml)
+
+ DiasporaFederation.callbacks.trigger(:queue_private_receive, alice.person.guid, xml)
+ end
+
+ it "returns false if the no user is found" do
+ person = FactoryGirl.create(:person)
+ result = DiasporaFederation.callbacks.trigger(:queue_private_receive, person.guid, xml)
+ expect(result).to be_falsey
+ end
+
+ it "returns false if the no person is found" do
+ result = DiasporaFederation.callbacks.trigger(:queue_private_receive, "2398rq3948yftn", xml)
+ expect(result).to be_falsey
+ end
+ end
end
diff --git a/spec/integration/federation/federation_helper.rb b/spec/integration/federation/federation_helper.rb
new file mode 100644
index 000000000..5d536098d
--- /dev/null
+++ b/spec/integration/federation/federation_helper.rb
@@ -0,0 +1,26 @@
+def remote_user_on_pod_b
+ @remote_on_b ||= FactoryGirl.build(:user).tap do |user|
+ user.person = FactoryGirl.create(:person,
+ profile: FactoryGirl.build(:profile),
+ serialized_public_key: user.encryption_key.public_key.export,
+ diaspora_handle: "#{user.username}@remote-b.net")
+ end
+end
+
+def remote_user_on_pod_c
+ @remote_on_c ||= FactoryGirl.build(:user).tap do |user|
+ user.person = FactoryGirl.create(:person,
+ profile: FactoryGirl.build(:profile),
+ serialized_public_key: user.encryption_key.public_key.export,
+ diaspora_handle: "#{user.username}@remote-c.net")
+ end
+end
+
+def generate_xml(entity, remote_user, user)
+ DiasporaFederation::Salmon::EncryptedSlap.generate_xml(
+ remote_user.diaspora_handle,
+ OpenSSL::PKey::RSA.new(remote_user.encryption_key),
+ entity,
+ OpenSSL::PKey::RSA.new(user.encryption_key)
+ )
+end
diff --git a/spec/integration/federation/federation_messages_generation.rb b/spec/integration/federation/federation_messages_generation.rb
deleted file mode 100644
index 59bcc315e..000000000
--- a/spec/integration/federation/federation_messages_generation.rb
+++ /dev/null
@@ -1,132 +0,0 @@
-def generate_xml(entity, remote_user, user)
- DiasporaFederation::Salmon::EncryptedSlap.generate_xml(
- remote_user.diaspora_handle,
- OpenSSL::PKey::RSA.new(remote_user.encryption_key),
- entity,
- OpenSSL::PKey::RSA.new(user.encryption_key)
- )
-end
-
-def generate_status_message
- @entity = FactoryGirl.build(
- :status_message_entity,
- diaspora_id: @remote_user.diaspora_handle,
- public: false
- )
-
- generate_xml(@entity, @remote_user, @user)
-end
-
-def generate_forged_status_message
- substitute_wrong_key(@remote_user, 1)
- generate_status_message
-end
-
-def mock_private_key_for_user(user)
- expect(DiasporaFederation.callbacks).to receive(:trigger)
- .with(:fetch_private_key_by_diaspora_id, user.person.diaspora_handle)
- .once
- .and_return(user.encryption_key)
-end
-
-def retraction_mock_callbacks(entity, sender)
- return unless [
- DiasporaFederation::Entities::SignedRetraction,
- DiasporaFederation::Entities::RelayableRetraction
- ].include?(entity.class)
-
- mock_private_key_for_user(sender)
-
- allow(DiasporaFederation.callbacks).to receive(:trigger)
- .with(
- :fetch_entity_author_id_by_guid,
- entity.target_type,
- entity.target_guid
- )
- .once
- .and_return(sender.encryption_key)
-end
-
-def generate_retraction(entity_name, target_object, sender=@remote_user)
- @entity = FactoryGirl.build(
- entity_name,
- diaspora_id: sender.diaspora_handle,
- target_guid: target_object.guid,
- target_type: target_object.class.to_s
- )
-
- retraction_mock_callbacks(@entity, sender)
-
- generate_xml(@entity, sender, @user)
-end
-
-def generate_forged_retraction(entity_name, target_object, sender=@remote_user)
- times = 1
- if %i(signed_retraction_entity relayable_retraction_entity).include?(entity_name)
- times += 2
- end
-
- substitute_wrong_key(sender, times)
- generate_retraction(entity_name, target_object, sender)
-end
-
-def generate_relayable_local_parent(entity_name)
- @entity = FactoryGirl.build(
- entity_name,
- parent_guid: @local_message.guid,
- diaspora_id: @remote_user.person.diaspora_handle
- )
-
- mock_private_key_for_user(@remote_user)
-
- expect(DiasporaFederation.callbacks).to receive(:trigger)
- .with(:fetch_author_private_key_by_entity_guid, "Post", kind_of(String))
- .and_return(nil)
- generate_xml(@entity, @remote_user, @user)
-end
-
-def generate_relayable_remote_parent(entity_name)
- @entity = FactoryGirl.build(
- entity_name,
- parent_guid: @remote_message.guid,
- diaspora_id: @remote_user2.person.diaspora_handle
- )
-
- mock_private_key_for_user(@remote_user2)
-
- expect(DiasporaFederation.callbacks).to receive(:trigger)
- .with(
- :fetch_author_private_key_by_entity_guid,
- "Post",
- @remote_message.guid
- )
- .once
- .and_return(@remote_user.encryption_key)
- generate_xml(@entity, @remote_user, @user)
-end
-
-def substitute_wrong_key(user, times_number)
- expect(user).to receive(:encryption_key).exactly(times_number).times.and_return(
- OpenSSL::PKey::RSA.new(1024)
- )
-end
-
-# Checks when a remote pod wants to send us a relayable without having a key for declared diaspora ID
-def generate_relayable_local_parent_wrong_author_key(entity_name)
- substitute_wrong_key(@remote_user, 2)
- generate_relayable_local_parent(entity_name)
-end
-
-# Checks when a remote pod B wants to send us a relayable with authorship from a remote pod C user
-# without having correct signature from him.
-def generate_relayable_remote_parent_wrong_author_key(entity_name)
- substitute_wrong_key(@remote_user2, 1)
- generate_relayable_remote_parent(entity_name)
-end
-
-# Checks when a remote pod C wants to send us a relayable from its user, but bypassing the pod B where
-# remote status came from.
-def generate_relayable_remote_parent_wrong_parent_key(entity_name)
- substitute_wrong_key(@remote_user, 2)
- generate_relayable_remote_parent(entity_name)
-end
diff --git a/spec/integration/federation/receive_federation_messages.rb b/spec/integration/federation/receive_federation_messages.rb
deleted file mode 100644
index 4436c109d..000000000
--- a/spec/integration/federation/receive_federation_messages.rb
+++ /dev/null
@@ -1,146 +0,0 @@
-require "spec_helper"
-require "diaspora_federation/test"
-require "integration/federation/federation_messages_generation"
-require "integration/federation/shared_receive_relayable"
-require "integration/federation/shared_receive_retraction"
-
-describe Workers::ReceiveEncryptedSalmon do
- before do
- @user = alice
- allow(User).to receive(:find) { |id|
- @user if id == @user.id
- }
-
- @remote_user = FactoryGirl.build(:user) # user on pod B
- @remote_user2 = FactoryGirl.build(:user) # user on pod C
-
- allow_any_instance_of(DiasporaFederation::Discovery::Discovery)
- .to receive(:webfinger) {|instance|
- [@remote_user, @remote_user2].find {|user| user.diaspora_handle == instance.diaspora_id }.person.webfinger
- }
- allow_any_instance_of(DiasporaFederation::Discovery::Discovery)
- .to receive(:hcard) {|instance|
- [@remote_user, @remote_user2].find {|user| user.diaspora_handle == instance.diaspora_id }.person.hcard
- }
-
- @remote_person = Person.find_or_fetch_by_identifier(@remote_user.diaspora_handle)
- @remote_person2 = Person.find_or_fetch_by_identifier(@remote_user2.diaspora_handle)
- end
-
- it "treats sharing request recive correctly" do
- entity = FactoryGirl.build(:request_entity, recipient_id: @user.diaspora_handle)
-
- expect(Diaspora::Fetcher::Public).to receive(:queue_for).exactly(1).times
-
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_xml(entity, @remote_user, @user))
-
- expect(@user.contacts.count).to eq(2)
- new_contact = @user.contacts.order(created_at: :asc).last
- expect(new_contact).not_to be_nil
- expect(new_contact.sharing).to eq(true)
- expect(new_contact.person.diaspora_handle).to eq(@remote_user.diaspora_handle)
- end
-
- it "doesn't save the status message if there is no sharing" do
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_status_message)
-
- expect(StatusMessage.exists?(guid: @entity.guid)).to be(false)
- end
-
- describe "with messages which require sharing" do
- before do
- @remote_person = Person.find_or_fetch_by_identifier(@remote_user.diaspora_handle)
- contact = @user.contacts.find_or_initialize_by(person_id: @remote_person.id)
- contact.sharing = true
- contact.save
- end
-
- it "treats status message receive correctly" do
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_status_message)
-
- expect(StatusMessage.exists?(guid: @entity.guid)).to be(true)
- end
-
- it "doesn't accept status message with wrong signature" do
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_forged_status_message)
-
- expect(StatusMessage.exists?(guid: @entity.guid)).to be(false)
- end
-
- describe "retractions for non-relayable objects" do
- %w(
- retraction
- signed_retraction
- ).each do |retraction_entity_name|
- context "with #{retraction_entity_name}" do
- %w(status_message photo).each do |target|
- context "with #{target}" do
- it_behaves_like "it retracts non-relayable object" do
- let(:target_object) { FactoryGirl.create(target.to_sym, author: @remote_person) }
- let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
- end
- end
- end
- end
- end
- end
-
- describe "with messages which require a status to operate on" do
- before do
- @local_message = FactoryGirl.create(:status_message, author: @user.person)
- @remote_message = FactoryGirl.create(:status_message, author: @remote_person)
- end
-
- %w(comment like participation).each do |entity|
- context "with #{entity}" do
- it_behaves_like "it deals correctly with a relayable" do
- let(:entity_name) { "#{entity}_entity".to_sym }
- let(:klass) { entity.camelize.constantize }
- end
- end
- end
-
- describe "retractions for relayable objects" do
- %w(
- retraction
- signed_retraction
- relayable_retraction
- ).each do |retraction_entity_name|
- context "with #{retraction_entity_name}" do
- context "with comment" do
- it_behaves_like "it retracts relayable object" do
- # case for to-upstream federation
- let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
- let(:target_object) { FactoryGirl.create(:comment, author: @remote_person, post: @local_message) }
- let(:sender) { @remote_user }
- end
-
- it_behaves_like "it retracts relayable object" do
- # case for to-downsteam federation
- let(:target_object) { FactoryGirl.create(:comment, author: @remote_person2, post: @remote_message) }
- let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
- let(:sender) { @remote_user }
- end
- end
-
- context "with like" do
- it_behaves_like "it retracts relayable object" do
- # case for to-upstream federation
- let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
- let(:target_object) { FactoryGirl.create(:like, author: @remote_person, target: @local_message) }
- let(:sender) { @remote_user }
- end
-
- it_behaves_like "it retracts relayable object" do
- # case for to-downsteam federation
- let(:target_object) { FactoryGirl.create(:like, author: @remote_person2, target: @remote_message) }
- let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
- let(:sender) { @remote_user }
- end
- end
- end
- end
- end
- end
- end
-end
diff --git a/spec/integration/federation/receive_federation_messages_spec.rb b/spec/integration/federation/receive_federation_messages_spec.rb
new file mode 100644
index 000000000..fdb479dc5
--- /dev/null
+++ b/spec/integration/federation/receive_federation_messages_spec.rb
@@ -0,0 +1,130 @@
+require "spec_helper"
+require "integration/federation/federation_helper"
+require "integration/federation/shared_receive_relayable"
+require "integration/federation/shared_receive_retraction"
+
+describe Workers::ReceiveEncryptedSalmon do
+ it "treats sharing request receive correctly" do
+ entity = FactoryGirl.build(:request_entity, recipient_id: alice.diaspora_handle)
+
+ expect(Diaspora::Fetcher::Public).to receive(:queue_for)
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_c, alice))
+
+ new_contact = alice.contacts.find {|c| c.person.diaspora_handle == remote_user_on_pod_c.diaspora_handle }
+ expect(new_contact).not_to be_nil
+ expect(new_contact.sharing).to eq(true)
+ end
+
+ it "doesn't save the status message if there is no sharing" do
+ entity = FactoryGirl.build(:status_message_entity, diaspora_id: remote_user_on_pod_b.diaspora_handle, public: false)
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+
+ expect(StatusMessage.exists?(guid: entity.guid)).to be(false)
+ end
+
+ describe "with messages which require sharing" do
+ before do
+ contact = alice.contacts.find_or_initialize_by(person_id: remote_user_on_pod_b.person.id)
+ contact.sharing = true
+ contact.save
+ end
+
+ it "treats status message receive correctly" do
+ entity = FactoryGirl.build(:status_message_entity,
+ diaspora_id: remote_user_on_pod_b.diaspora_handle, public: false)
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+
+ expect(StatusMessage.exists?(guid: entity.guid)).to be(true)
+ end
+
+ it "doesn't accept status message with wrong signature" do
+ expect(remote_user_on_pod_b).to receive(:encryption_key).and_return(OpenSSL::PKey::RSA.new(1024))
+
+ entity = FactoryGirl.build(:status_message_entity,
+ diaspora_id: remote_user_on_pod_b.diaspora_handle, public: false)
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+
+ expect(StatusMessage.exists?(guid: entity.guid)).to be(false)
+ end
+
+ describe "retractions for non-relayable objects" do
+ %w(
+ retraction
+ signed_retraction
+ ).each do |retraction_entity_name|
+ context "with #{retraction_entity_name}" do
+ %w(status_message photo).each do |target|
+ context "with #{target}" do
+ it_behaves_like "it retracts non-relayable object" do
+ let(:target_object) { FactoryGirl.create(target.to_sym, author: remote_user_on_pod_b.person) }
+ let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
+ end
+ end
+ end
+ end
+ end
+ end
+
+ describe "with messages which require a status to operate on" do
+ let(:local_message) { FactoryGirl.create(:status_message, author: alice.person) }
+ let(:remote_message) { FactoryGirl.create(:status_message, author: remote_user_on_pod_b.person) }
+
+ %w(comment like participation).each do |entity|
+ context "with #{entity}" do
+ it_behaves_like "it deals correctly with a relayable" do
+ let(:entity_name) { "#{entity}_entity".to_sym }
+ let(:klass) { entity.camelize.constantize }
+ end
+ end
+ end
+
+ describe "retractions for relayable objects" do
+ let(:sender) { remote_user_on_pod_b }
+
+ %w(
+ retraction
+ signed_retraction
+ relayable_retraction
+ ).each do |retraction_entity_name|
+ context "with #{retraction_entity_name}" do
+ context "with comment" do
+ it_behaves_like "it retracts object" do
+ # case for to-upstream federation
+ let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
+ let(:target_object) {
+ FactoryGirl.create(:comment, author: remote_user_on_pod_b.person, post: local_message)
+ }
+ end
+
+ it_behaves_like "it retracts object" do
+ # case for to-downsteam federation
+ let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
+ let(:target_object) {
+ FactoryGirl.create(:comment, author: remote_user_on_pod_c.person, post: remote_message)
+ }
+ end
+ end
+
+ context "with like" do
+ it_behaves_like "it retracts object" do
+ # case for to-upstream federation
+ let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
+ let(:target_object) {
+ FactoryGirl.create(:like, author: remote_user_on_pod_b.person, target: local_message)
+ }
+ end
+
+ it_behaves_like "it retracts object" do
+ # case for to-downsteam federation
+ let(:entity_name) { "#{retraction_entity_name}_entity".to_sym }
+ let(:target_object) {
+ FactoryGirl.create(:like, author: remote_user_on_pod_c.person, target: remote_message)
+ }
+ end
+ end
+ end
+ end
+ end
+ end
+ end
+end
diff --git a/spec/integration/federation/shared_receive_relayable.rb b/spec/integration/federation/shared_receive_relayable.rb
index 2d25cce46..519a2793b 100644
--- a/spec/integration/federation/shared_receive_relayable.rb
+++ b/spec/integration/federation/shared_receive_relayable.rb
@@ -1,39 +1,93 @@
shared_examples_for "it deals correctly with a relayable" do
- it "treats upstream receive correctly" do
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_relayable_local_parent(entity_name))
- received_entity = klass.find_by(guid: @entity.guid)
- expect(received_entity).not_to be_nil
- expect(received_entity.author.diaspora_handle).to eq(@remote_person.diaspora_handle)
+ context "local" do
+ let(:entity) {
+ FactoryGirl.build(
+ entity_name,
+ parent_guid: local_message.guid,
+ diaspora_id: remote_user_on_pod_b.diaspora_handle
+ )
+ }
+
+ def mock_private_keys
+ allow(DiasporaFederation.callbacks).to receive(:trigger)
+ .with(:fetch_private_key_by_diaspora_id,
+ remote_user_on_pod_b.diaspora_handle)
+ .and_return(remote_user_on_pod_b.encryption_key)
+ allow(DiasporaFederation.callbacks).to receive(:trigger)
+ .with(:fetch_author_private_key_by_entity_guid, "Post", kind_of(String))
+ .and_return(nil)
+ end
+
+ it "treats upstream receive correctly" do
+ mock_private_keys
+
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+ received_entity = klass.find_by(guid: entity.guid)
+ expect(received_entity).not_to be_nil
+ expect(received_entity.author.diaspora_handle).to eq(remote_user_on_pod_b.person.diaspora_handle)
+ end
+
+ # Checks when a remote pod wants to send us a relayable without having a key for declared diaspora ID
+ it "rejects an upstream entity with a malformed author signature" do
+ allow(remote_user_on_pod_b).to receive(:encryption_key).and_return(OpenSSL::PKey::RSA.new(1024))
+ mock_private_keys
+
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+ expect(klass.exists?(guid: entity.guid)).to be(false)
+ end
end
- it "rejects an upstream entity with a malformed author signature" do
- Workers::ReceiveEncryptedSalmon.new.perform(
- @user.id,
- generate_relayable_local_parent_wrong_author_key(entity_name)
- )
- expect(klass.exists?(guid: @entity.guid)).to be(false)
- end
+ context "remote parent" do
+ let(:entity) {
+ FactoryGirl.build(
+ entity_name,
+ parent_guid: remote_message.guid,
+ diaspora_id: remote_user_on_pod_c.diaspora_handle
+ )
+ }
- it "treats downstream receive correctly" do
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_relayable_remote_parent(entity_name))
- received_entity = klass.find_by(guid: @entity.guid)
- expect(received_entity).not_to be_nil
- expect(received_entity.author.diaspora_handle).to eq(@remote_person2.diaspora_handle)
- end
+ def mock_private_keys
+ allow(DiasporaFederation.callbacks).to receive(:trigger)
+ .with(:fetch_private_key_by_diaspora_id,
+ remote_user_on_pod_c.diaspora_handle)
+ .and_return(remote_user_on_pod_c.encryption_key)
- it "rejects a downstream entity with a malformed author signature" do
- Workers::ReceiveEncryptedSalmon.new.perform(
- @user.id,
- generate_relayable_remote_parent_wrong_author_key(entity_name)
- )
- expect(klass.exists?(guid: @entity.guid)).to be(false)
- end
+ allow(DiasporaFederation.callbacks).to receive(:trigger)
+ .with(
+ :fetch_author_private_key_by_entity_guid,
+ "Post",
+ remote_message.guid
+ )
+ .and_return(remote_user_on_pod_b.encryption_key)
+ end
- it "declines downstream receive when sender signed with a wrong key" do
- Workers::ReceiveEncryptedSalmon.new.perform(
- @user.id,
- generate_relayable_remote_parent_wrong_parent_key(entity_name)
- )
- expect(klass.exists?(guid: @entity.guid)).to be(false)
+ it "treats downstream receive correctly" do
+ mock_private_keys
+
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+ received_entity = klass.find_by(guid: entity.guid)
+ expect(received_entity).not_to be_nil
+ expect(received_entity.author.diaspora_handle).to eq(remote_user_on_pod_c.diaspora_handle)
+ end
+
+ # Checks when a remote pod B wants to send us a relayable with authorship from a remote pod C user
+ # without having correct signature from him.
+ it "rejects a downstream entity with a malformed author signature" do
+ allow(remote_user_on_pod_c).to receive(:encryption_key).and_return(OpenSSL::PKey::RSA.new(1024))
+ mock_private_keys
+
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+ expect(klass.exists?(guid: entity.guid)).to be(false)
+ end
+
+ # Checks when a remote pod C wants to send us a relayable from its user, but bypassing the pod B where
+ # remote status came from.
+ it "declines downstream receive when sender signed with a wrong key" do
+ allow(remote_user_on_pod_b).to receive(:encryption_key).and_return(OpenSSL::PKey::RSA.new(1024))
+ mock_private_keys
+
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_xml(entity, remote_user_on_pod_b, alice))
+ expect(klass.exists?(guid: entity.guid)).to be(false)
+ end
end
end
diff --git a/spec/integration/federation/shared_receive_retraction.rb b/spec/integration/federation/shared_receive_retraction.rb
index af02defab..4264bc1ad 100644
--- a/spec/integration/federation/shared_receive_retraction.rb
+++ b/spec/integration/federation/shared_receive_retraction.rb
@@ -1,43 +1,62 @@
-shared_examples_for "it retracts non-relayable object" do
- it "retracts object by a correct retraction message" do
- target_klass = target_object.class.to_s.constantize
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_retraction(entity_name, target_object))
-
- expect(target_klass.exists?(guid: target_object.guid)).to be(false)
+def mock_private_keys_for_retraction(entity_name, entity, sender)
+ if %i(signed_retraction_entity relayable_retraction_entity).include?(entity_name)
+ allow(DiasporaFederation.callbacks).to receive(:trigger)
+ .with(:fetch_private_key_by_diaspora_id, sender.diaspora_handle)
+ .and_return(sender.encryption_key)
end
+ if entity_name == :relayable_retraction_entity
+ allow(DiasporaFederation.callbacks).to receive(:trigger)
+ .with(
+ :fetch_entity_author_id_by_guid,
+ entity.target_type,
+ entity.target_guid
+ )
+ .and_return(sender.encryption_key)
+ end
+end
- it "doesn't retract object when retraction has wrong signatures" do
- target_klass = target_object.class.to_s.constantize
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_forged_retraction(entity_name, target_object))
+def generate_retraction(entity_name, target_object, sender)
+ entity = FactoryGirl.build(
+ entity_name,
+ diaspora_id: sender.diaspora_handle,
+ target_guid: target_object.guid,
+ target_type: target_object.class.to_s
+ )
- expect(target_klass.exists?(guid: target_object.guid)).to be(true)
+ mock_private_keys_for_retraction(entity_name, entity, sender)
+ generate_xml(entity, sender, alice)
+end
+
+shared_examples_for "it retracts non-relayable object" do
+ it_behaves_like "it retracts object" do
+ let(:sender) { remote_user_on_pod_b }
end
it "doesn't retract object when sender is different from target object" do
target_klass = target_object.class.to_s.constantize
Workers::ReceiveEncryptedSalmon.new.perform(
- @user.id,
- generate_retraction(entity_name, target_object, @remote_user2)
+ alice.id,
+ generate_retraction(entity_name, target_object, remote_user_on_pod_c)
)
expect(target_klass.exists?(guid: target_object.guid)).to be(true)
end
end
-shared_examples_for "it retracts relayable object" do
+shared_examples_for "it retracts object" do
it "retracts object by a correct message" do
target_klass = target_object.class.to_s.constantize
- Workers::ReceiveEncryptedSalmon.new.perform(@user.id, generate_retraction(entity_name, target_object, sender))
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_retraction(entity_name, target_object, sender))
expect(target_klass.exists?(guid: target_object.guid)).to be(false)
end
it "doesn't retract object when retraction has wrong signatures" do
target_klass = target_object.class.to_s.constantize
- Workers::ReceiveEncryptedSalmon.new.perform(
- @user.id,
- generate_forged_retraction(entity_name, target_object, sender)
- )
+
+ allow(sender).to receive(:encryption_key).and_return(OpenSSL::PKey::RSA.new(1024))
+
+ Workers::ReceiveEncryptedSalmon.new.perform(alice.id, generate_retraction(entity_name, target_object, sender))
expect(target_klass.exists?(guid: target_object.guid)).to be(true)
end
diff --git a/spec/support/fixture_builder.rb b/spec/support/fixture_builder.rb
index 34f981a33..e7d90d83f 100644
--- a/spec/support/fixture_builder.rb
+++ b/spec/support/fixture_builder.rb
@@ -34,11 +34,11 @@ FixtureBuilder.configure do |fbuilder|
local_leia.contacts.create(:person => remote_raphael, :aspects => [leias_aspect])
local_luke.contacts.create(:person => remote_raphael, :aspects => [lukes_aspect])
-
+
# Set up a follower
peter = FactoryGirl.create(:user_with_aspect, :username => "peter")
peters_aspect = peter.aspects.where(:name => "generic").first
-
+
peter.contacts.create!(:person => alice.person,
:aspects => [peters_aspect],
:sharing => false,