diff --git a/Changelog.md b/Changelog.md index 2392d81f7..6038be15f 100644 --- a/Changelog.md +++ b/Changelog.md @@ -97,6 +97,7 @@ Contributions are very welcome, the hard work is done! * Redesign stream pages [#6535](https://github.com/diaspora/diaspora/pull/6535) * Improve search and mentions suggestions [#6788](https://github.com/diaspora/diaspora/pull/6788) * Redesign back to top button [#6782](https://github.com/diaspora/diaspora/pull/6782) +* Adjusted Facebook integration for a successful review [#6778](https://github.com/diaspora/diaspora/pull/6778) ## Bug fixes * Destroy Participation when removing interactions with a post [#5852](https://github.com/diaspora/diaspora/pull/5852) diff --git a/app/helpers/publisher_helper.rb b/app/helpers/publisher_helper.rb index 3935bc52c..1e7e326a9 100644 --- a/app/helpers/publisher_helper.rb +++ b/app/helpers/publisher_helper.rb @@ -12,9 +12,12 @@ module PublisherHelper end def service_button(service) + provider_title = I18n.t( + "services.index.share_to", + provider: service.provider.titleize) content_tag :div, class: "btn btn-link service_icon dim", - title: "#{service.provider.titleize} (#{service.nickname})", + title: "#{provider_title} (#{service.nickname})", id: "#{service.provider}", maxchar: "#{service.class::MAX_CHARACTERS}", data: {toggle: "tooltip", placement: "bottom"} do diff --git a/config/initializers/omniauth.rb b/config/initializers/omniauth.rb index 855078373..3321cf370 100644 --- a/config/initializers/omniauth.rb +++ b/config/initializers/omniauth.rb @@ -13,7 +13,6 @@ Rails.application.config.middleware.use OmniAuth::Builder do if AppConfig.services.facebook.enable? provider :facebook, AppConfig.services.facebook.app_id, AppConfig.services.facebook.secret, { - display: "popup", scope: "public_profile,publish_actions", client_options: { ssl: { diff --git a/config/locales/diaspora/en.yml b/config/locales/diaspora/en.yml index a30f5333a..8cad88964 100644 --- a/config/locales/diaspora/en.yml +++ b/config/locales/diaspora/en.yml @@ -1172,6 +1172,7 @@ en: really_disconnect: "Disconnect %{service}?" edit_services: "Edit services" services_explanation: "Connecting to third-party sharing services gives you the ability to publish your posts to them as you write them in diaspora*." + share_to: "Share to %{provider}" create: success: "Authentication successful." failure: "Authentication failed."