nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dont use instance vars when you have accessor methods

Browse source
This commit is contained in:
Maxwell Salzberg 2011-10-03 10:47:36 -07:00
parent df023e4c72
commit dd1a1c15bb
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/stream/aspect_stream.rb
View file

@ -23,7 +23,7 @@ class AspectStream < BaseStream
# @return [ActiveRecord::Association<Aspect>] Filtered aspects given the stream's user # @return [ActiveRecord::Association<Aspect>] Filtered aspects given the stream's user
def aspects def aspects
@aspects ||= lambda do @aspects ||= lambda do
a = @user.aspects a = user.aspects
a = a.where(:id => @inputted_aspect_ids) if @inputted_aspect_ids.length > 0 a = a.where(:id => @inputted_aspect_ids) if @inputted_aspect_ids.length > 0
a a
end.call end.call
@ -39,7 +39,7 @@ class AspectStream < BaseStream
# @return [ActiveRecord::Association<Post>] AR association of posts # @return [ActiveRecord::Association<Post>] AR association of posts
def posts def posts
# NOTE(this should be something like Post.all_for_stream(@user, aspect_ids, {}) that calls visible_posts # NOTE(this should be something like Post.all_for_stream(@user, aspect_ids, {}) that calls visible_posts
@posts ||= @user.visible_posts(:by_members_of => aspect_ids, @posts ||= user.visible_posts(:by_members_of => aspect_ids,
:type => TYPES_OF_POST_IN_STREAM, :type => TYPES_OF_POST_IN_STREAM,
:order => "#{order} DESC", :order => "#{order} DESC",
:max_time => max_time :max_time => max_time
@ -81,7 +81,7 @@ class AspectStream < BaseStream
# #
# @return [Boolean] # @return [Boolean]
def for_all_aspects? def for_all_aspects?
@all_aspects ||= aspect_ids.length == @user.aspects.size @all_aspects ||= aspect_ids.length == user.aspects.size
end end
def contacts_title def contacts_title