From e5b65f6498df7dc402667721bccf110eec526df8 Mon Sep 17 00:00:00 2001 From: Benjamin Neff Date: Sun, 19 Jun 2022 04:22:10 +0200 Subject: [PATCH] Fix jasmine fake publisher messing with follow up tests in random order --- Changelog.md | 1 + spec/javascripts/app/router_spec.js | 1 + 2 files changed, 2 insertions(+) diff --git a/Changelog.md b/Changelog.md index b6f4dad70..79abb3442 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,6 +1,7 @@ # 0.7.18.0 ## Refactor +* Fix order-dependent jasmine test failures and switch to random order [#8333](https://github.com/diaspora/diaspora/pull/8333) ## Bug fixes diff --git a/spec/javascripts/app/router_spec.js b/spec/javascripts/app/router_spec.js index c3df35e03..f635c42ed 100644 --- a/spec/javascripts/app/router_spec.js +++ b/spec/javascripts/app/router_spec.js @@ -179,6 +179,7 @@ describe('app.Router', function () { app.publisher = { jasmineTestValue: 42 }; app.router._initializeStreamView(); expect(app.publisher.jasmineTestValue).toEqual(42); + delete app.publisher; // don't leave fake publisher around }); it("doesn't set app.publisher if there is no publisher element in page", function() {