Refactor likes index route

This commit is contained in:
Steffen van Bergerem 2017-02-18 02:10:06 +01:00 committed by Benjamin Neff
parent 2772cb6e0c
commit e74b524e8f
No known key found for this signature in database
GPG key ID: 971464C3F1A90194
4 changed files with 5 additions and 16 deletions

View file

@ -31,13 +31,9 @@ class LikesController < ApplicationController
end
def index
@likes = like_service.find_for_post(params[:post_id]).includes(author: :profile)
@people = @likes.map(&:author)
respond_to do |format|
format.all { render :layout => false }
format.json { render :json => @likes.as_api_response(:backbone) }
end
render json: like_service.find_for_post(params[:post_id])
.includes(author: :profile)
.as_api_response(:backbone)
end
private

View file

@ -1,6 +0,0 @@
-# Copyright (c) 2010-2011, Diaspora Inc. This file is
-# licensed under the Affero General Public License version 3 or later. See
-# the COPYRIGHT file.
- @people[0..17].each do |person|
= person_image_link(person, size: :thumb_small)

View file

@ -1 +0,0 @@
= render 'likes', :likes => @likes

View file

@ -87,12 +87,12 @@ describe LikesController, type: :controller do
it "returns an array of likes for a post" do
bob.like!(@message)
get :index, post_id: @message.id
expect(assigns[:likes].map(&:id)).to eq(@message.likes.map(&:id))
expect(JSON.parse(response.body).map {|h| h["id"] }).to match_array(@message.likes.map(&:id))
end
it "returns an empty array for a post with no likes" do
get :index, post_id: @message.id
expect(assigns[:likes]).to eq([])
expect(JSON.parse(response.body).map(&:id)).to eq([])
end
end