From e8310f2a19ae0142dc71b3be9344defd6ee47768 Mon Sep 17 00:00:00 2001 From: Raphael Date: Sat, 27 Nov 2010 18:04:31 -0500 Subject: [PATCH] Take benchmarks out of real_name, memoize it --- app/models/person.rb | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/app/models/person.rb b/app/models/person.rb index 114250a51..a551c991b 100644 --- a/app/models/person.rb +++ b/app/models/person.rb @@ -68,16 +68,11 @@ class Person end def real_name - result = nil - time = Benchmark.realtime do - result = if profile.first_name.nil? || profile.first_name.empty? - self.diaspora_handle - else - "#{profile.first_name.to_s} #{profile.last_name.to_s}" - end - end - Rails.logger.info "event=real_name ms=#{time}" - result + @real_name ||= if profile.first_name.nil? || profile.first_name.empty? + self.diaspora_handle + else + "#{profile.first_name.to_s} #{profile.last_name.to_s}" + end end def owns?(post)