From efb711963f7e804b5f892990829082dc2842ea24 Mon Sep 17 00:00:00 2001 From: lfortin Date: Sun, 2 Jan 2011 19:24:38 -0500 Subject: [PATCH] in JS, avoid global variables as much as possible --- public/javascripts/stream.js | 4 ++-- public/javascripts/web-socket-receiver.js | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/public/javascripts/stream.js b/public/javascripts/stream.js index aa9d23103..606a3ddc0 100644 --- a/public/javascripts/stream.js +++ b/public/javascripts/stream.js @@ -51,8 +51,8 @@ var Stream = { // reshare button action $stream.delegate(".reshare_button", "click", function(evt) { evt.preventDefault(); - button = $(this) - box = button.siblings(".reshare_box"); + var button = $(this); + var box = button.siblings(".reshare_box"); if (box.length > 0) { button.toggleClass("active"); box.toggle(); diff --git a/public/javascripts/web-socket-receiver.js b/public/javascripts/web-socket-receiver.js index 0304a3525..e6c826cc7 100644 --- a/public/javascripts/web-socket-receiver.js +++ b/public/javascripts/web-socket-receiver.js @@ -1,6 +1,6 @@ var WebSocketReceiver = { initialize: function(url) { - ws = new WebSocket(url); + var ws = new WebSocket(url); //Attach onmessage to websocket ws.onmessage = WSR.onMessage; @@ -39,9 +39,9 @@ var WebSocketReceiver = { }, processPerson: function(response) { - form = $('.webfinger_form'); + var form = $('.webfinger_form'); form.siblings('#loader').hide(); - result_ul = form.siblings('#request_result'); + var result_ul = form.siblings('#request_result'); if(response.status == 'fail') { result_ul.siblings('.error').show(); result_ul.find('.error').text(response.response).show(); @@ -88,11 +88,11 @@ var WebSocketReceiver = { if( $(".comment[data-guid='"+commentId+"']").length == 0 ) { - post = $("*[data-guid='"+postId+"']'"); + var post = $("*[data-guid='"+postId+"']'"); $('.comments li:last', post ).before( $(html).fadeIn("fast", function(){}) ); - toggler = $('.show_post_comments', post); + var toggler = $('.show_post_comments', post); if(toggler.length > 0){ toggler.html(