From f19857cc4039ba6aaf16e00d99491e8acd1c3a49 Mon Sep 17 00:00:00 2001 From: Raphael Sofaer Date: Thu, 10 Mar 2011 17:12:04 -0800 Subject: [PATCH] Simplify regex madness --- app/models/status_message.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/models/status_message.rb b/app/models/status_message.rb index 7aa0e5add..c77d0ce14 100644 --- a/app/models/status_message.rb +++ b/app/models/status_message.rb @@ -44,15 +44,14 @@ class StatusMessage < Post regex = /@\{([^;]+); ([^\}]+)\}/ escaped_message = opts[:plain_text] ? raw_message : ERB::Util.h(raw_message) form_message = escaped_message.gsub(regex) do |matched_string| - inner_captures = matched_string.match(regex).captures person = people.detect{ |p| - p.diaspora_handle == inner_captures.last + p.diaspora_handle == $~[2] } if opts[:plain_text] - person ? ERB::Util.h(person.name) : ERB::Util.h(inner_captures.first) + person ? ERB::Util.h(person.name) : ERB::Util.h($~[1]) else - person ? "@#{ERB::Util.h(person.name)}" : ERB::Util.h(inner_captures.first) + person ? "@#{ERB::Util.h(person.name)}" : ERB::Util.h($~[1]) end end form_message @@ -94,7 +93,7 @@ class StatusMessage < Post end def tag_strings - regex = /(^|\s)#(\w+)/ + regex = /(?:^|\s)#(\w+)/ matches = self.raw_message.scan(regex).map do |match| match.last end