nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Issue #6281: add url to hovercard avatar

Browse source 
closes #6297
This commit is contained in:
Anton Tkachov 2015-08-05 00:55:34 +03:00 committed by Steffen van Bergerem
parent 78b0fbbee6
commit f1d6e9440b
3 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -19,6 +19,7 @@
* Implement NodeInfo [#6239](https://github.com/diaspora/diaspora/pull/6239) * Implement NodeInfo [#6239](https://github.com/diaspora/diaspora/pull/6239)
* Display original author on reshares of NSFW posts [#6270](https://github.com/diaspora/diaspora/pull/6270) * Display original author on reshares of NSFW posts [#6270](https://github.com/diaspora/diaspora/pull/6270)
* Use avatars in hovercards as links to the profile [#6297](https://github.com/diaspora/diaspora/pull/6297)
# 0.5.2.0 # 0.5.2.0

2
app/assets/javascripts/app/views/hovercard_view.js
View file

@ -20,6 +20,7 @@ app.views.Hovercard = app.views.Base.extend({
// cache some element references // cache some element references
this.avatar = this.$('.avatar'); this.avatar = this.$('.avatar');
this.avatarLink = this.$("a.person_avatar");
this.dropdown = this.$('.dropdown_list'); this.dropdown = this.$('.dropdown_list');
this.dropdown_container = this.$('#hovercard_dropdown_container'); this.dropdown_container = this.$('#hovercard_dropdown_container');
this.hashtags = this.$('.hashtags'); this.hashtags = this.$('.hashtags');
@ -115,6 +116,7 @@ app.views.Hovercard = app.views.Base.extend({
var self = this; var self = this;
this.avatar.attr('src', person.avatar); this.avatar.attr('src', person.avatar);
this.avatarLink.attr("href", person.url);
this.person_link.attr('href', person.url); this.person_link.attr('href', person.url);
this.person_link.text(person.name); this.person_link.text(person.name);
this.person_handle.text(person.handle); this.person_handle.text(person.handle);

4
app/assets/templates/hovercard_tpl.jst.hbs
View file

@ -1,5 +1,7 @@
<div id="hovercard"> <div id="hovercard">
<img class="avatar"> <a class='person_avatar'>
<img class="avatar">
</a>
<h4> <h4>
<a class="person"></a> <a class="person"></a>
</h4> </h4>