From fb51e9aa43246a174661f7b0e1fee4494aedcade Mon Sep 17 00:00:00 2001 From: JesseWeinstein Date: Mon, 10 Nov 2014 23:41:34 -0800 Subject: [PATCH] Only include the quote markdown if needed Intentionally do a converting-comparison against the empty string, to see if text is selected. --- app/helpers/application_helper.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 1197a0e3d..cb7d284c0 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -23,12 +23,12 @@ module ApplicationHelper def bookmarklet_url( height = 400, width = 620) "javascript:(function(){" \ + "t=(window.getSelection?window.getSelection():" \ + "document.getSelection?document.getSelection():" \ + "document.selection.createRange().text);" \ "f='#{AppConfig.pod_uri.to_s}bookmarklet" \ "?content='+encodeURIComponent('##%20'+document.title+" \ - "'\n>%20'+" - "(window.getSelection?window.getSelection():" \ - "document.getSelection?document.getSelection():" \ - "document.selection.createRange().text)" \ + "(t!=''?('\n>%20'+t):'')" \ "+'\n\n'+window.location.href)" \ "+'&v=1&';" \ "a=function(){" \