Commit graph

1420 commits

Author SHA1 Message Date
Jonne Haß
0e64d8de2a Refactor tumblr service spec
closes #6386
2015-09-07 13:24:53 +02:00
Vinothan Shankar
2ace9b47b1 * app/models/services/tumblr.rb (Services::Tumblr#post): Post only to primary blog
Hardly a total fix, but it's a start.  Based on meitar/diaspora:b5c01598.

* app/models/services/tumblr.rb: style: double-quote string

Line 22.  Change from single-quotes.

* app/models/services/tumblr.rb: parse URL only for blogs we care about

...which in this case is just the primary.

This also fixes the failed test in 7079fda (and by extension, 7a1d3a9).

* spec/models/services/tumblr_spec.rb: Add "primary" flag to test user-info

* spec/models/services/tumblr_spec.rb: Add a secondary blog to test user-info

This should not cause a request to be issued, so we can continue to
expect the request for the primary blog only.  Any request for the
secondary indicates a bug in the service implementation.

* spec/models/services/tumblr_spec.rb: Make the second blog returned the primary

Just to catch if it's picking the first one

* app/models/services/tumblr.rb: use blogs.find instead of blogs.each

Since we're only handling the primary blog, this should be easy enough

* app/models/services/tumblr.rb: Remove redundant if block

The condition it would have caught is dealt with by the ifnone on the find

* app/models/services/tumblr.rb: Style: remove space between { and |
2015-09-07 12:45:16 +02:00
zaziemo
d38741d5eb add more specs to test moderator role
fixes #5324

closes #6351
2015-09-07 12:38:12 +02:00
zaziemo
c2c6ed5dea refactor moderator role and add specs
#5324
2015-09-07 12:32:09 +02:00
zaziemo
3a3c881735 add new role moderator analogue to admin role
#5324
2015-09-07 12:24:12 +02:00
Benjamin Neff
d28e03f053 use discovery from diaspora_federation gem 2015-08-21 14:21:43 +02:00
theworldbright
2a3dde1ae5 Refactor PostService and extract its tests
Squashed commits:

[ada0f09] Remove favorites from Posts table

closes #6208
2015-07-26 13:10:24 +02:00
JoeBew42
e21dad780d Refactoring tests on photo saved with and without EXIF data
closes #6183
2015-07-16 11:12:12 +02:00
realtin
d0b290ea4d refactor hash indentation and add double quotes
this is the suggested styling according to hound/pronto/rubocop
(#6192)
2015-07-16 03:08:34 +02:00
zaziemo
c5a2334fbe refactor tests to use let
instead of before blocks creating instance variables
pronto checked

#6192
2015-07-16 03:05:21 +02:00
realtin
8823bb01a2 refactor test to use let and better indentation
(#6192)
2015-07-16 03:05:20 +02:00
zaziemo
56e0d3d57d Remove one comment and change hash syntax
#6192
2015-07-16 03:05:20 +02:00
zaziemo
f52260ec68 Delete test because it didn't have an expectation
and dipatch is also called in the following test
#6192
2015-07-16 03:05:20 +02:00
realtin
62b375bb8e refactor test to use let
instead of instance variables
(#6192)
2015-07-16 03:05:20 +02:00
realtin
1503376fa6 refactor test to not use send method
since dispatch method is not private
(#6192)
2015-07-16 03:05:20 +02:00
realtin
880886bbad refactor test to use let instead of instance variables 2015-07-16 03:05:20 +02:00
zaziemo
5fba53a105 refactor even more tests 2015-07-16 03:05:20 +02:00
realtin
3ff33d355f refactor test to use let 2015-07-16 03:05:20 +02:00
zaziemo
e1e8856e8d refactor more specs 2015-07-16 03:05:20 +02:00
zaziemo
e3fe375849 correct indentation and use new hash syntax 2015-07-16 03:05:20 +02:00
zaziemo
fccb5dae23 refactor test: replacing instance variables in before blocks, renaming variables for easier understanding, simplify test set up with less different comments, correct two tests 2015-07-16 03:04:41 +02:00
realtin
a9919fabd1 refactor test to use let and rm unused variables 2015-07-16 03:00:08 +02:00
zaziemo
d86a768590 refactor test using let and subject instead of before 2015-07-16 03:00:08 +02:00
realtin
7f3737b13f refactor test to use let rather then instance variables 2015-07-16 03:00:08 +02:00
zaziemo
abf87889a0 refactor test by using let instead of before block when creating instance variables 2015-07-16 03:00:08 +02:00
Benjamin Neff
f875be8d5b use federation-gem for webfinger/hcard generation
remove old webfinger/hcard generation code

this fixes #5143
2015-07-14 05:50:26 +02:00
Benjamin Neff
2294e59ee3 change public_url to atom_url and profile_url 2015-07-05 20:44:24 +02:00
fap
1061e101fd Adds welcome message on registration Welcome message is only send out if podmin account is defined and welcome message is enabled in the config.
This also enables the podmin account to send messages
to any local user.

closes #6128
2015-06-21 20:48:48 +02:00
Benjamin Neff
d42b5c128e update photos when received over public path
closes #6082
2015-06-08 04:18:31 +02:00
Benjamin Neff
e16b9af7e6 make public and private receiver work similar ... 2015-06-08 04:15:17 +02:00
Benjamin Neff
97153ad08b update tests for new twitter client
closes #6083
2015-06-08 04:08:46 +02:00
Benjamin Neff
aa2297a8c0 retry receive share-visibility when failed while receiving parallel
refactoring:
- remove unused return-values (were used for caching, which was removed again)
- remove transaction (doesn't help here, added in 2615126)

closes #6068
2015-06-08 00:58:00 +02:00
Benjamin Neff
010afa1019 refactor: iterate over visiblities
closes #6060
2015-06-08 00:45:16 +02:00
Steffen van Bergerem
1b77258d0e Set default for post title truncation to 70 characters
closes #6022
2015-06-02 12:14:35 +02:00
Benjamin Neff
03dbb75dd5 don't save default avatars to the database 2015-06-02 02:32:01 +02:00
Sandip Trivedi
2ba2ef1b9c Replaces the zipzip gem with the rubyzip gem 2015-05-28 11:23:57 +02:00
Benjamin Neff
986ad0df14 fix validation for status-message when the author is missing
closes #5986
2015-05-24 11:16:05 +02:00
Benjamin Neff
9a4a7255e7 remove unused older and newer methods for posts
last renamed in 8386179f16

closes #5970
2015-05-19 10:42:39 +02:00
Benjamin Neff
267a1df3c4 fix root_diaspora_id when root was deleted 2015-05-19 02:59:31 +02:00
Steffen van Bergerem
ceec5084af Use case insensitive unconfirmed email
closes #5967
2015-05-19 02:58:37 +02:00
Benjamin Neff
7cccb6594f remove security hax comment 2015-05-18 03:23:15 +02:00
Jonne Haß
2c7848e3cb Revert "Merge pull request #5852 from margori/3393-activity-stream-keeping-retracted-participations"
This reverts commit 096fa2ddbb, reversing
changes made to f7d1105148.
2015-05-04 00:36:27 +02:00
Benjamin Neff
28c9cfdfd4 write cucumber test and add order_id on create 2015-04-28 02:38:28 +02:00
Marcelo Briones
6636a89118 Add participation counter 2015-04-11 14:41:17 -03:00
Jonne Haß
65a738e604 bump rspec-rails 2015-03-25 02:33:56 +01:00
Martha
d4f1a5dbe8 added specs and validations for Role model
- added shoulda-matchers gem for one-line specs
- added FactoryGirl syntax methods
2015-03-18 09:16:15 -07:00
Jonne Haß
256d7862b9 Merge pull request #5782 from svbergerem/reshared-poll
Display reshared poll
2015-03-15 20:45:51 +01:00
Steffen van Bergerem
81cd1753e4 Improve link to original post in reshared polls 2015-03-15 17:07:16 +01:00
Hincu Petru
9589cb2e0f disable poll voting for reshared post 2015-03-15 16:46:48 +01:00
Sayed
18a1958ef8 fix too long tag name #5737 2015-03-15 16:15:33 +02:00