- This gives the user the sense of what he/she is currently viewing
- The hover/selected are the same right now. Needs to change.
- Need to find a more meaningful place for `markSelected`
Moved markSelected to app.views.Stream
- Removes duplication
- All streams create this view, and this seems to do some setup on
initializing, which is a good place to markNavSelected
Changing highlight on hover to 'black' instead of the blue
- The blue was a little intruisive
- Also fixes the vertical alignment issue
Changing the background to bluebg on hover
- Introduced text-dark-grey = #666666
- Converted text colors #777777 and #555555 to text-dark-grey
- Removed header-grey in favor of text-grey
- Included colors in a couple of files where it was missing
- Categorized the colors in the palette based on the contexts of usage
- Each time a stream is rendered, other lists are emtied
- Using Backbone.history.fragment to detect active stream
- hideInactiveStreamLists is best pushed into a before/after filter
Added tests for hideInactiveStreamLists
- This action needn't be performed when all notifications are read,
hence disabling it is a good practice
- Added a link-disabled-color
- Used css pointer-events to disable clicking on the link
Preventing default on click for the mark_all_read_link
- avoiding the use of pointer-events
- setting up disabled only for mark_all_read_link
Moved disabling of the link to a global handler
- Added disabled class to the button in /notifications when all are read
- Styled the disabled button
- Adding disabled class after completion of ajaxRequest
- Earlier, triple-clicking or drag & select had to be performed to select
- Should consider a copy button
Moving away from the inline onClick handler
It didn't feel right to be writing js in a helper.
Refactoring setupInviteLinks into a sidebar Backbone View
- Pulled out the existing palette in _mixins
- Took a stab at naming greys after their usage count in contexts
- Replaced #a40802 with #a80000, since they are very close and $red was already in the palette
Missed importing 'colors' in a couple of places
Removing a redefined in favor of in colors.css.scss
Fixing missed imports #2
Renamed $background to $background-white
Explicitly calling out the color of the background, since we have many
background colors
- the right-arrow wasn't highlighted on hover, which was
inconsistent with the other header items
- changed the user-menu items highlight color from #fff to #fafafa, which is
consistent across the header
- refactored the css to reduce specificity
- refactored css to use nesting in class names instead of nesting in
scss (as advocated by http://smacss.com) to reduce specificity and
to enhance readability
Added white versions of the icons on hover to match the hover of other
header items.
Changing the notifications hover icon to the regular notifications icon when active so
it is visible with the white background.
Fixing the hard coded background-position value for notifications_grey
Can not depend on generated sprite background position as it will change
with changes in icons
Moving the $icons variable to a broader scope
Since the variable is used in the header, the sprites now are imported
before the header
Using the default sprite map instead of the explicitly created sprite map
