Jonne Haß
4cadc2d51c
Merge pull request #5446 from svbergerem/append-to-publisher-spec
...
Improve append to publisher spec
2014-12-01 08:03:34 +01:00
Steffen van Bergerem
8275e6ba54
Improve append to publisher spec
2014-12-01 02:57:55 +01:00
Steffen van Bergerem
4cc1b40443
Only remove photos from view when destroyed on server
2014-12-01 00:36:56 +01:00
Steffen van Bergerem
f6fbbbb5f6
Move tag prefill to Backbone, add tests
2014-11-30 17:14:05 +01:00
Faldrian
21806a2c9b
mobile more-link only if there may be a next page; added message for end of stream
2014-11-16 01:43:55 +01:00
Steffen van Bergerem
25e4e558c5
Ask for confirmation when leaving a submittable publisher
2014-11-02 01:49:33 +01:00
Jonne Haß
1c0cf98958
Merge pull request #5237 from jaideng123/added_infinite_scrolling_to_notedropdown
...
Notifications Dropdown infinite scrolling
2014-10-14 13:37:55 +02:00
Jonne Haß
e892b115ac
Merge pull request #5289 from svbergerem/convert-cukes-tags
...
Convert some cukes to rspec tests
2014-10-14 13:26:53 +02:00
Jonne Haß
b4e4b7f007
Merge pull request #5325 from gdpelican/feature/fix-change-password-error-message
...
Show error message on invalid reset password attempt
2014-10-14 13:09:02 +02:00
Steffen van Bergerem
42a3e702e6
Fix poll for Bootstrap publisher
2014-10-11 19:18:13 +02:00
James Kiesel
e2e502ea68
Show error message on invalid reset password attempt
2014-10-11 10:47:00 +13:00
Steffen van Bergerem
a12ca511c3
Convert close mentioned account cuke
2014-10-10 03:49:56 +02:00
Steffen van Bergerem
226f1bbfc3
Convert activity stream cuke
2014-10-10 03:49:56 +02:00
Steffen van Bergerem
2b72fd0f35
Remove tests for removed beta code
2014-10-10 03:49:56 +02:00
Steffen van Bergerem
823316d7f7
Convert tag cukes to rspec tests
2014-10-10 03:49:41 +02:00
jaideng123
bd24d6bebe
Added cucumber test for notifications dropdown
2014-10-06 13:55:46 -05:00
Steffen van Bergerem
976ff0fcda
Redesign profile page and port to Bootstrap
2014-10-01 12:28:56 +02:00
Florian Staudacher
0bbf304e03
fix the last of the failing cukes (hopefully)
2014-09-17 18:38:27 +02:00
Florian Staudacher
fe0f8df9c9
add a 'css mutex' for cuke failures
2014-09-17 14:36:04 +02:00
Florian Staudacher
300496090b
add the publisher back to ones own profile, fix some cukes
2014-09-16 02:16:14 +02:00
Jonne Haß
291a2f31df
Merge branch 'release/0.4.1.0' into develop
2014-09-01 19:40:40 +02:00
Florian Staudacher
36e92b322f
fix hovercard aspect selectio z-index by moving it out of the stream element
...
- create handlebars template for hovercards
- fix notifications-dropdown (workaround) to remain open when aspect
selector is clicked
2014-09-01 19:39:23 +02:00
Jonne Haß
d4a2d5708c
Hide welcome to diaspora after all popovers are closed
...
As a side effect stabilizes signs up cuke
2014-08-31 21:29:46 +02:00
Steffen van Bergerem
854dcf04db
Display new conversation form on conversations/index
2014-08-31 18:02:37 +02:00
goobertron
a90627467b
Add sign-up tests for mobile, minor adjustments to other mobile tests
2014-08-30 18:35:10 +01:00
Steffen van Bergerem
3f3087c77f
Port tags page to Bootstrap
2014-08-28 18:02:02 +02:00
Jonne Haß
ccd7c670b3
Merge pull request #5170 from khall/issue_5149a
...
Issue 5149a
Conflicts:
spec/controllers/aspects_controller_spec.rb
spec/controllers/contacts_controller_spec.rb
2014-08-27 18:20:56 +02:00
khall
b7c68031fa
Last rspec fix brought to you by jhass
2014-08-26 17:12:58 -07:00
khall
875895f2d0
Convert specs to RSpec 3.0.4 syntax with Transpec
...
This conversion is done by Transpec 2.3.6 with the following command:
transpec features
* 19 conversions
from: obj.should
to: expect(obj).to
* 1 conversion
from: == expected
to: eq(expected)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2014-08-26 17:11:44 -07:00
khall
de3e0bd91a
Updating cucumber features
2014-08-26 17:11:44 -07:00
Steffen van Bergerem
ff84ee0485
Small style changes, add tests
2014-08-26 22:45:43 +02:00
Jonne Haß
66a5a2ac1b
Increase oembed cuke stability
...
By using the more robust step for posting
2014-08-26 10:53:07 +02:00
Jonne Haß
caa5067721
don't make loading an assertion, just try waiting for it
2014-08-24 22:59:22 +02:00
Jonne Haß
5762a5855e
remove manual sign in from close account cuke
2014-08-24 02:15:11 +02:00
Jonne Haß
01c4fa18d3
fix and stablize some cukes
2014-08-24 01:02:35 +02:00
Jonne Haß
5068be90e8
reduce cuke failures
...
* Bump sass-rails (without effect)
* Bump mobile-fu (without effect)
* Cosmetically fix two cukes
* Refactor Taggable#tag_strings
* Rename default.css to default.css.scss (without effect)
* Fix receiving a conversation
* Pass aspect_ids instead of a relation to User#aspects_from_ids
2014-08-23 16:47:57 +02:00
Jonne Haß
33c3b38f2f
replace deprecated finder and finder_options syntax
2014-08-23 16:34:00 +02:00
op48
844fe9d6b9
Allow users to delete own photos from gallery
...
Added delete label to photos in gallery
added an event to delete photos of current user
Added css for hiding/revealing the delete label
Included the photo stylesheet
Added cucumber test for deleting your own photos
Removed wip
2014-08-19 10:11:06 +01:00
Steffen van Bergerem
022bc1007d
Remove unused code
2014-08-16 11:47:31 +02:00
Błażej Pankowiak
b085c98b67
Update features to play nice with Bootstrap
2014-08-14 23:26:59 +02:00
op48
66fcfcfcbc
Ignoring validation for last poll answer input
...
last input field is only deleted if there are more than three input fields and the last one is empty
poll is validated only if the last input is empty, and the first three have been filled
Removed duplicate remove last answer.
Dont need to check that the last value is populated as we are ignoring last value
Fixing poll step
Placeholder text edited
Fixed translations for poll answer placeholder text
Removed numbers on publisher option
Removed numbers in placeholder for poll answers
2014-08-13 13:40:14 +01:00
op48
aa11f7c261
Poll answers are added dynamically on keypress
...
Removed add option button
poll option can be added dynamically & last option removed if empty upon submission
Poll answer can be added dynamically by losing focus
poll option can be added dynamically & last option removed if empty upon submission
refractored to avoid repetition of publisher:sync event
poll option can be added dynamically & last option removed if empty upon submission
Added a missing semicolon
2014-08-11 10:42:11 +01:00
Jonne Haß
d34c932f53
try to make hovercards cuke even more stable
2014-06-01 12:15:20 +02:00
Jonne Haß
3c01eb5dc4
Detect whether the stream has loaded more reliably in the hovercards cuke
2014-05-27 08:44:35 +02:00
Jonne Haß
f650808828
Merge pull request #4758 from bronislav/feature/4724-remove-own-hovercard-popup-in-reshares
...
[WIP] Fix hovercard in reshares
2014-05-24 17:56:33 +02:00
Jonne Haß
9537c45d2a
Merge pull request #4916 from hpetru/validate-poll-answer
...
I added the validation to poll question and poll answer
Conflicts:
app/assets/javascripts/app/views/publisher_view.js
2014-05-24 17:42:18 +02:00
Jonne Haß
ecb1b80e24
Render flash message content with .text
...
.html does not escape any html input in these, leading to XSS
attack vectors.
Thanks to A Kai (@sixhundredns) for reporting the related issues.
2014-05-24 16:08:32 +02:00
Florian Staudacher
7680165b14
cleanup some publishing/posting cukes, hopefully stabilizing them
2014-04-22 03:28:06 +02:00
Florian Staudacher
19687c32a4
fix race condition in cukes
2014-04-21 21:01:27 +02:00
Jason Robinson
7d9248b7ac
Merge pull request #4854 from Flaburgan/fix-mobile-drawer
...
Fix mobile drawer
2014-04-12 21:46:54 +03:00
flaburgan
86e71cd1b6
fix registration test
2014-04-11 20:25:58 +02:00
goobertron
63abe9055b
Reorder items on settings page and improve wording
...
Update cukes to be text-independent
Update changelog
2014-04-08 00:28:25 +01:00
Hincu Petru
57de031f6b
I added the validation for blank to poll question and poll answer
2014-04-07 17:17:41 +00:00
Hincu Petru
2d3933ccd8
Rewrite poll creation inputs
2014-04-06 15:01:18 +00:00
Hincu Petru
f356ae7216
Add poll in post preview
2014-04-04 11:45:33 +00:00
Jonne Haß
9eb2339368
Merge pull request #4894 from hpetru/4893-poll-in-spv
...
Add poll for single post view
2014-04-03 20:36:34 +02:00
Hincu Petru
fed5ea8cda
Refactored poll_view.js
2014-04-02 16:19:07 +00:00
Jonne Haß
8d20be6f65
Looks like I didn't pay enough attention while hitting that green button, sorry
...
Merge branch 'master' into develop
2014-04-02 08:58:21 +02:00
Jannik Streek
a9843ae996
added cucumber tests, updated spec with xml class test
2014-03-31 18:14:07 +02:00
Jonne Haß
b207077405
Merge pull request #4859 from hpetru/4848-aspect-memberships-in-notification-dropdown
...
Fixed jQuery evenets in notifications-badge
2014-03-31 13:58:11 +02:00
Hincu Petru
b43e56485d
Fixed jquery event listener from notifications-badge.js
2014-03-31 09:52:07 +00:00
Jonne Haß
7ef5595e52
Try silly things to make mentions_from_profile_page.feature:38 more stable
2014-03-30 20:54:05 +02:00
Jonne Haß
bc46ee437c
Stabilze aspect_navigation.feature:18
...
... again
2014-03-30 20:18:58 +02:00
Steffen van Bergerem
4fc9c6416e
Port notifications to Bootstrap
2014-03-19 18:45:52 +01:00
Sean Brant
9efccb797c
Fixes typos
2014-03-10 18:27:16 -05:00
Anton Ilin
68f2ce56fa
Check user name presence instead
...
It seems that loading of stream is not completed before trying to activate hovercard.
I do not want to add explicit pause to the scenarion. Let's check link presence before activating hovercard.
2014-03-07 14:45:02 +02:00
Anton Ilin
81278fa61a
Make feature consistent with other features.
...
Actually, I just trying to make this feature pass.
2014-03-07 11:28:02 +02:00
Anton Ilin
870f2e2ae8
Make step name more logical
2014-03-07 11:20:46 +02:00
Anton Ilin
e2ce10a9b2
Use capybara hover method in the hovercard steps
...
Let's use methods provided by capybara whenever possible.
2014-03-07 11:20:46 +02:00
Anton Ilin
0d9cf0fd6b
Tests for hovercard in reshares
...
Coverage with tests is necessary for every feature
2014-03-07 11:20:46 +02:00
flaburgan
2c4dc830fc
Fix aspect renaming after a regression caused by jquery upgrade, close #4822
2014-03-06 00:04:48 +01:00
Florian Staudacher
1f98e1c639
cleanup 'getting started' cukes a bit
2014-02-23 16:48:48 +01:00
Florian Staudacher
e2adaa07a2
should fix remaining failing cukes from captcha and removal of client-side-validations gem
2014-02-23 16:48:48 +01:00
Florian Staudacher
061ae52e4d
captcha needs to be present, but can be bogus in test ENV
2014-02-23 16:48:48 +01:00
arlogn
405b9fd8b9
embedding youtube videos over https
...
(cherry picked from commit 1563d088bc )
2014-02-15 16:54:46 +02:00
Jonne Haß
3a616469f4
Merge pull request #4707 from goobertron/improved_new_password
...
New reset password form
Conflicts:
Changelog.md
2014-02-10 01:35:37 +01:00
Steffen van Bergerem
a2b3917505
Add participants to conversations menu
2014-02-09 19:55:10 +01:00
flaburgan
b8bb7ae857
Fix tests
2014-02-09 17:42:28 +01:00
goobertron
2a145e67ab
Update design of forgot_password and change_password forms
...
Fix redirect to stream, make labels lower-case
Fix cuke
2014-02-09 15:48:06 +00:00
goobertron
7bcea07b99
Standardise - code refs to 'messages' to 'conversations'
2014-02-09 15:44:12 +01:00
Florian Staudacher
6c9cce7cda
Merge branch '4264-embed-youtube-on-https' of https://github.com/arlogn/diaspora into arlogn-4264-embed-youtube-on-https
2014-02-09 13:05:39 +01:00
arlogn
1563d088bc
embedding youtube videos over https
2014-01-30 18:01:27 +01:00
Jonne Haß
eeec0eafe5
Don't rely on the hover to work when deleting a comment in a cuke
...
Also reuse comment step for comment deletion cuke.
This effectively masks failures of the comment deletion cuke
until we find a real solution.
2014-01-26 00:14:35 +01:00
Jonne Haß
8b8071925d
Make toggle aspect call synchronous and bump capybaras wait timeout
...
in features/desktop/aspect_navigation.feature:18 we quickly leave the page
before waiting for the request to finish. By making the HTTP call
synchronous we wait for it to finish before we reflect the change in the DOM,
thus giving Capybara a chance to wait for it. Also let Capybara wait longer.
This should random failures of the aforementioned cuke rarer.
2014-01-26 00:13:06 +01:00
Steffen van Bergerem
20e1626453
add permalinks for comments
2014-01-17 22:11:17 +01:00
Florian Staudacher
1924c40d38
replace vendored backbone.js/underscore.js with 'backbone-on-rails' gem
...
- updates underscore to 1.5.2 and backbone to 1.1.0
backbone had some breaking changes:
- fix url/urlRoot handling in models & collections
- options are no longer attached to the view by default
- collections reset when 'fetch' is called, tell it to keep the existing
models
other changes:
- fix some events triggering multiple times in connection with deleting
a model
- use document fragments instead of an element array for stream entries
- adapt jasmine and cucumber specs to the changed code
* no longer test the backbone router as part of our code
* jasmine factory already returns model instances, no need to wrap
that again
2014-01-16 23:23:30 +01:00
Jonne Haß
15b1dae362
update devise to 3.2
2014-01-15 12:59:59 +01:00
goobertron
29a98ddc29
Remove duplicate test steps
2014-01-13 18:47:47 +00:00
goobertron
706b11b14d
Now with passing Cucumber tests
2014-01-13 18:14:43 +00:00
Steffen van Bergerem
55b967caf9
remove participants popover + improve conversations menu
2014-01-01 21:58:56 +01:00
flaburgan
6aced29bb6
Add expand the publisher test
2013-12-13 17:55:33 +01:00
Fabian Rodriguez
ea58324aa8
remove template picker
2013-12-04 20:08:54 -02:00
Jonne Haß
478159f1cd
Merge pull request #4593 from Flaburgan/improve-mobile-design
...
Improve notifications and conversations views design on mobile
2013-11-20 12:05:28 -08:00
flaburgan
861b3d30f4
Fix tests
2013-11-16 13:48:33 -08:00
flaburgan
1833edfd67
Add actions to contacts/index.html page
2013-11-12 19:10:00 -08:00
Florian Staudacher
e614562470
avoid publishing empty posts ( fixes #4401 )
...
invalidate empty posts when created by a local user
add changelog entry
2013-09-24 21:57:22 +02:00
flaburgan
02ef9e08f6
Remove the (now useless) last post link from the user profile.
2013-09-20 17:37:34 -07:00
Jonne Haß
5598cd803a
Merge pull request #4510 from diaspora/improve_tests2
...
Improve tests2
2013-09-14 14:47:58 -07:00
movilla
7d8f4578a4
add mobile test for comment mobile
2013-09-14 19:38:47 +02:00
Fabian Rodriguez
9d5d0aaf73
remove repeated step and stop using the publisher to create posts when is not necessary
2013-09-14 13:46:41 -03:00
Fabian Rodriguez
f341e1e0e6
remove commented test and fix typo
2013-09-14 13:46:41 -03:00
Fabian Rodriguez
7b65fdf77c
add missing shoulds
2013-09-14 13:46:41 -03:00
Jonne Haß
d4e1cebe68
try something to stabilize features/desktop/oembed.feature
2013-09-04 15:57:41 +02:00
Florian Staudacher
5ff05139a3
fix failing cuke - blocking from profile page
2013-09-04 14:47:28 +02:00
Colin Dean
a4ce4404ff
change bitcoin_wallet_id to bitcoin_address
...
It is better to call it an address than a wallet ID, because the latter may
confuse Bitcoin users who conflate the two. They are not the same.
Also adds convenience method to handle the deprecated variable.
2013-08-31 20:16:23 -04:00
Nils Vogels
a3f3bcf6ef
Adjusting the description of the 404 message, in order to avoid having
...
to specify why users got a 404, and possibly leaking information while doing this
See discussion in #3717 for rationale on not implementing specific HTTP codes
This solves around #3717 and #3728
Adjusting travis breakage
2013-08-30 14:42:19 +02:00
movilla
2b97f74015
error 500 when visit probile mobile and logged out. Fix #4458
2013-08-29 12:18:53 +02:00
svbergerem
fa7a03e9a7
Fix style in profile sidebar / contacts
2013-08-28 13:07:01 +02:00
Fabian Rodriguez
261ac786c1
avoid use :visible option in capybara finders
2013-08-27 10:59:44 -03:00
Fabian Rodriguez
e9af8d55af
reorganize cukes into desktop and mobile folders
2013-08-27 10:59:44 -03:00
Fabian Rodriguez
cdfdf37a17
use #hover instead of execute_script hacks
2013-08-27 10:59:44 -03:00
Fabian Rodriguez
d489dfc8e3
remove unused steps
2013-08-27 10:59:43 -03:00
Fabian Rodriguez
c69853e0cf
replace asserts with rspec equivalents
2013-08-27 10:59:43 -03:00
Jonne Haß
f9a3990562
do not leak photos through photos#show
2013-08-26 09:39:39 +02:00
Jonne Haß
1b7bc02eee
Merge pull request #4410 from rogerbraun/feature/spv-redesign
...
New single post view
Conflicts:
app/assets/stylesheets/application.css.sass
2013-08-22 10:37:25 +02:00
Roger Braun
d7aaaea86e
Fix specs for new single post view.
2013-08-22 09:56:35 +02:00
Steffen van Bergerem
7fe972555a
profile message and mention icons
2013-08-21 23:05:42 +02:00
Jonne Haß
9793827f20
fix features/profile_photos.feature:17 I broke
2013-08-19 15:47:41 +02:00
Steffen van Bergerem
f22b4d7da7
Change contact list on profile page
2013-08-19 14:02:08 +02:00
mokus
babcc1e66b
update profile_photo test and selenium version to make tests pass on firefox 23
2013-08-19 12:49:39 +02:00
carolina
f3817b996e
Modify photos unless condition and loop through thumbnails and test
2013-08-19 12:49:39 +02:00
carolina
fd05d30f20
Add tests for photo link in profile side bar
2013-08-19 12:49:39 +02:00
Jonne Haß
a1f4c4b1d0
wild shot at stabilizing features/aspect_navigation.feature:18 by making sure all aspects are deselected after deselecting all aspects
2013-08-18 12:05:05 +02:00
movilla
d1c679cc22
remove comments from the mobile site. Close #4225
2013-08-16 22:14:52 +02:00
movilla
73825ab94a
Remove post from the mobile site
2013-08-16 20:44:22 +02:00
movilla
795a7a5751
mobile error 500 if a reshared (original) post will be deleted.
2013-08-16 12:07:14 +02:00
movilla
152c08963a
fix mobile search tags
2013-08-12 16:01:26 +02:00
Bender Bending Rodríguez
7086055f4e
Bitcoin donations
2013-08-11 15:31:05 +02:00
Jonne Haß
45e4817a58
expect the ajax request updating the profile name in features/signs_up.feature
2013-08-11 11:20:29 +02:00
Jonne Haß
bf9996b25d
lets see if page.should have_no_css actually waits for the element to disappear
2013-08-11 10:06:42 +02:00
Steffen van Bergerem
8a8fb10b18
auto expand post preview
2013-08-06 20:48:27 +02:00
flaburgan
ac533f8383
Refactor the left bar side menu, improve tag autosuggestion design, close #4271
2013-08-06 18:30:24 +02:00
Jonne Haß
274faebdd1
another attempt at stabilizing features/signs_up.feature
2013-08-04 17:01:12 +02:00
Jonne Haß
5026eccc6a
Refactor and reorder backbone app initialization, fixes hovercards
...
Also added cucumber feature for hovercards
2013-08-01 12:52:16 +02:00
Jonne Haß
46ab67beed
stabilize features/reshare_mobile.feature
2013-07-31 19:05:54 +02:00
Jonne Haß
3ae2d2e43c
stabilize features/signs_up.feature
2013-07-31 17:00:13 +02:00
Jonne Haß
300752fc87
bump capybara
...
* removed wait_until where possible
* replaced wait_until with DOM obersavtions
* added match: :first to all finders that assumed getting the first element
* replaced evaluate_script with execute_script where possible
* replaced a few execute_script with DOM observations through Capybara
* removed sleep where possible
* replaced sleep with DOM obersvations
* replaced "wait for ajax" with DOM obersavations
* replaced alert confirmation with new selenium API
* bump selenium webdriver
* made any other fixes to get green again
2013-07-31 01:47:23 +02:00
Tamas Laszlo Fabian
37505c5ece
Fixed timago tooltip in conversations
...
Fixed timeago errors
Added cucumber stuff to test timeago at inbox
Show localized date/time in tooltip
Remove title attributes
2013-07-07 14:43:47 +02:00
Antoine D
8e2633f8b3
Improve participants link style in conversation, close #4236
...
Move it to the right and replace the text by an image with the nice tooltip, modify the test.
2013-06-28 00:41:44 +02:00
Florian Staudacher
653f7566df
fix failing conversations cuke
2013-06-05 01:07:05 +02:00
Juan Azambuja
3f3fe3ecc7
Add participants preview con conversations
2013-06-01 12:14:16 -03:00
Steffen van Bergerem
7f596cfd36
Fix #4157 : post preview from tag pages
2013-05-25 12:39:01 +02:00
Steffen van Bergerem
63040bb8cc
fix mentions at the end of a post
2013-05-17 19:27:08 +02:00
movilla
5839d304db
Fix reactions link on mobile broken
2013-04-25 13:55:57 +02:00
Juan Manuel Azambuja
de7044c602
Fix select & deselect all aspects check image
2013-04-21 21:38:03 -03:00
movilla
c1479b36ca
Correction typos for changelog and activity mobile feature
2013-04-13 22:24:07 +02:00
Jonne Haß
fd069af2c6
Merge branch 'activity_more' of git://github.com/movilla/diaspora into movilla-activity_more
...
Conflicts:
Changelog.md
2013-04-13 12:53:31 +02:00
Juan Manuel Azambuja
5a85fd71f1
close issues #4017 and 4107 by including jquery.textchange
2013-04-09 16:21:19 -03:00
movilla
bc87b501f2
Fix show more post in my activity mobile page. Close #4108
2013-04-08 00:04:42 +02:00
Steffen van Bergerem
6e724fc1d4
preview posts in stream
2013-04-07 17:43:27 +02:00