Maxwell Salzberg
e25decedc3
Merge pull request #1845 from fermionic/1811-mobile-share-button
...
1811 mobile share button
2011-08-30 11:27:36 -07:00
Sarah Mei
2255e80b69
So. It turns out that postgresql has a less-consistent idea of what .first means in an association with no default ordering. All the places we were doing bob.aspects.first (& etc.) needed to be more specific. & o ya, POSTGRES IS GREEN.
2011-08-29 22:03:05 -07:00
Zach Prezkuta
3f5dd7e5b1
Issue #1811 : Share button missing in mobile version
2011-08-29 22:30:14 -06:00
Maxwell Salzberg
3bde507a3a
DC MS fix crazy status.net linkback accept header
2011-08-29 18:44:31 -07:00
Sarah Mei
b60101b9ad
Use explicit parameters instead of request format to determine whether we render a remote or non-remote form in aspects#new.
...
Facebox needs to get back a text/html response. We were using text/javascript to indicate that we wanted a remote form and text/html to indicate we wanted a non-remote form. The trouble is, if we request with text/javascript then that is the format we get back. It doesn't really make sense to use formats that way anyway, so I changed it to an explicit parameter. This had the nice side effect of simplifying our new-aspect views.
2011-08-28 16:08:57 -07:00
Gonzalo Rodriguez
cc1add81b0
Avoid RecordNotFound exception thrown by find method when invalid person_id
2011-08-27 02:45:58 -03:00
Dan Hansen
27d4fd8176
fix retractions, fix likes, backfill likes widget tests, remove typo from jasmine.yml, remove unneeded js files
...
require confirmation for comments in js, get rid of rails helper
2011-08-26 15:24:07 -05:00
Dan Hansen
d75ef8d020
made backtotop a widget, added jquery-debounce
2011-08-26 12:30:28 -05:00
Gonzalo Rodríguez
31733e1f9f
Merge pull request #1686 from grzuy/1486-invalid-birthday-crash
...
Fix #1486 profile update was crashing with invalid birthday date
2011-08-25 16:40:57 -07:00
Raphael Sofaer
6b88a75174
Log out a user if they arrive at AuthorizationsController#new carrying the username of a different user
2011-08-23 16:37:50 -07:00
Dan Hansen
4a64a172d1
Merge branch 'master' of github.com:diaspora/diaspora into js-refactor-merged
...
Conflicts:
spec/javascripts/stream-spec.js
2011-08-21 20:57:01 -05:00
Sarah Mei
163ac103cd
Haven't figured out why reset password email body is blank, but I pulled it into a controller test so we can figure it out there instead of in a cucumber feature.
2011-08-21 16:45:53 -07:00
Andrej Kacian
2a52face12
Add jasmine test for ajax spinner display
2011-08-22 00:38:34 +02:00
Dan Hansen
3ed50cab94
Merge branch 'master' of github.com:diaspora/diaspora into js-refactor-merged
...
Conflicts:
app/views/status_messages/bookmarklet.html.haml
config/assets.yml
db/schema.rb
public/javascripts/contact-edit.js
public/javascripts/publisher.js
public/javascripts/view.js
2011-08-20 14:40:56 -05:00
Gonzalo Rodriguez
ceedbb14cb
Closes #1486 . Profile update was crashing with invalid birthday date
2011-08-20 00:34:59 -03:00
Gonzalo Rodriguez
234af2a15b
Fixing some tests that weren't testing correctly
...
These assertions were always returning true even if you dont populate
the flash, because nil.should_not be_empty returns true
2011-08-19 23:57:33 -03:00
Raphael Sofaer
a74080e27d
Fix ServicesController spec
2011-08-19 16:52:26 -07:00
Maxwell Salzberg
6beeecefd8
add better messages telling a user that they sent share requests if they try and email exsisting users
2011-08-18 18:27:37 -07:00
Gonzalo Rodriguez
2d54d9a97e
Validate presence of message text on conversations. Closes #1329 .
2011-08-17 23:52:31 -03:00
danielgrippi
a99e69edd6
down to 2 failures in postgres
2011-08-17 16:51:54 -07:00
Maxwell Salzberg
ad1b122e20
test batch_invite
2011-08-17 16:28:21 -07:00
danielgrippi
eb8c540ac1
MS DG IZ major invite refactor. all tests are green minus weird stuff on dans computer, need to checkout this out on pivots
2011-08-17 16:28:21 -07:00
Maxwell Salzberg
a06f25b297
Merge pull request #1763 from grzuy/conversation-creation-refactor
...
Refactor conversations creation
2011-08-16 10:26:54 -07:00
danielgrippi
32ae21a213
removed user invite counter, as it was already depricated
2011-08-15 15:15:43 -07:00
Gonzalo Rodriguez
2326206586
Refactor conversations creation
2011-08-12 23:07:01 -03:00
Raphael Sofaer
565d71a0cd
Bad solution for making sure that an invited facebook user is marked immediately as having been invited
2011-08-12 17:32:52 -07:00
Raphael Sofaer
cd640e1ac6
Pending spec for statusnet linkback plugin
2011-08-12 10:37:24 -07:00
Raphael Sofaer
9a77d3518f
Mobile authorizations index view
2011-08-11 16:39:39 -07:00
Raphael Sofaer
7021cd79c8
Select distinct people in contacts index
2011-08-11 11:56:23 -07:00
Dan Hansen
2e9040e227
merged with master, 7 cukes failing. jasmine is green. need to remove rails.js helpers so things suck less
2011-08-10 23:57:33 -07:00
danielgrippi
db645e8da8
merged publics/show and posts/show
2011-08-10 18:07:38 -07:00
Raphael Sofaer
90a5cd2254
Get rid of error on aspect_memberships destroy if someone has noscript on or something
2011-08-10 17:40:38 -07:00
danielgrippi
b6c26611ef
placed all mail jobs in the Job::Mail:: namespace & added into appropriate folders
2011-08-10 15:31:40 -07:00
Andrej Kacian
a904b59a03
Add rspec test for correct behavior of /u/nonexistentuser URL
2011-08-10 22:25:35 +02:00
Sarah Mei
0b02653f44
Merge pull request #1694 from ticho/tag-list-has-unfollow-icon
...
Add a "unfollow" icon to each tag in followed tags listing
2011-08-09 21:44:21 -07:00
Maxwell Salzberg
86e374b8ce
add hovercards back to mentions, reorganized some helpers, made getting started view mobile accessible
2011-08-09 16:54:24 -07:00
Raphael Sofaer
f8e53bfba5
Fix a user's atom feed route from a cell phone.
2011-08-09 16:20:27 -07:00
Andrej Kacian
bddd7c717b
Write jasmine test for the tag unfollow icon visibility
2011-08-09 22:54:31 +02:00
Maxwell Salzberg
e9d993b8f6
throw 404s when the person is no found
2011-08-09 13:03:45 -07:00
Raphael Sofaer
69619f9ba2
Rescue from duplicate key errors in AspectMembershipsController
2011-08-09 12:50:24 -07:00
Raphael Sofaer
7f5f696642
Don't let googlebot 500 us on the public post page
2011-08-09 12:26:10 -07:00
Raphael Sofaer
f0f388d9e1
Fix weird error in jasmine suite
2011-08-05 15:09:16 -07:00
danielgrippi
99ac976594
fix redirects around getting_started and aspect/index
2011-08-03 18:07:43 -07:00
danielgrippi
987d334764
fixed tests, translations, initalizer
2011-08-03 18:02:58 -07:00
Maxwell Salzberg
7e8f17cc31
refactoring this stuff
2011-08-03 16:58:55 -07:00
Raphael Sofaer
5967f01dab
Take out PostsFake, now that we ajax in comments it's not worth the extra complications
2011-08-03 11:09:21 -07:00
Raphael Sofaer
be5453f0b4
Fix photo show pages with likes
2011-08-02 10:17:49 -07:00
Raphael Sofaer
65c4b1ceaf
Merge pull request #1711 from gandaro/1602-delete-profile-photo
...
test for issue #1602 's fix; typos
2011-08-01 16:11:17 -07:00
Andrej Kacian
a5e8db04a0
Fix typo for contacts_controller #featured test
2011-08-01 23:20:23 +02:00
Jakob Kramer
4b9c8487e6
test for issue #1602 's fix; typos
2011-08-01 20:12:30 +02:00