Commit graph

7094 commits

Author SHA1 Message Date
Lukas Matt
3108926dc3 Reports email notification; wrong recipient
The mailer uses the person_id to find a user
which cannot work on a production environment.

I haven't used a remote user on my test setup.

(cherry picked from commit 01a45ccf40)
2014-06-24 22:20:53 +03:00
Jason Robinson
d18e48952c Use different user.construct_public_followings_sql query depending on database backend.
This is done for performance reasons as a temporary fix for problems with 0.4.0.0 on MySQL. This madness is explained in issue https://github.com/diaspora/diaspora/issues/5014.

(cherry picked from commit 80075c13f4)
2014-06-24 21:57:21 +03:00
Jonne Haß
96fa96b88c Merge pull request #5007 from jaywink/revert-mobile-bookmarklet-fix
Revert "Fix toggling services for mobile bookmarklet"
2014-06-22 15:01:34 +02:00
Jason Robinson
126ced4383 Fix broken bookmarklet if params have encoded linefeeds.
Closes #4994
2014-06-22 11:48:24 +03:00
Jason Robinson
e4e9f40b2c Revert "Fix toggling services for mobile bookmarklet"
This fixed the toggling of services, but broke the actual
bookmarklet :)

This reverts commit 1bd7989045.
2014-06-19 21:47:34 +03:00
Jonne Haß
0843db468e Merge pull request #5001 from Zauberstuhl/fixed_unauthorized_report_prompt
Hide SPV controls unless authenticated
2014-06-18 21:45:27 +02:00
Lukas Matt
c86b57fe8f Fixed overridden interactions by re-initializing 2014-06-18 13:03:07 -04:00
Erwan Guyader
e804f30823 Code style + allow aspects to be nil
- Only use old hash style
  - Don't replace the aspect ids list with an empty array if it's nil
2014-06-17 21:19:17 +02:00
Lukas Matt
10117b81b3 Hide report icon on SPV if author is current user 2014-06-17 12:23:54 -04:00
Lukas Matt
dec7ef667e Hide SPV controls unless authenticated
* cleaned and removed dead code

refs diaspora/diaspora#4711
2014-06-17 11:31:16 -04:00
Erwan Guyader
499eb6a9bb Load right stream with Show More on mobile
- Load aspects stream if user is on this stream instead of loading the
    activity stream
2014-06-16 18:13:05 +02:00
Jason Robinson
1bd7989045 Fix toggling services for mobile bookmarklet 2014-06-02 23:29:47 +03:00
Jason Robinson
ad0982f35e Remove custom bookmarklet error message.
Flash error is shown on bookmarklet post error. On error, return post_something message to form
2014-06-01 15:37:54 +03:00
Jason Robinson
f130ab3842 Remove double setButtonsEnabled in publisher error 2014-06-01 15:17:16 +03:00
Jason Robinson
6cf484c9a3 Make sure publisher is totally hidden in bookmarklet after post success 2014-06-01 15:02:40 +03:00
Jason Robinson
8fead54ab6 Make publisher spinner also work in bootstrap publisher 2014-06-01 14:52:59 +03:00
Jason Robinson
128be9204c Refactor UI hint on status message submit.
Now we close the publisher on submit and reopen it on error. The spinner is shown while submission is in progress. Fixes #4949
2014-06-01 14:25:34 +03:00
Jason Robinson
6fd4894997 Add error flash message to publisher on error from server 2014-06-01 13:21:45 +03:00
Jason Robinson
b73e478e26 Add spinner to publisher when posting a message
Fixes #4949
2014-05-31 21:05:36 +03:00
Jonne Haß
a151ab9e30 Merge pull request #4970 from Flaburgan/realign-check-icons
Realign check icon in aspect dropdown
2014-05-27 08:07:28 +02:00
Jonne Haß
fc1f249129 Harden account deletion
* Wrap it into a transaction
* Use destroy over delete so dependent destroys get triggered
  and we thus don't fail on the foreign key constraits
* Check if a photos status message actually exists before accessing
  it
* Add missing dependent destroys
2014-05-27 00:15:15 +02:00
flaburgan
db18d9810c Realign check icon in aspect dropdown 2014-05-27 00:03:20 +02:00
Erwan Guyader
24d2ac0ec2 4967 Use https to load the location form OSM 2014-05-26 11:34:01 +02:00
Jonne Haß
e6348aa705 Use toggle() to hide the poll creator 2014-05-24 21:40:48 +02:00
Jonne Haß
f650808828 Merge pull request #4758 from bronislav/feature/4724-remove-own-hovercard-popup-in-reshares
[WIP] Fix hovercard in reshares
2014-05-24 17:56:33 +02:00
Jonne Haß
9537c45d2a Merge pull request #4916 from hpetru/validate-poll-answer
I added the validation to poll question and poll answer

Conflicts:
	app/assets/javascripts/app/views/publisher_view.js
2014-05-24 17:42:18 +02:00
Jonne Haß
0c5cc216c6 Replace vaild with valid
Thanks to Josias for the hint
2014-05-24 17:24:36 +02:00
Jonne Haß
ecb1b80e24 Render flash message content with .text
.html does not escape any html input in these, leading to XSS
attack vectors.

Thanks to A Kai (@sixhundredns) for reporting the related issues.
2014-05-24 16:08:32 +02:00
Marien Fressinaud
fa2de8c195 Remove duplicate checkbox in Settings
Fix issue #4964
2014-05-22 22:39:09 +02:00
Lukas Matt
8170ef8363 Validate on report that post or comment does exist 2014-05-16 09:48:14 -04:00
Lukas Matt
6d6ebd297e Do not try to render posts/comments which are not present
refs diaspora/diaspora#4959
2014-05-16 09:48:14 -04:00
Jason Robinson
01381ddf25 Merge pull request #4957 from MrZYX/4956_deleted_reshare
Use absolute_root more consistently in Reshare
2014-05-16 10:00:31 +03:00
Lukas Matt
3d9fceb479 DB fix to work with existing entries
* added temp. default values for user_id and item_type
* changed model validation for item_type
2014-05-15 07:23:44 -04:00
Lukas Matt
462a7116de Fixed possible XSS; escape comment text in report helper 2014-05-15 07:23:44 -04:00
Lukas Matt
7ef802127e Added confirm-dialog to report-delete-button
* changed button description
* replaced links with buttons
2014-05-15 07:23:44 -04:00
Lukas Matt
693986bba0 Fixed report icon in single post view 2014-05-15 07:23:44 -04:00
Lukas Matt
6ff2141503 If you're able to remove the comment you shouldn't be able to report it 2014-05-15 07:23:44 -04:00
Lukas Matt
23d0890bdc Fixed and cleaned comment template/stylesheet
fixed:
* comment-report-icon will not be displayed when post author is current user
* if you hover a comment all report icons will be displayed
2014-05-15 07:23:44 -04:00
Lukas Matt
218845d5b4 Changed and renamed database columns
* changed user_id type to integer
* renamed post_id to item_id
* renamed post_type to item_type
2014-05-15 07:23:44 -04:00
Lukas Matt
9d3af93c7d Removed unicode from entypo css file 2014-05-15 07:23:43 -04:00
Lukas Matt
6f65ef8437 Using save for report model
Instead of checking the status code I am using success and
error callbacks from model-save. In that case we have to return
json in the controller for signaling that the request was sucessfully.
2014-05-15 07:23:43 -04:00
Lukas Matt
8b8a232b17 Added diaspora copyright 2014-05-15 07:23:43 -04:00
Lukas Matt
011db282b7 Removed local variable in ReportMailer 2014-05-15 07:23:43 -04:00
Lukas Matt
045ced0518 Joined if statements and removed duplicated code 2014-05-15 07:23:43 -04:00
Lukas Matt
512d96bda6 Display validation errors to user 2014-05-15 07:23:43 -04:00
Lukas Matt
6309e1a4ee Cleaned and optimized report model 2014-05-15 07:23:43 -04:00
Lukas Matt
0fae1137fa Using unless instead of 'if !' 2014-05-15 07:23:43 -04:00
Lukas Matt
1a0c9f5983 Make report-type translatable 2014-05-15 07:23:43 -04:00
Lukas Matt
6f21ccda06 Using case instead of equal 2014-05-15 07:23:43 -04:00
Lukas Matt
26d0c81dae Added the ability to disable report-email-notification
Podmin can see a extra checkbox in Settings > Account
for disabling report-email-notification
2014-05-15 07:23:43 -04:00