extending loaded js locales.
cleaned up unused routes. removed some comments. loading help locales only on help view.
removed afterRender from backbone views. extended load_javascript_locales method to take a section.
removed unused help haml templates.
put locales back to how they were and wrote a small js parser to swap in links to help views which have generated links in them.
using locales text for help section headers.
changed the locales to have the hard coded urls in them because they can no longer be calculated server side. this is pretty crap because i'm going to have to change it for all the languages now so i might change my mind about this later.
deleted some unused views.
in features/desktop/aspect_navigation.feature:18 we quickly leave the page
before waiting for the request to finish. By making the HTTP call
synchronous we wait for it to finish before we reflect the change in the DOM,
thus giving Capybara a chance to wait for it. Also let Capybara wait longer.
This should random failures of the aforementioned cuke rarer.
- updates underscore to 1.5.2 and backbone to 1.1.0
backbone had some breaking changes:
- fix url/urlRoot handling in models & collections
- options are no longer attached to the view by default
- collections reset when 'fetch' is called, tell it to keep the existing
models
other changes:
- fix some events triggering multiple times in connection with deleting
a model
- use document fragments instead of an element array for stream entries
- adapt jasmine and cucumber specs to the changed code
* no longer test the backbone router as part of our code
* jasmine factory already returns model instances, no need to wrap
that again
You can report a single post by clicking the correct icon in the controler section
Workflow:
* Report a post as offensive
* Trigger alerts to every pod-admin
* Pod-admin can review it in the admin interface
* Delete the post or mark it as reviewed
- This gives the user the sense of what he/she is currently viewing
- The hover/selected are the same right now. Needs to change.
- Need to find a more meaningful place for `markSelected`
Moved markSelected to app.views.Stream
- Removes duplication
- All streams create this view, and this seems to do some setup on
initializing, which is a good place to markNavSelected
Changing highlight on hover to 'black' instead of the blue
- The blue was a little intruisive
- Also fixes the vertical alignment issue
Changing the background to bluebg on hover
- Each time a stream is rendered, other lists are emtied
- Using Backbone.history.fragment to detect active stream
- hideInactiveStreamLists is best pushed into a before/after filter
Added tests for hideInactiveStreamLists
- This action needn't be performed when all notifications are read,
hence disabling it is a good practice
- Added a link-disabled-color
- Used css pointer-events to disable clicking on the link
Preventing default on click for the mark_all_read_link
- avoiding the use of pointer-events
- setting up disabled only for mark_all_read_link
Moved disabling of the link to a global handler
- Added disabled class to the button in /notifications when all are read
- Styled the disabled button
- Adding disabled class after completion of ajaxRequest
- Earlier, triple-clicking or drag & select had to be performed to select
- Should consider a copy button
Moving away from the inline onClick handler
It didn't feel right to be writing js in a helper.
Refactoring setupInviteLinks into a sidebar Backbone View
Added search_controller_spec, moved some tests from people_controller_spec to search_controller_spec
Fixed merged conflict in Changelog
update routes and search controller
remove useless except from search controller
Fix indentation in search_controller
clarify regexp and correct some bad backtracking
add specs
rewrite regex
convert mardown style title to plain text title
fix bad indentation
add jasmine test for post-viewer.js
tries to fix bad jasmine test
* removed wait_until where possible
* replaced wait_until with DOM obersavtions
* added match: :first to all finders that assumed getting the first element
* replaced evaluate_script with execute_script where possible
* replaced a few execute_script with DOM observations through Capybara
* removed sleep where possible
* replaced sleep with DOM obersvations
* replaced "wait for ajax" with DOM obersavations
* replaced alert confirmation with new selenium API
* bump selenium webdriver
* made any other fixes to get green again
