Dennis Schubert
744f5449fb
Merge branch 'next-minor' into develop
2023-07-10 01:19:08 +02:00
Dennis Schubert
42b835f0c0
Enforce an ImageMagick policy.xml for all pods.
...
This fix was heavily inspired by Mastodon's fix for GHSA-9928-3cp5-93fm.
So, thank you Cure53 for finding this issue, thank you Mozilla for
paying Cure53 to look into it, and thanks for Mastodon for fixing it.
2023-07-10 01:12:36 +02:00
Benjamin Neff
763dffa328
Always strip exif data and drop user setting for it
...
Some imagemagick-versions (I tested Ubuntu 22.04 and debian bullseye)
always loose exif data when converting from jpg to webp. So this made
our CI fail now, but even if it wasn't failing before, some pods always
had and have versions which might loose the information anyway. So
having a setting to keep exif information is kinda pointless, if we
can't guarantee that the information isn't lost. Also, diaspora isn't a
photo sharing platform and we don't display exif information anywhere,
so I think we should just always strip exif data (which was already the
default before), as we don't need them.
2023-06-04 04:25:01 +02:00
Thorsten Claus
492ac74819
Issue #8355 : Adding webp as supported file format
...
Converting all uploaded images to the webp format.
2022-07-01 13:50:01 +02:00
Benjamin Neff
d5b7c6d779
Don't relay others relayable on archive import
2019-05-21 23:08:34 +02:00
Benjamin Neff
e82690963d
Add # frozen_string_literal: true to all files
2017-09-17 19:29:15 +02:00
Benjamin Neff
31e85f32ac
Bump carrierwave
2017-07-22 23:43:07 +02:00
cmrd Senya
0ee34f8590
Remove the photo comment spec
...
This functionality is not something we support and it doesn't look
it will be reintroduced soon.
see discussion https://github.com/diaspora/diaspora/pull/6818#discussion_r70227392
2016-11-28 15:35:36 +02:00
Justin Ramos
fa71af71c1
require spec_helper in .rspec
...
closes #7223
2016-11-27 21:27:12 +01:00
Benjamin Neff
d3edbfd829
remove pending flag from posts
2016-08-08 19:37:10 +02:00
Benjamin Neff
fa5a35ed4a
remove xml specs
2016-06-26 06:21:01 +02:00
Benjamin Neff
566f4890a2
merge Federated::Shareable to Shareable
...
also drop xml-code for Shareable
2016-06-26 06:21:01 +02:00
Benjamin Neff
6fbfc2bf96
write receive specs and delete old unused specs
...
also refactored receive methods
2016-06-26 06:20:59 +02:00
Benjamin Neff
58a5a881cf
receive local
...
* Contact: auto-follow-back
* Shareable: create share visibilities
2016-06-26 06:20:59 +02:00
Benjamin Neff
b1d30aa9cc
add more "diaspora to federation entity" methods
...
move it to Diaspora::Federation::Entities and use it in some tests, but most of the tests can be removed later.
2016-06-26 06:20:58 +02:00
Steffen van Bergerem
05a6d95811
Always show public photos
...
closes #6398
2015-09-14 22:04:53 +02:00
JoeBew42
e21dad780d
Refactoring tests on photo saved with and without EXIF data
...
closes #6183
2015-07-16 11:12:12 +02:00
Benjamin Neff
d42b5c128e
update photos when received over public path
...
closes #6082
2015-06-08 04:18:31 +02:00
Benjamin Neff
7cccb6594f
remove security hax comment
2015-05-18 03:23:15 +02:00
Marcelo Briones
63eca447d0
Strip EXIF data as user preference
2015-01-18 10:28:28 -03:00
khall
c42916df27
Two tests failing after rspec 2.99 => 3.0.0
2014-08-26 17:10:26 -07:00
khall
027bb9fcb0
Rspec version bump to 2.99
2014-08-26 17:00:21 -07:00
Jonne Haß
32b9caa08c
replace stub and mock deprecations with doubles
2014-01-13 12:25:38 +01:00
James Fleming
66a07bd938
Remove attributes protection.
...
Use a blacklist approach instead of a blacklist approach in Profile#receive.
Remove attr_accessible from models and make specs pass.
2013-08-02 11:39:06 +02:00
Braulio Martinez
00a3332013
Remove unnecessary ruby187 hacks
2013-05-02 10:07:30 -03:00
Jonne Haß
79a79d65d6
Bye Resque. Ohai Sidekiq.
...
* Dropped all references to Resque
* Moved all jobs under app/workers since that's the Sidekiq convention
* Renamed Jobs module to Worker to match new location
* Adapted all jobs to Sidekiq
* Replaced all enqueue calls with perform_async
* Dropped Resque hacks from specs and features, replaced with
sidekig/testing in RSpec and sidekig/testing/inline in Cucumber
* Updated scripts to start a Sidekiq server
* Inline Sidekiq sinatra app
* Let Sidekiq create the actual Redis instance
* Workaround already initialized constant warnings in service models
* Resolved ToDo in one job definition by creating proper exception clases
for some errors in receiving posts
* Added sidekiq section to configuration to make it completly
configurable to the user
* Add Sidekiq middleware for clean backtraces
* Delay HttpMulti retry to give offline pods a chance to come back up
* Do not retry on GUID already taken and alike errors
* Be graceful about deleted posts in GatherOEmbedData
2013-03-21 23:39:07 +01:00
Jonne Haß
4fc2cb1cba
bump carrierwave
2012-11-11 13:29:40 +01:00
Jonne Haß
58d1448085
update factory girl
2012-09-12 13:24:23 +02:00
Jonne Haß
088446e86e
bump rspec-rails, remove deprecated rspec syntax
2012-09-11 00:46:36 +02:00
Maxwell Salzberg
b124d3e5a1
Revert "update factory girl" new version does not support 1.8.7 :(
...
This reverts commit c52342b7cb .
2012-05-16 17:43:56 -07:00
Maxwell Salzberg
c52342b7cb
update factory girl
2012-05-16 17:17:14 -07:00
Maxwell Salzberg
63a0a37171
width and height should now federate
2012-04-20 12:53:02 -07:00
Maxwell Salzberg
1b2440f68a
we now store image height and width locally; still need to federate the values
2012-04-20 12:22:12 -07:00
danielgrippi
02021584a7
EvilQuery for Participation, refactor comment creation
...
you can now create a comment with User#comment!(post, text)
2012-02-01 15:09:31 -08:00
Maxwell Salzberg
49f18d435a
upgrade factory girl there are 3 failing cukes.
2012-01-21 21:58:50 -08:00
danielgrippi
91e3f5f6ff
remove cache counter for photos, as it was causing too many edge-case errors & added complexity across models
2012-01-14 15:40:43 -08:00
danielgrippi
240d595714
removing photos_count method from StatusMessage in hopes of fixing the counter (still a bit confused, though...)
2012-01-13 23:33:59 -08:00
danielgrippi
e9b6da605f
fix specs; move presence_of_content validation check into a before_destory to play nicely with federation
2011-12-20 10:42:30 -08:00
Sarah Mei
f1d669a024
Delete all pending specs except stuff we actually want to fix in the short term. Add more useful comments to those.
2011-11-06 21:29:22 -08:00
Ilya Zhitomirskiy
d51516fff3
bumped carrierwave, photos can now be downloaded from a url, fetching profile photo job
2011-10-24 11:00:00 -07:00
Dan Hansen
3eaa1c0584
moved photo processing from model to resque job, added tests
...
removed Photo#not_processed
2011-10-03 14:58:44 -05:00
danielgrippi
97f80272b2
DG MS; changed Job:: to Jobs::; require all mail jobs from Job base class
2011-09-15 12:42:53 -07:00
danielgrippi
91e649977c
MS DG update copyright
2011-09-14 11:23:12 -07:00
The Lambda Calculus
83fc972c61
Added RSpec test for #1126
2011-09-13 23:27:54 -04:00
Maxwell Salzberg
665facaeb0
DG MS renamed private dispatcher; started refactor including public
...
dispatcher
2011-09-12 17:02:40 -07:00
Sarah Mei
1bbfa97e5f
DH SM MS pending photo spec for Dan
2011-06-30 21:04:18 -07:00
Raphael Sofaer
df04b59857
Change :on to :post in the comment and post methods
2011-06-01 16:45:29 -07:00
Sarah Mei
f29a605a7c
Remove photo-related pending specs.
2011-05-25 09:08:49 -07:00
Raphael Sofaer
fdd158d86a
Make urls not change on processing
2011-03-21 18:42:36 -07:00
Raphael Sofaer
2b997e70c2
Refactor image processing to use 2 uploaders. Federation and s3 need testing
2011-03-21 16:40:53 -07:00