Jonne Haß
c5ecc872ce
add integration spec for retracting a comment
2013-02-28 17:20:33 +01:00
Jonne Haß
ccedb6eff0
delegate parent_author to the target of a RelayableRetraction
2013-02-28 17:01:58 +01:00
Jonne Haß
cf9659de4a
fix XSS vulnerability in conversations#new, closes #4010
2013-02-26 19:09:30 +01:00
pestrada
3f3409a0a5
avoid posting empty comments
...
fix Jasmine test
updated changelog with bugfix #3836
fix changelog update
remove wrong bug fix line
2013-02-25 18:27:46 -06:00
Jonne Haß
0cf1c2d020
Sort tag followings alphabetically, not in reverse, fixes #3986
2013-02-24 16:22:01 +01:00
Jonne Haß
35350d1ceb
Include reshares in the public user feed, closes #1781
2013-02-21 14:32:28 +01:00
Jonne Haß
ba9aee5902
update changelog; replace "pre" releases with a plain "head"
2013-02-18 20:20:50 +01:00
Jonne Haß
1f4787aa6d
Merge pull request #3980 from L3MNcakes/feature/facebook_delete
...
Feature/facebook delete
2013-02-18 11:17:51 -08:00
L3MNcakes
1120cba5f0
Issue #3939 : Posts to Facebook do not delete
2013-02-18 18:21:59 +00:00
Jonne Haß
f3093ca8ae
Merge pull request #3864 from Raven24/aspect_memberships
...
[WIP] aspect membership dropdown Backbone.js rework
2013-02-17 05:54:12 -08:00
Florian Staudacher
4cbae601e8
[WIP] aspect membership dropdown Backbone.js rework
...
* initial backbone port
* changed AspectMembershipsController#destroy to use aspect_membership_id
* included rudimentary jasmine specs
* more specs, updating the list elements after de-/selection
* update selected aspect count on button
* don't even try to render html in AspectMembershipsController
* more specs for button summary text
* adapt aspect management on contacts page and in the popup boxes
* adapt inline creation of aspects + memberships
TODO
* more tests
2013-02-17 13:40:10 +01:00
Jonne Haß
0a124acdf0
Revert "fix regression from #3968 "
...
Revert "Merge pull request #3968 from marpo60/limit_shareable_from_person_queries"
This reverts commit ddfc558a9b .
This reverts commit 30ed4b4e70 , reversing
changes made to f50ce2cb1d .
limiting the fetch of the IDs breaks paginating, there's no quick way to fix that
I left the spec in for future use.
2013-02-16 23:48:10 +01:00
Jonne Haß
ddfc558a9b
fix regression from #3968
...
Not ordering the IDs caused incorret ones returned
The spec is totally at the wrong level but I couldn't make
something up that exposed the bug at a deeper level :(
2013-02-16 23:22:14 +01:00
Lennart Prelle
2d0abe8309
added a id and a autoscroll to first unread message in conversation ( Fix : #3216 )
2013-02-11 16:15:01 +01:00
Ruxton
60f5173c77
Spec coverage for changelog_url and adjustment to behaviour
2013-02-04 11:00:57 +08:00
Jonne Haß
b8128d356b
Merge branch 'hotfix/0.0.2.4' into develop
...
Conflicts:
Changelog.md
app/views/people/show.html.haml
config/defaults.yml
spec/helpers/layout_helper_spec.rb
2013-02-01 22:24:37 +01:00
Jonne Haß
7134513b28
Fix XSS vulnerabilities caused by not escaping a users name fields when loading it from JSON. #3948
...
From a quick look at the for us available databases this was not actually used in the wild.
2013-02-01 22:20:31 +01:00
Asphyxia
6df84ed703
Fix wrong message on infinite scroll on contact page
2013-01-31 23:09:51 -03:00
Jonne Haß
baadb49ebf
Merge pull request #3844 from asphxia/feature/3672-reshare-alert-box-appearing-twice
...
Issue #3672 : Reshare alert box is appearing twice
2013-01-31 11:13:13 -08:00
Jonne Haß
01299ee8e8
update spec to match overriden translation
2013-01-31 19:25:30 +01:00
Asphyxia
1ed0318db7
Reshare alert box is appearing twice
2013-01-31 14:52:47 -03:00
Jonne Haß
4eb98cd7dc
Merge branch 'settings_mobile' of git://github.com/movilla/diaspora into movilla-settings_mobile
...
Conflicts:
Changelog.md
2013-01-29 14:58:11 +01:00
movilla
0010819343
add settings web mobile
2013-01-27 20:38:19 +01:00
Ruxton
e8decc200e
Adding jasmine coverage for oEmbed updates
2013-01-25 23:47:49 +08:00
Ruxton
60024d7e20
Someone isn't a StarWars fan.
2013-01-25 22:43:56 +08:00
Jonne Haß
64b86b27c1
bump rspec-rails and rspec
...
fix two specs by not checking for object identity
2013-01-17 02:00:03 +01:00
Fabián Rodríguez
d7574a9efb
add locale to aspects
2013-01-16 19:59:10 -02:00
Fabián Rodríguez
f978a75b8c
bootstrap my_aspects data
2013-01-16 19:33:20 -02:00
Fabián Rodríguez
c0417fab93
add specs for the aspects
2013-01-16 19:33:20 -02:00
Diaspora Europe
ac3b2bc99f
pod version in footer and updated link to changelog #3705
2013-01-15 16:45:10 +01:00
Fabián Rodríguez
aabbea6ee2
fix issue #3671 reshare a post multiple times
2013-01-12 04:52:56 -02:00
Diaspora Europe
c8ddba6b3e
add images to notifications
2013-01-11 12:30:12 +01:00
Florian Staudacher
0092acd492
re-add hovercards
...
* added a presenter for hovercard json
* added new backbone view for handling hovercard JS
* refactoring of PeopleController
* finished the backbone js version of hovercards
* don't try to make people_controller more restfull, out of scope
just add a new route and use that for hovercard json
* added spec for people_controller#hovercard
* add new exception for "AccountClosed" to be able to raise from anywhere
* removed legacy code, since everything got ported to backbone
(except the "cache" stuff, but that's not strictly necessary)
2012-12-28 22:37:13 +01:00
movilla
597ab20715
Show error and flash-notice when sending messages to non contacts
2012-12-26 12:23:37 +01:00
movilla
c1b858a877
Mark all unread post-related notifications as read, if one of this gets opened
2012-12-24 00:13:32 +01:00
Florian Staudacher
94760f4c04
update jasmine gem, removed useless spec, + changelog)
2012-12-07 21:21:27 +01:00
Jonne Haß
669dd87b11
extract configruation system to a gem
2012-11-30 13:35:59 +01:00
Jonne Haß
bf698f3882
Do not strip "markdown" in links when posting to services, fix #3765
2012-11-26 14:16:43 +01:00
Jonne Haß
7b548fd571
Merge pull request #3713 from davecocoa/feature/3630-backbone-ify-followed-tags
...
port tagFollowings to BackBone
2012-11-25 09:30:47 -08:00
rschaden
49d4079065
add email validation to invitations
2012-11-25 14:25:20 +01:00
Bobby Wilson
abd4e17daf
Fix #3750
2012-11-22 13:00:47 -07:00
Jonne Haß
c59bb35087
Merge pull request #3754 from marpo60/housekeeping
...
Housekeeping2
2012-11-22 01:06:30 -08:00
Jonne Haß
5f6e03cfe5
Merge pull request #3714 from marpo60/refactor
...
Housekeeping
2012-11-22 01:06:05 -08:00
Fabián Rodríguez
be2db47f02
remove unnecesary stuff from specs
2012-11-21 18:26:17 -02:00
Fabián Rodríguez
99abc22403
remove unused methods
2012-11-21 18:26:17 -02:00
David McMullin
97664cb880
port tagFollowings to BackBone
2012-11-12 21:37:00 +00:00
Jason Robinson
c437636131
Fix message_spec test and add tests for private message notification unread count. Update changelog
2012-11-12 22:00:13 +02:00
Jonne Haß
63f2d335a4
Merge branch 'notifications_count' of git://github.com/movilla/diaspora into develop
2012-11-11 15:00:46 +01:00
movilla
554fe40235
Web mobile notificacions count dont change to unread-read when click in link post
2012-11-11 14:45:07 +01:00
Jonne Haß
4fc2cb1cba
bump carrierwave
2012-11-11 13:29:40 +01:00
movilla
10aea3ebce
add test :unread => true
2012-11-10 23:23:08 +01:00
Jason Robinson
48a332f871
Remove by default markdown formatting from posts done via service, currently only used by Twitter. Remove markdown also from Facebook posts.
2012-11-09 00:04:49 +02:00
Sean Tilley
7dfa6299ec
Merge branch 'reshares_count_stream' of https://github.com/movilla/diaspora into movilla-reshares_count_stream
...
Conflicts:
Changelog.md
2012-11-07 21:04:52 -06:00
Braulio Martinez
ab3a7d991c
Remove ugly whitespaces
2012-11-07 23:16:25 -02:00
Braulio Martinez
3260bada38
Remove posts#new action from Rails and related tests
2012-11-07 23:14:35 -02:00
Fabián Rodríguez
4056c0da9e
remove unused method #can_add?
2012-11-06 21:39:36 -02:00
movilla
5a2b22ff0c
reshares_count come back!
2012-11-06 21:05:48 +01:00
Jason Robinson
7fafabdb60
Only include url to post for twitter when post exceeds maximum length or contains photos
2012-11-03 23:25:19 +02:00
Jonne Haß
2a45470232
Merge branch 'feature/fix-facebook-public-posts' of git://github.com/jaywink/diaspora into feature/fix_services
...
Conflicts:
Changelog.md
app/models/services/facebook.rb
spec/models/services/facebook_spec.rb
2012-11-02 11:31:47 +01:00
Jason Robinson
e974d2934f
Always use basic Facebook Graph API to post messages, fixes public posts. Remove unnecessary Facebook opengraph config items
2012-11-02 00:23:33 +02:00
Jonne Haß
5a70311fe7
update and fix services
2012-10-25 17:54:18 +02:00
Jonne Haß
1a93ccd548
don't error out if the root of a reshare of a reshare got deleted, fixes #3546
2012-10-24 19:51:31 +02:00
Dennis Schubert
5ea998a382
Change 'unless' to 'if' again because 'unless' is wrong here.
...
Also, add some specs and add it to the changelog.
2012-10-24 00:27:45 +02:00
Florian Staudacher
0057e9ed46
some small code style changes + final fix for postgres (milliseconds)
...
+ updated changelog
2012-10-21 16:10:27 +02:00
Ruxton
25b57cdd2a
trying to stabilize issue with datetime in test suite
2012-10-21 16:08:57 +02:00
Ruxton
a78cb352e6
updated spec to fix to_datetime issue
...
Conflicts:
spec/lib/diaspora/fetcher/public_spec.rb
2012-10-21 16:08:57 +02:00
Florian Staudacher
2694c930a5
Merge pull request #3645 from Raven24/fix-link-regex
...
simplify link regex and fix #3553
2012-10-19 02:24:24 -07:00
Gonzalo
e1756b5b3f
Privatize non-action controller methods
2012-10-14 19:32:53 -02:00
Gonzalo
78953fe2bf
Move ApplicationController specs to application_controllers_spec
2012-10-14 19:32:53 -02:00
Jonne Haß
92e4cd34ae
--amend cause I've no time
2012-10-14 01:11:53 +02:00
Jonne Haß
894af48579
add spec to ensure include_community_spotlight? is correctly passed into EvilQuery::MultiStream.new
2012-10-14 01:09:00 +02:00
Gonzalo
83809c924a
Refactor MessagesController
2012-10-13 17:10:52 -02:00
movilla
ebd1b28b2d
Fix problem javascript with read-unread notifications on notifications popup
2012-10-13 15:16:06 +02:00
Fabián Rodríguez
82082005ba
redirect users back on registration failure
2012-10-11 19:47:04 -02:00
Florian Staudacher
ded69477ba
replace the monstrous link regex with a slightly less complicated one,
...
based on the one from the markdown parser, fixes #3553
adding a list of urls for testing the regex in the specs
2012-10-11 23:39:44 +02:00
Jonne Haß
3eb628c2a3
fix french javascript pluralization rule and add specs for locale loading
2012-10-09 22:36:30 +02:00
Florian Staudacher
a9bec8a4ee
Merge branch 'hotfix/oembed-selector' into develop
...
fix for the click event handler on oembed-ed content
2012-10-03 19:12:48 +02:00
Florian Staudacher
bf82fc17fe
fix oembed onclick behavior + specs
2012-10-03 19:05:17 +02:00
Jonne Haß
5c7a9c1ce6
Release cleanup, closes #3620
...
* remove un-/underused gems
* remove their associated files
* remove some parallel_tests leftovers
2012-09-30 22:26:23 +02:00
Florian Staudacher
8678c14735
Merge pull request #3589 from MrZYX/refactor_config
...
New configuration system, details: see changelog
2012-09-30 13:07:40 -07:00
David McMullin
586e23727c
add specs for chromeframe
...
fix typo in ChromeFrame itself
remove unneccessary chromeframe meta tags from layouts
2012-09-30 17:04:50 +01:00
Marek Lewandowski
125e45cdba
Force user to authenticate instead of raising error
2012-09-29 16:57:34 +02:00
Jonne Haß
89c1fd5f7f
query the set url only through #pod_uri in the app
2012-09-26 20:19:37 +02:00
Jonne Haß
2a4db54db9
New configuration system
...
* Throw away old system
* Add new system
* Add new example files
* Replace all calls
* add the most important docs
* Add Specs
* rename disable_ssl_requirement to require_ssl
* cloudfiles isn't used/called in our code
* since community_spotlight.list is only used as enable flag replace it with such one and remove all legacy and irelevant codepaths around it
* die if session secret is unset and on heroku
* First basic infrastructure for version information
2012-09-26 20:19:37 +02:00
Jonne Haß
7a478704d5
just stop settingslogic from breaking rspec output for now
2012-09-26 18:54:14 +02:00
Jonne Haß
e70e48d6ca
some refactoring regarding the law of demeter
2012-09-23 19:33:19 +02:00
Devendra
a2fa083c3e
added rspec tests and refactored user model to use scope, for daily, monthly, and yearly actives
2012-09-22 01:56:34 +05:30
Jonne Haß
8674f5aea2
Merge branch 'hotfix/redis_url' into develop
2012-09-18 15:55:32 +02:00
Jonne Haß
2f9dbdbd86
use self instead of AppConfig to query redis_url inside AppConfig
2012-09-18 15:52:57 +02:00
Florian Staudacher
8193978fd2
in 'standalone' mode, the close button is hidden
...
... publisher is embedded into something, that has its own close button
2012-09-17 20:46:33 +02:00
Florian Staudacher
452de1b866
fix remaining cukes and some cleanup
2012-09-17 20:35:38 +02:00
Florian Staudacher
200887ca45
adapt jasmine specs to the new structure
2012-09-17 15:33:52 +02:00
Jonne Haß
6c1a1ec6d2
it's enviroNment
2012-09-15 18:52:12 +02:00
Jonne Haß
4bada36bf1
do not redirect admin to his profile upon sign in
2012-09-14 15:01:19 +02:00
Jonne Haß
358ed79f99
Merge branch 'update_devise'
...
Conflicts:
Gemfile.lock
2012-09-12 15:11:34 +02:00
Jonne Haß
142e38e78b
update devise
2012-09-12 13:29:57 +02:00
Jonne Haß
58d1448085
update factory girl
2012-09-12 13:24:23 +02:00
Jonne Haß
7ec2f8f419
finish beta striping
...
A lot of cleanup is still needed, refactoring the CSS to be consistent, removing all sorts of unused stuff etc
2012-09-12 07:51:19 +02:00
Jonne Haß
ab0ad630df
strip last beta leftovers and fix syntax errors, travis is kinda down, lets hope nothing breaks while I sleep
2012-09-12 05:48:12 +02:00
Jonne Haß
088446e86e
bump rspec-rails, remove deprecated rspec syntax
2012-09-11 00:46:36 +02:00
Jonne Haß
8a759c3aca
Use Builder::XChar.encode instead of to_xs in spec
2012-09-07 00:09:43 +02:00
Jonne Haß
a488dd50c4
follow up of last commit fixing remaining specs
...
changed spec since it didn't actually test what it said
2012-09-06 22:11:04 +02:00
Jonne Haß
81442f0f2a
Erb::Util.h now escapes ' which it didn't before
...
this is what 3.2.8 actually fixes to prevent XSS iirc
We're including the raw message in the atom feed so
we should test for it
2012-09-06 21:12:49 +02:00
Jonne Haß
60e8107763
remove percent memory/swap usage info in testsuites
2012-09-06 20:36:56 +02:00
Florian Staudacher
2e3da0cf05
fix date and guid assignment for fetched posts
2012-09-06 18:16:40 +02:00
Florian Staudacher
99c6b8bf45
don't test for actually deleted likes,
...
instead check whether the `retract` method was called, everything
else should be tested there.
2012-09-05 23:48:23 +02:00
Maxwell Salzberg
e0408e6fae
dont auto beta flag anyone
2012-08-20 10:39:14 -07:00
Florian Staudacher
645fa76b20
make the "last post" link show ownly if the person has any posts
...
(fixes #3437 )
2012-08-09 15:12:22 +02:00
Florian Staudacher
1a94a24fde
fix autolinking links that start with just www... and not a complete http://...
...
(fixes #3468 )
2012-08-09 13:09:06 +02:00
Florian Staudacher
fb9da740bb
Merge pull request #3482 from Raven24/public-fetcher
...
first working version of a 'post fetcher' for remote accounts
2012-08-08 06:42:45 -07:00
Florian Staudacher
6613522097
implement "special symbols" (switch certain strings for utf-8 symbols), fixes #3140
2012-08-08 00:26:20 +02:00
Florian Staudacher
8d512c22ac
fix markdown linking of images, also improve tests grammatically
...
+ 1 js syntax error
2012-08-07 23:53:24 +02:00
Florian Staudacher
932fb186e3
fix failing bookmarklet specs (wait for js to finish)
2012-08-04 16:10:11 +02:00
Florian Staudacher
8f1204d05a
first working version of a 'post fetcher' for remote accounts
2012-08-04 13:22:03 +02:00
Florian Staudacher
c7f66ee647
add specs for #3464
2012-07-25 15:22:53 +02:00
Florian Staudacher
1809897aa2
should fix the mobile toggle for the case: desktop --to--> mobile #3299
...
also, (possibly) fix tablet issue #3421 , + tests
2012-07-04 01:47:55 +02:00
Maxwell Salzberg
190fceaf5c
[SECURITY FIX] please update your pod ASAP
...
This is a fix for public messages, where a malicious pod could spoof a message from someone a user was connected to, as the verified signatures were not checked that the object was also from said sender. This hole only affected public messages, and the private part of code had the correct checks
THX to s-f-s(Stephan Schulz) for reporting and tracking down this issue, and props to Raven24(florian.staudacher@gmx.at ) for helping me test the patch
2012-07-02 10:00:12 -07:00
Jonne Haß
8434b25e56
do not bypass pluralization in test
2012-06-24 13:03:22 +02:00
Steven Hancock
ee6941fa18
Get Spork running again
...
Use Rails.root.join in `spec/spec_helper.rb` to help Spork find
`helper_methods.rb` and `spec_doc.rb`.
2012-06-14 00:53:10 -07:00
Steven Hancock
a8de3a5a3f
Rails.root and File.join cleanup
...
- `Rails.root` is a `Pathname`, so let's use `Rails.root.join`
- Clean up most of the remaining `File.join`s
2012-06-11 03:13:20 -07:00
Florian Staudacher
e021fd821d
Merge pull request #3362 from diaspora/non-public-error-page
...
show a "post is not public" message when visitor is not logged in
2012-06-11 02:35:48 -07:00
Zach Prezkuta
9f6d84141c
fix incorrect comment on RSpec text
2012-06-09 09:34:06 -06:00
Zach Prezkuta
44e43158cc
add rspec test and make fix more rails-y
2012-06-08 22:51:16 -06:00
Florian Staudacher
8ca39f5936
show a "post is not public" message when visitor is not logged in
...
and tries to access a show page of a non-public post
2012-06-07 22:16:37 +02:00
Maxwell Salzberg
1da029a22f
this stopped working because there is a new way to render views by default in spec_helper.rb
2012-06-04 12:49:24 -07:00
Maxwell Salzberg
304c33f19e
explicitly render_views in publics controller
2012-06-04 12:49:24 -07:00
danielgrippi
a836b06d3e
mixpanel on posting
2012-05-30 17:32:18 -07:00
Dennis Collinson
a9288daf19
refactor stream page scroll spy
2012-05-30 16:58:21 -07:00
danielgrippi
d8470d303a
simple mixtracking
2012-05-30 15:25:19 -07:00
Maxwell Salzberg
6dba7fe9a9
fix case sensitivity
2012-05-30 12:44:39 -07:00
Maxwell Salzberg
82c4e0d577
add a podname app config var, and use it throughout the app
2012-05-30 12:11:59 -07:00
Steven Hancock
99a2865e23
Make hashtags clickable in emails
...
Refactor the Redcarpet renderer created in c2bc7272f to parse hashtags
into clickable links (for HTML emails only).
2012-05-29 10:01:58 -07:00
Steven Hancock
c2bc7272fb
Escape hashtags in emails
...
Custom Redcarpet renderer to escape hashtags (but not legitimate headers)
in emails before Markdown processing. Prevents hashtags from being rendered
as H1 headers. This also leaves open the possibility of parsing hashtags
into clickable links in the future.
fixes #3325
2012-05-28 21:31:27 -07:00
Dan Hansen
d334097ee2
bugmash #3
...
persist unsaved comment value after expanding comments
2012-05-24 19:08:43 -07:00
Florian Staudacher
f19f6110b1
match tag arrays by what they actually contain, not by order
2012-05-24 22:18:10 +02:00
Dennis Collinson
c4240154b1
back to profile works
2012-05-24 12:43:06 -07:00
danielgrippi
58ac040f8f
clicking a permalink on the new stream does not make an HTTP request to go to the post's page
2012-05-24 12:05:27 -07:00
danielgrippi
3e09d4ed14
Revert "don't seed beta users with default aspects"
...
This reverts commit 946f78b025 .
2012-05-24 11:42:52 -07:00
Dennis Collinson
f3174941bd
fix the "has no posts" on back bug.
2012-05-24 11:40:27 -07:00
danielgrippi
946f78b025
don't seed beta users with default aspects
2012-05-24 11:37:34 -07:00
Maxwell Salzberg
bed07872f2
composer now prevents you from submitting an empty frame.
2012-05-24 11:36:43 -07:00
Maxwell Salzberg
d270910500
set the submit button to be disabled on the framer, and write a test
2012-05-24 11:36:43 -07:00
Maxwell Salzberg
82218fd7cb
new stream now remembers how far you have scrolled.
...
also, jasmine is really cool.
2012-05-23 17:25:40 -07:00
Maxwell Salzberg
92c0fa0163
backfill some stream.js specs
2012-05-23 17:25:40 -07:00
danielgrippi
5d2ea71766
added EditbaleSmallFrame class; frame on framer second step is partially editable
2012-05-23 17:07:41 -07:00
Dan Hansen
cf847d61ba
bug mash #5
...
fix NoMethodError on InvitationsController
2012-05-23 13:05:01 -07:00
danielgrippi
0e1c66f5b6
DG MS; only show applicable frames in the framer step
2012-05-23 12:59:27 -07:00
danielgrippi
92cbcae9c3
DG MS; moved framer controls into a subview & off to the side
2012-05-23 12:16:35 -07:00
danielgrippi
120c6b46e0
MS; Fix fake following, as we took it out so I nuked the tests
2012-05-22 19:04:04 -07:00
Dennis Collinson
1c342282b0
fixing event passing
2012-05-22 15:11:21 -07:00