Commit graph

18990 commits

Author SHA1 Message Date
Finn Woelm
070ef782e6 Fix: Failing 'Signs Up'-Feature Tests
Up to now, scripts were loaded prior to the stylesheet in <head>. When
scripts are loaded before stylesheets, it is possible that scripts
execute on the DOM elements before styles are fully loaded. This can
yield unexpected results.

In the case of the features/desktop/signs_up.feature tests, it would
happen every so often that the scripts ran before styles were loaded.
For example, the app.views.Publisher class (responsible for actions
related to creating a new post) relies on the poll element being either
hidden (or poll options being defined). As per stylesheet, the poll is
hidden by default. But when the scripts run before the stylesheet has
loaded, the poll appears visible to the script and post submission is
disabled.

This is fixed by loading stylesheets prior to scripts. See SO for more
info: https://stackoverflow.com/a/1324720/6451879
2017-07-18 18:38:36 +07:00
Benjamin Neff
21263edbdf
Merge pull request #7491 from UpshiftNetwork/fix-failing-mention-features
Fix: Use Capybara#fill_in for appending to publisher
2017-07-14 13:23:47 +02:00
Finn Woelm
14b7c10567 Fix: Use Capybara#fill_in for appending to publisher
Capybara's native#send_key function is slow when it is passed a string
longer than just a few characters. This often results in timeout issues
and Capybara (falsely) reporting feature as failing.

To fix this, we use the faster function #fill_in. This does not trigger
JavaScript events on the input, so we manually trigger them after
fill_in by just sending a single key. This can be any key but since we
do not want to modify the text in the input, non-text keys should be
used. For a list of non-text keys, see
http://www.rubydoc.info/github/jnicklas/capybara/Capybara%2FNode%2FElement%3Asend_keys

There is an alternative to the above:
1) Use #fill_in to enter all text except for the last character:
    fill_in ..., with: "#{status_message_text} #{txt[0..-2]}"
2) And then use #send_key to send that last character:
    find("#status_message_text").native.send_key(txt.last)

At the moment, both approaches work equally well but the second approach
is documented here just in case it becomes relevant in the future.
2017-07-14 12:33:30 +07:00
Benjamin Neff
5d2ddfede1
Update changelog [ci skip] 2017-07-14 02:34:53 +02:00
Benjamin Neff
01ca08b86f
Merge pull request #7436 from SuperTux88/federation-update
Federation gem update
2017-07-14 01:31:32 +02:00
Benjamin Neff
8b7a592112
Merge pull request #7488 from UpshiftNetwork/fix-assets-check-2
Fix: Check for asset precompilation when starting server
2017-07-14 00:11:11 +02:00
Finn Woelm
78986e6419 Fix: Check for asset precompilation when starting server
When `public/assets/` is a symlink, running `find public/assets ...`
does not return the correct result. By using `public/assets/`, find is
able to return the correct result regardless of whether the folder is an
actual folder or a symlink.

[ci skip]
2017-07-13 21:41:11 +07:00
Benjamin Neff
6c1ebea633
Merge pull request #7483 from Flaburgan/7393-always-link-comment-mobile
Always link comment count text on mobile
2017-07-13 02:31:30 +02:00
Benjamin Neff
3817dc9a5b
Merge pull request #7480 from Flaburgan/7402-space-comment-mobile-spv
Fix height too high on mobile SPV, closes #7402
2017-07-13 02:31:07 +02:00
Fla
f94fa95653 Add a Contributing file 2017-07-12 16:14:58 +02:00
flaburgan
fc27640468 Always link comment count text on mobile 2017-07-12 16:00:26 +02:00
Benjamin Neff
d62d79bc29
Merge branch 'next-minor' into develop 2017-07-12 03:51:17 +02:00
Benjamin Neff
541dcbcd39
Merge branch 'master' into next-minor 2017-07-12 03:50:58 +02:00
Benjamin Neff
8bed8a84a3
Merge branch 'release/0.6.7.0' 2017-07-12 03:49:09 +02:00
Benjamin Neff
0e8bb71449
updated 126 locale files [ci skip] 2017-07-12 03:42:15 +02:00
Benjamin Neff
bc663253d2
Merge branch 'next-minor' into develop 2017-07-07 09:02:19 +02:00
Benjamin Neff
1ce736df16
Merge branch 'release/0.6.7.0' into next-minor 2017-07-07 09:02:10 +02:00
Dennis Schubert
e47895f3e1
Center .excellence-box contents
closes #7481
2017-07-07 09:01:34 +02:00
flaburgan
2dc142bd70
Add access to the report page on mobile for moderators
closes #7479
2017-07-07 08:58:42 +02:00
Benjamin Neff
2dc129d9be
Merge branch 'next-minor' into develop 2017-07-06 02:55:31 +02:00
Benjamin Neff
2244781615
Merge branch 'release/0.6.7.0' into next-minor 2017-07-06 02:55:26 +02:00
flaburgan
59c343c0c6
Increase poltegeist timeout
closes #7478
2017-07-06 02:51:14 +02:00
flaburgan
9146c8d80f Fix height too high on mobile SPV, closes #7402 2017-07-05 17:19:20 +02:00
Benjamin Neff
58609e42d7
Merge branch 'next-minor' into develop 2017-07-05 02:10:24 +02:00
Benjamin Neff
58aa59fb8e
Start 0.6.8.0 cycle 2017-07-05 02:07:45 +02:00
Benjamin Neff
068acd93ce
Cleanup changelog (no bugfixes in this release) 2017-07-05 02:04:07 +02:00
Benjamin Neff
0e13a316f6
Cleanup some translations
closes #7465
2017-07-05 02:02:13 +02:00
flaburgan
ddda28102c
Clean up the footer links a bit
closes #7446
2017-07-05 01:59:18 +02:00
flaburgan
ea9e50085d
Add link to discourse in footer and left side bar 2017-07-05 01:57:17 +02:00
flaburgan
07d0ed916d
Fix design issues + pronto
closes #7295
2017-07-05 01:51:07 +02:00
flaburgan
427aa8794e
Add tests for mobile drawer 2017-07-05 01:50:16 +02:00
flaburgan
2782edc780
Refactor partials + pronto 2017-07-05 01:50:16 +02:00
flaburgan
a7d97b7fd3
Add mobile message confirmation on user invit action, Refactor admin responsive code to use bootstrap grid
Hide pod version alert only in the mobile version, not depending on screen size
2017-07-05 01:50:16 +02:00
flaburgan
7bdf33e1a8
Move invitation form under the user search in admin
Indicates when there is no report to review to avoid a weird empty page
2017-07-05 01:50:16 +02:00
SansPseudoFix
5cb4c6e5df
Refactor, more partials + No version check for mobile 2017-07-05 01:50:16 +02:00
SansPseudoFix
276b640418
Add admin views to mobile, use partials for common code with desktop 2017-07-05 01:50:10 +02:00
Benjamin Neff
d71aa6a54a
Merge branch 'next-minor' into develop 2017-07-03 03:46:54 +02:00
atulonruby
df1139234f
Warn user if he leaves profile editing page #6520
closes #7473

closes #6589
2017-07-03 03:45:57 +02:00
Benjamin Neff
a931bee319
Make Participation entity non-relayable 2017-07-03 03:14:42 +02:00
Benjamin Neff
be8a1dfef4
Add tests for ContactRetraction 2017-07-03 03:14:42 +02:00
cmrd Senya
c2b9b8ab54
Use ContactRetraction for stop sharing with someone 2017-07-03 03:14:42 +02:00
Benjamin Neff
e2a40bb643
Send Relayables with parent author when the parent is local
Needed for diaspora/diaspora_federation#64
2017-07-03 03:14:42 +02:00
Benjamin Neff
4f9e560ab3
Use RFC 7033 webfinger from diaspora_federation gem 2017-07-03 03:14:41 +02:00
Benjamin Neff
283722a693
Use build_relayable_federation_entity helper for receive specs 2017-07-03 03:14:41 +02:00
Benjamin Neff
3ab674552f
Rename xml_order to signature_order 2017-07-03 03:14:41 +02:00
Benjamin Neff
0f551c7b19
Fix public flag for contact retractions 2017-07-03 03:14:41 +02:00
Benjamin Neff
4244f2a5df
Make Participation entity non-relayable
Related to diaspora/diaspora_federation#35
2017-07-03 03:14:41 +02:00
Benjamin Neff
07e9bf8be8
Remove old unused salmon method 2017-07-03 03:14:40 +02:00
Benjamin Neff
246d1ebbdf
Remove legacy post xml
This was used for the old post fetching

Related to diaspora/diaspora_federation#31
2017-07-03 03:14:40 +02:00
Benjamin Neff
a6d7dbf1dd
Send MagicEnvelope as body with correct Content-Type in specs
Related to diaspora/diaspora_federation#30
2017-07-03 03:14:40 +02:00