- This action needn't be performed when all notifications are read,
hence disabling it is a good practice
- Added a link-disabled-color
- Used css pointer-events to disable clicking on the link
Preventing default on click for the mark_all_read_link
- avoiding the use of pointer-events
- setting up disabled only for mark_all_read_link
Moved disabling of the link to a global handler
- Added disabled class to the button in /notifications when all are read
- Styled the disabled button
- Adding disabled class after completion of ajaxRequest
- Earlier, triple-clicking or drag & select had to be performed to select
- Should consider a copy button
Moving away from the inline onClick handler
It didn't feel right to be writing js in a helper.
Refactoring setupInviteLinks into a sidebar Backbone View
* initial backbone port
* changed AspectMembershipsController#destroy to use aspect_membership_id
* included rudimentary jasmine specs
* more specs, updating the list elements after de-/selection
* update selected aspect count on button
* don't even try to render html in AspectMembershipsController
* more specs for button summary text
* adapt aspect management on contacts page and in the popup boxes
* adapt inline creation of aspects + memberships
TODO
* more tests
* added a presenter for hovercard json
* added new backbone view for handling hovercard JS
* refactoring of PeopleController
* finished the backbone js version of hovercards
* don't try to make people_controller more restfull, out of scope
just add a new route and use that for hovercard json
* added spec for people_controller#hovercard
* add new exception for "AccountClosed" to be able to raise from anywhere
* removed legacy code, since everything got ported to backbone
(except the "cache" stuff, but that's not strictly necessary)
193 specs | 5 failing
The 5 failing specs appear (according to Firebug) to be due to missing
fixtures and/or missing routes in the Jasmine environment. Fixing these
last 5 failures is a task probably best left to a more experienced
Javascript/Jasmine developer.
This commit also moves validation.js and clear-form.js into
app/assets/javascripts and precompiles validation.js
* Move all Diaspora-specific javascripts to app/assets/javascripts
* Move all vendored javascripts to vendor/assets/javascripts
* Add the appropriate Sprockets require directives to make sure
everything gets included in the right order
* Remove Jammit dependencies
* Fix all templates that were using Jammit's include_javascripts helper
* Add handlebars_assets gem for compiling Handlebars templates
* Move all Handlebars templates to app/assets/templates and rename
from .handlebars to .jst.hbs (this is to keep them in the same
global JST namespace that they were in under Jammit)
* Add public/assets to .gitignore since these files can and should
be re-generated by Heroku or Capistrano during each deploy
* Fix a few Handlebars templates that were looking for images in the
wrong location (I'm sure there are others, but it's late)
* Configure application.rb to precompile all javascript and css assets
that were compiled by Jammit in the Rails 3.0 code
2012-03-27 18:07:44 -07:00
Renamed from public/javascripts/app/app.js (Browse further)
