79a79d65d6
* Dropped all references to Resque * Moved all jobs under app/workers since that's the Sidekiq convention * Renamed Jobs module to Worker to match new location * Adapted all jobs to Sidekiq * Replaced all enqueue calls with perform_async * Dropped Resque hacks from specs and features, replaced with sidekig/testing in RSpec and sidekig/testing/inline in Cucumber * Updated scripts to start a Sidekiq server * Inline Sidekiq sinatra app * Let Sidekiq create the actual Redis instance * Workaround already initialized constant warnings in service models * Resolved ToDo in one job definition by creating proper exception clases for some errors in receiving posts * Added sidekiq section to configuration to make it completly configurable to the user * Add Sidekiq middleware for clean backtraces * Delay HttpMulti retry to give offline pods a chance to come back up * Do not retry on GUID already taken and alike errors * Be graceful about deleted posts in GatherOEmbedData
69 lines
2.5 KiB
Ruby
69 lines
2.5 KiB
Ruby
require 'spec_helper'
|
|
describe Workers::GatherOEmbedData do
|
|
before do
|
|
@flickr_oembed_data = {
|
|
"trusted_endpoint_url" => "__!SPOOFED!__",
|
|
"version" => "1.0",
|
|
"type" => "photo",
|
|
"author_url" => "http://www.flickr.com/photos/bees/",
|
|
"cache_age" => 3600,
|
|
"provider_name" => "Flickr",
|
|
"provider_url" => "http://www.flickr.com/",
|
|
"title" => "ZB8T0193",
|
|
"author_name" => "Bees",
|
|
"width" => "240",
|
|
"height" => "160",
|
|
"url" => "https://farm4.static.flickr.com/3123/2341623661_7c99f48bbf_m.jpg"
|
|
}
|
|
|
|
@flickr_oembed_url = 'http://www.flickr.com/services/oembed/'
|
|
@flickr_photo_url = 'http://www.flickr.com/photos/bees/2341623661'
|
|
@flickr_oembed_get_request = @flickr_oembed_url+"?format=json&frame=1&iframe=1&maxheight=420&maxwidth=420&url="+@flickr_photo_url
|
|
|
|
@no_oembed_url = 'http://www.we-do-not-support-oembed.com/index.html'
|
|
|
|
@status_message = FactoryGirl.create(:status_message)
|
|
|
|
stub_request(:get, @flickr_oembed_get_request).to_return(:status => 200, :body => @flickr_oembed_data.to_json)
|
|
stub_request(:get, @no_oembed_url).to_return(:status => 200, :body => '<html><body>hello there</body></html>')
|
|
end
|
|
|
|
describe '.perform' do
|
|
it 'requests not data from the internet' do
|
|
Workers::GatherOEmbedData.new.perform(@status_message.id, @flickr_photo_url)
|
|
|
|
a_request(:get, @flickr_oembed_get_request).should have_been_made
|
|
end
|
|
|
|
it 'requests not data from the internet only once' do
|
|
2.times do |n|
|
|
Workers::GatherOEmbedData.new.perform(@status_message.id, @flickr_photo_url)
|
|
end
|
|
|
|
a_request(:get, @flickr_oembed_get_request).should have_been_made.times(1)
|
|
end
|
|
|
|
it 'creates one cache entry' do
|
|
Workers::GatherOEmbedData.new.perform(@status_message.id, @flickr_photo_url)
|
|
|
|
expected_data = @flickr_oembed_data
|
|
expected_data['trusted_endpoint_url'] = @flickr_oembed_url
|
|
OEmbedCache.find_by_url(@flickr_photo_url).data.should == expected_data
|
|
|
|
Workers::GatherOEmbedData.new.perform(@status_message.id, @flickr_photo_url)
|
|
OEmbedCache.count(:conditions => {:url => @flickr_photo_url}).should == 1
|
|
end
|
|
|
|
it 'creates no cache entry for unsupported pages' do
|
|
Workers::GatherOEmbedData.new.perform(@status_message.id, @no_oembed_url)
|
|
|
|
OEmbedCache.find_by_url(@no_oembed_url).should be_nil
|
|
end
|
|
|
|
it 'gracefully handles a deleted post' do
|
|
expect {
|
|
Workers::GatherOEmbedData.new.perform(0, @flickr_photo_url)
|
|
}.to_not raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
end
|
|
end
|