260 lines
9.7 KiB
Ruby
260 lines
9.7 KiB
Ruby
# Copyright (c) 2010, Diaspora Inc. This file is
|
|
# licensed under the Affero General Public License version 3 or later. See
|
|
# the COPYRIGHT file.
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Comment do
|
|
let(:user) {Factory.create(:user)}
|
|
let(:aspect) {user.aspects.create(:name => "Doofuses")}
|
|
|
|
let(:user2) {Factory.create(:user)}
|
|
let(:aspect2) {user2.aspects.create(:name => "Lame-faces")}
|
|
|
|
let!(:connecting) { connect_users(user, aspect, user2, aspect2) }
|
|
|
|
describe '.hash_from_post_ids' do
|
|
before do
|
|
@hello = user.post(:status_message, :message => "Hello.", :to => aspect.id)
|
|
@hi = user.post(:status_message, :message => "hi", :to => aspect.id)
|
|
@lonely = user.post(:status_message, :message => "Hello?", :to => aspect.id)
|
|
|
|
@c11 = user2.comment "why so formal?", :on => @hello
|
|
@c21 = user2.comment "lol hihihi", :on => @hi
|
|
@c12 = user.comment "I simply felt like issuing a greeting. Do step off.", :on => @hello
|
|
@c22 = user.comment "stfu noob", :on => @hi
|
|
|
|
@c12.created_at = Time.now+10
|
|
@c12.save!
|
|
@c22.created_at = Time.now+10
|
|
@c22.save!
|
|
end
|
|
it 'returns an empty array for posts with no comments' do
|
|
Comment.hash_from_post_ids([@lonely.id]).should ==
|
|
{@lonely.id => []}
|
|
end
|
|
it 'returns a hash from posts to comments' do
|
|
Comment.hash_from_post_ids([@hello.id, @hi.id]).should ==
|
|
{@hello.id => [@c11, @c12],
|
|
@hi.id => [@c21, @c22]
|
|
}
|
|
end
|
|
it 'gets the people from the db' do
|
|
hash = Comment.hash_from_post_ids([@hello.id, @hi.id])
|
|
Person.from_post_comment_hash(hash).should == {
|
|
user.person.id => user.person,
|
|
user2.person.id => user2.person,
|
|
}
|
|
end
|
|
end
|
|
|
|
describe 'comment#notification_type' do
|
|
before do
|
|
@not_your_post = user2.post(:status_message, :message => 'yo', :to => aspect2.id)
|
|
@hello = user.post(:status_message, :message => "hello", :to => aspect.id)
|
|
@c11 = user2.comment "why so formal?", :on => @hello
|
|
@c12 = user.comment "I simply felt like issuing a greeting. Do step off.", :on => @hello
|
|
@c12 = user2.comment "I simply felt like issuing a greeting. Do step off.", :on => @not_your_post
|
|
|
|
end
|
|
|
|
it "returns 'comment_on_post' if the comment is on a post you own" do
|
|
@c11.notification_type(user, user2.person).should == 'comment_on_post'
|
|
|
|
end
|
|
|
|
it 'returns false if the comment is not on a post you own' do
|
|
@c11.notification_type(user2, user.person).should == false
|
|
end
|
|
end
|
|
|
|
|
|
|
|
|
|
|
|
describe 'User#comment' do
|
|
before do
|
|
@status = user.post(:status_message, :message => "hello", :to => aspect.id)
|
|
end
|
|
|
|
it "should be able to comment on his own status" do
|
|
@status.comments.should == []
|
|
|
|
user.comment "Yeah, it was great", :on => @status
|
|
@status.reload.comments.first.text.should == "Yeah, it was great"
|
|
end
|
|
|
|
it "should be able to comment on a person's status" do
|
|
user2.comment "sup dog", :on => @status
|
|
@status.reload.comments.first.text.should == "sup dog"
|
|
end
|
|
end
|
|
|
|
it 'should not send out comments when we have no people' do
|
|
status = Factory.create(:status_message, :person => user.person)
|
|
MessageHandler.should_not_receive(:add_post_request)
|
|
user.comment "sup dog", :on => status
|
|
end
|
|
|
|
describe 'comment propagation' do
|
|
before do
|
|
@person = Factory.create(:person)
|
|
user.activate_contact(@person, aspect)
|
|
|
|
@person2 = Factory.create(:person)
|
|
@person_status = Factory.build(:status_message, :person => @person)
|
|
|
|
user.reload
|
|
@user_status = user.post :status_message, :message => "hi", :to => aspect.id
|
|
|
|
aspect.reload
|
|
user.reload
|
|
end
|
|
|
|
|
|
it "should send a user's comment on a person's post to that person" do
|
|
MessageHandler.should_receive(:add_post_request).once
|
|
user.comment "yo", :on => @person_status
|
|
end
|
|
|
|
it 'should send a user comment on his own post to lots of people' do
|
|
MessageHandler.should_receive(:add_post_request).once
|
|
|
|
user2.raw_visible_posts.count.should == 0
|
|
|
|
user.comment "yo", :on => @user_status
|
|
|
|
user2.reload
|
|
user2.raw_visible_posts.count.should == 1
|
|
end
|
|
|
|
it 'should send a comment a person made on your post to all people' do
|
|
comment = Comment.new(:person_id => @person.id, :diaspora_handle => @person.diaspora_handle, :text => "cats", :post => @user_status)
|
|
MessageHandler.should_receive(:add_post_request).once
|
|
user.receive comment.to_diaspora_xml, @person
|
|
end
|
|
|
|
it 'should send a comment a user made on your post to all people' do
|
|
comment = user2.comment( "balls", :on => @user_status)
|
|
MessageHandler.should_receive(:add_post_request).once
|
|
user.receive comment.to_diaspora_xml, user2.person
|
|
end
|
|
|
|
context 'posts from a remote person' do
|
|
before(:all) do
|
|
stub_comment_signature_verification
|
|
end
|
|
|
|
it 'should not send a comment a person made on his own post to anyone' do
|
|
MessageHandler.should_not_receive(:add_post_request)
|
|
comment = Comment.new(:person_id => @person.id, :diaspora_handle => @person.diaspora_handle, :text => "cats", :post => @person_status)
|
|
user.receive comment.to_diaspora_xml, @person
|
|
end
|
|
|
|
it 'should not send a comment a person made on a person post to anyone' do
|
|
MessageHandler.should_not_receive(:add_post_request)
|
|
comment = Comment.new(:person_id => @person2.id, :diaspora_handle => @person.diaspora_handle, :text => "cats", :post => @person_status)
|
|
user.receive comment.to_diaspora_xml, @person
|
|
end
|
|
|
|
after(:all) do
|
|
unstub_mocha_stubs
|
|
end
|
|
end
|
|
|
|
it 'should not clear the aspect post array on receiving a comment' do
|
|
aspect.post_ids.include?(@user_status.id).should be true
|
|
comment = Comment.new(:person_id => @person.id, :diaspora_handle => @person.diaspora_handle, :text => "cats", :post => @user_status)
|
|
|
|
user.receive comment.to_diaspora_xml, @person
|
|
|
|
aspect.reload
|
|
aspect.post_ids.include?(@user_status.id).should be true
|
|
end
|
|
end
|
|
describe 'serialization' do
|
|
it 'should serialize the handle and not the sender' do
|
|
commenter = Factory.create(:user)
|
|
commenter_aspect = commenter.aspects.create(:name => "bruisers")
|
|
connect_users(user, aspect, commenter, commenter_aspect)
|
|
post = user.post :status_message, :message => "hello", :to => aspect.id
|
|
comment = commenter.comment "Fool!", :on => post
|
|
comment.person.should_not == user.person
|
|
xml = comment.to_diaspora_xml
|
|
xml.include?(commenter.person.id.to_s).should be false
|
|
xml.include?(commenter.diaspora_handle).should be true
|
|
end
|
|
end
|
|
describe 'local commenting' do
|
|
before do
|
|
@status = user.post(:status_message, :message => "hello", :to => aspect.id)
|
|
end
|
|
it 'does not multi-post a comment' do
|
|
lambda {
|
|
user.comment 'hello', :on => @status
|
|
}.should change{Comment.count}.by(1)
|
|
end
|
|
end
|
|
describe 'comments' do
|
|
before do
|
|
@remote_message = user2.post :status_message, :message => "hello", :to => aspect2.id
|
|
@message = user.post :status_message, :message => "hi", :to => aspect.id
|
|
end
|
|
|
|
it 'should attach the creator signature if the user is commenting' do
|
|
user.comment "Yeah, it was great", :on => @remote_message
|
|
@remote_message.comments.first.signature_valid?.should be true
|
|
end
|
|
|
|
it 'should sign the comment if the user is the post creator' do
|
|
message = user.post :status_message, :message => "hi", :to => aspect.id
|
|
user.comment "Yeah, it was great", :on => message
|
|
message.comments.first.signature_valid?.should be true
|
|
message.comments.first.verify_post_creator_signature.should be true
|
|
end
|
|
|
|
it 'should verify a comment made on a remote post by a different contact' do
|
|
comment = Comment.new(:person => user2.person, :text => "cats", :post => @remote_message)
|
|
comment.creator_signature = comment.send(:sign_with_key,user2.encryption_key)
|
|
comment.signature_valid?.should be true
|
|
comment.verify_post_creator_signature.should be false
|
|
comment.post_creator_signature = comment.send(:sign_with_key,user.encryption_key)
|
|
comment.verify_post_creator_signature.should be true
|
|
end
|
|
|
|
it 'should reject comments on a remote post with only a creator sig' do
|
|
comment = Comment.new(:person => user2.person, :text => "cats", :post => @remote_message)
|
|
comment.creator_signature = comment.send(:sign_with_key,user2.encryption_key)
|
|
comment.signature_valid?.should be true
|
|
comment.verify_post_creator_signature.should be false
|
|
end
|
|
|
|
it 'should receive remote comments on a user post with a creator sig' do
|
|
comment = Comment.new(:person => user2.person, :text => "cats", :post => @message)
|
|
comment.creator_signature = comment.send(:sign_with_key,user2.encryption_key)
|
|
comment.signature_valid?.should be true
|
|
comment.verify_post_creator_signature.should be false
|
|
end
|
|
end
|
|
|
|
describe 'youtube' do
|
|
before do
|
|
@message = user.post :status_message, :message => "hi", :to => aspect.id
|
|
end
|
|
it 'should process youtube titles on the way in' do
|
|
video_id = "ABYnqp-bxvg"
|
|
url="http://www.youtube.com/watch?v=#{video_id}&a=GxdCwVVULXdvEBKmx_f5ywvZ0zZHHHDU&list=ML&playnext=1"
|
|
expected_title = "UP & down & UP & down &"
|
|
|
|
mock_http = mock("http")
|
|
Net::HTTP.stub!(:new).with('gdata.youtube.com', 80).and_return(mock_http)
|
|
mock_http.should_receive(:get).with('/feeds/api/videos/'+video_id+'?v=2', nil).and_return(
|
|
[nil, 'Foobar <title>'+expected_title+'</title> hallo welt <asd><dasdd><a>dsd</a>'])
|
|
|
|
comment = user.build_comment url, :on => @message
|
|
|
|
comment.save!
|
|
comment[:youtube_titles].should == {video_id => expected_title}
|
|
end
|
|
end
|
|
end
|