From 4295237e9e6e8e0ff23a5d8d732654b865f44944 Mon Sep 17 00:00:00 2001 From: Benjamin Neff Date: Sun, 21 Aug 2016 21:08:33 +0200 Subject: [PATCH] Raise ValidationError if properties are missing --- lib/diaspora_federation/entity.rb | 2 +- spec/lib/diaspora_federation/entity_spec.rb | 2 +- spec/support/shared_entity_specs.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/diaspora_federation/entity.rb b/lib/diaspora_federation/entity.rb index 8743c77..690f9fe 100644 --- a/lib/diaspora_federation/entity.rb +++ b/lib/diaspora_federation/entity.rb @@ -153,7 +153,7 @@ module DiasporaFederation def validate_missing_props(entity_data) missing_props = self.class.missing_props(entity_data) - raise ArgumentError, "missing required properties: #{missing_props.join(', ')}" unless missing_props.empty? + raise ValidationError, "missing required properties: #{missing_props.join(', ')}" unless missing_props.empty? end def setable?(name, val) diff --git a/spec/lib/diaspora_federation/entity_spec.rb b/spec/lib/diaspora_federation/entity_spec.rb index 99bb476..8d0c6ba 100644 --- a/spec/lib/diaspora_federation/entity_spec.rb +++ b/spec/lib/diaspora_federation/entity_spec.rb @@ -15,7 +15,7 @@ module DiasporaFederation it "checks for required properties" do expect { Entities::TestDefaultEntity.new({}) - }.to raise_error ArgumentError, "missing required properties: test1, test2" + }.to raise_error Entity::ValidationError, "missing required properties: test1, test2" end context "defaults" do diff --git a/spec/support/shared_entity_specs.rb b/spec/support/shared_entity_specs.rb index 35dbaf9..d88edfc 100644 --- a/spec/support/shared_entity_specs.rb +++ b/spec/support/shared_entity_specs.rb @@ -12,7 +12,7 @@ shared_examples "an Entity subclass" do describe "initialize" do it "must not create blank instances" do - expect { described_class.new({}) }.to raise_error ArgumentError + expect { described_class.new({}) }.to raise_error DiasporaFederation::Entity::ValidationError end it "fails if nil was given" do