From 965babbfeed5be989eec6d393af789de5200f6e6 Mon Sep 17 00:00:00 2001 From: Benjamin Neff Date: Sun, 6 Dec 2015 23:45:10 +0100 Subject: [PATCH] mark RelayableRetraction and SignedRetraction as deprecated The normal Rectraction can be used for this: * RelayableRetraction: Both the author and the parent author can retract a relayable, so there is no need to check if it was relayed. * SignedRetraction: this is already signed at the salmon-level. No need to add an additional signature at this level. Only used for StatusMessage. --- lib/diaspora_federation/entities/relayable_retraction.rb | 1 + lib/diaspora_federation/entities/signed_retraction.rb | 1 + .../validators/relayable_retraction_validator.rb | 1 + .../validators/signed_retraction_validator.rb | 1 + 4 files changed, 4 insertions(+) diff --git a/lib/diaspora_federation/entities/relayable_retraction.rb b/lib/diaspora_federation/entities/relayable_retraction.rb index 222d86d..bfd4a9b 100644 --- a/lib/diaspora_federation/entities/relayable_retraction.rb +++ b/lib/diaspora_federation/entities/relayable_retraction.rb @@ -17,6 +17,7 @@ module DiasporaFederation # is not checked, only parent_author_signature is checked. # # @see Validators::RelayableRetractionValidator + # @deprecated will be replaced with {Entities::Retraction} class RelayableRetraction < Entity # @!attribute [r] parent_author_signature # Contains a signature of the entity using the private key of the author of a parent post diff --git a/lib/diaspora_federation/entities/signed_retraction.rb b/lib/diaspora_federation/entities/signed_retraction.rb index 111a429..49bb241 100644 --- a/lib/diaspora_federation/entities/signed_retraction.rb +++ b/lib/diaspora_federation/entities/signed_retraction.rb @@ -4,6 +4,7 @@ module DiasporaFederation # entity of post type ({Entities::StatusMessage}) # # @see Validators::SignedRetractionValidator + # @deprecated will be replaced with {Entities::Retraction} class SignedRetraction < Entity # @!attribute [r] target_guid # guid of a post to be deleted diff --git a/lib/diaspora_federation/validators/relayable_retraction_validator.rb b/lib/diaspora_federation/validators/relayable_retraction_validator.rb index 4b647af..e529f47 100644 --- a/lib/diaspora_federation/validators/relayable_retraction_validator.rb +++ b/lib/diaspora_federation/validators/relayable_retraction_validator.rb @@ -1,6 +1,7 @@ module DiasporaFederation module Validators # This validates a {Entities::RelayableRetraction} + # @deprecated the {Entities::RelayableRetraction} will be replaced with {Entities::Retraction} class RelayableRetractionValidator < Validation::Validator include Validation diff --git a/lib/diaspora_federation/validators/signed_retraction_validator.rb b/lib/diaspora_federation/validators/signed_retraction_validator.rb index d8442b5..176471e 100644 --- a/lib/diaspora_federation/validators/signed_retraction_validator.rb +++ b/lib/diaspora_federation/validators/signed_retraction_validator.rb @@ -1,6 +1,7 @@ module DiasporaFederation module Validators # This validates a {Entities::SignedRetraction} + # @deprecated the {Entities::RelayableRetraction} will be replaced with {Entities::Retraction} class SignedRetractionValidator < Validation::Validator include Validation