fix factories with spring

.rubocop.yml

@@ -13,6 +13,8 @@ Metrics/LineLength:
 # the code easier to read (by naming things), but can also clutter the class
 Metrics/MethodLength:
   Max: 20
+  Exclude:
+    - "lib/diaspora_federation/test/factories.rb"
 
 # The guiding principle of classes is SRP, SRP can't be accurately measured by LoC
 Metrics/ClassLength:
@@ -152,6 +154,8 @@ Metrics/PerceivedComplexity:
   Max: 10
 Metrics/AbcSize:
   Max: 20
+  Exclude:
+    - "lib/diaspora_federation/test/factories.rb"
 
 Metrics/ModuleLength:
   Max: 1500

lib/diaspora_federation/test/factories.rb

@@ -1,7 +1,11 @@
 require "diaspora_federation"
 require "factory_girl"
 
-FactoryGirl.define do
+module DiasporaFederation
+  module Test
+    module Factories
+      def self.federation_factories
+        FactoryGirl.define do
           initialize_with { new(attributes) }
           sequence(:guid) { UUID.generate :compact }
           sequence(:diaspora_id) {|n| "person-#{n}-#{SecureRandom.hex(3)}@localhost:3000" }
@@ -82,7 +86,8 @@ FactoryGirl.define do
             parent_guid { generate(:guid) }
           end
 
-  factory :participation_entity, class: DiasporaFederation::Entities::Participation, parent: :relayable_entity do
+          factory :participation_entity,
+                  class: DiasporaFederation::Entities::Participation, parent: :relayable_entity do
             guid
             target_type "Post"
             diaspora_id
@@ -175,10 +180,13 @@ FactoryGirl.define do
           end
 
           factory :poll_participation_entity,
-          class:  DiasporaFederation::Entities::PollParticipation,
+                  class:  DiasporaFederation::Entities::PollParticipation, parent: :relayable_entity do
-          parent: :relayable_entity do
             guid
             diaspora_id
             poll_answer_guid { generate(:guid) }
           end
+        end
+      end
+    end
+  end
 end

spec/factories.rb

@@ -1,3 +1,7 @@
+require "diaspora_federation/test"
+
+DiasporaFederation::Test::Factories.federation_factories
+
 FactoryGirl.define do
   factory :person do
     diaspora_id

spec/spec_helper.rb

@@ -22,7 +22,6 @@ require "rspec/rails"
 require "webmock/rspec"
 
 # load factory girl factories
-require "diaspora_federation/test"
 require "factories"
 
 # load test entities