Commit graph

226 commits

Author SHA1 Message Date
Benjamin Neff
41de99bd5e don't include signatures in xml_order on receive 2016-07-25 01:29:51 +02:00
Benjamin Neff
ba129aafa3 add missing properties from xml_order to xml 2016-07-23 00:29:44 +02:00
Benjamin Neff
36a787dd87 convert string in xml_order to symbol if needed 2016-07-23 00:12:22 +02:00
Benjamin Neff
c0e798c55e update string blocks for new rubocop 2016-07-14 01:21:40 +02:00
Benjamin Neff
90970973a5 gracefully handle missing xml elements of relayables
parent-fetching failed, if the xml didn't contain the information needed
for it.

fixes NameError: uninitialized constant DiasporaFederation::Entities::Like::PARENT_TYPE
2016-07-12 22:18:14 +02:00
Benjamin Neff
2aaff56e14 rename StatusMessage#raw_message to #text
see #29
2016-07-12 03:14:15 +02:00
Benjamin Neff
4b949491df nickname is optional in the hCard 2016-07-12 03:13:40 +02:00
Benjamin Neff
f7d269cd6a a guid is at most 255 chars long. 2016-07-12 03:13:40 +02:00
Benjamin Neff
0980294a0d Validate Conversation subject
also reordered fields of Conversation
2016-07-12 03:13:39 +02:00
Benjamin Neff
eb8cdef604 validate Photo text length 2016-07-12 03:04:09 +02:00
Benjamin Neff
9b3231583d validate StatusMessage raw_message length 2016-07-12 03:04:09 +02:00
Benjamin Neff
26b7991def handle empty xml-elements for nested entities 2016-07-12 03:04:09 +02:00
Steffen van Bergerem
e0ab18c0ea
Improve code documentation 2016-07-12 02:08:21 +02:00
Benjamin Neff
699c74a8f0 validate message text 2016-07-01 05:06:02 +02:00
Benjamin Neff
9b090a3950 fetch root posts for reshares 2016-06-26 21:22:01 +02:00
Benjamin Neff
e001d14b8f profile_url and atom_url are optional in webfinger 2016-06-25 00:12:37 +02:00
Benjamin Neff
da79b72d62 don't parse url from hcard
this is deprecated anyway and is not used anywhere, so we don't need to parse it.
2016-06-22 02:56:22 +02:00
Benjamin Neff
491419c99a refactor signature verification for relayables 2016-06-21 05:19:49 +02:00
Benjamin Neff
4b0e77b25a add more info to errors for better logging 2016-06-21 04:56:41 +02:00
Benjamin Neff
117ee79c8c validate that Participation parent exists and parent-author is local 2016-06-21 02:39:13 +02:00
Benjamin Neff
d054d42b86 use .to_h instead of Hash[] 2016-06-20 03:59:23 +02:00
Benjamin Neff
f243082def only allow photos from the same author to be nested in status message 2016-06-17 18:34:27 +02:00
Benjamin Neff
4d7c7422c3 only allow messages from the same author to be nested in conversation 2016-06-17 18:28:42 +02:00
Benjamin Neff
c62bede41c message not relayable anymore
receive only from author and ignore signature checking, or from parent
author with valid signature.

see #36
2016-06-17 18:16:40 +02:00
Benjamin Neff
7f869a5cdf participation not relayable anymore
receive only from author and no signature checking

see #35
2016-06-17 17:52:58 +02:00
Benjamin Neff
77c3165c51 set parent_author_signature on RelayableRetraction if author is parent author
the target_author_signature is only checked, if the parent author
receives it. so the parent_author_signature is the important signature.
2016-06-05 16:17:05 +02:00
Benjamin Neff
4bde03e2de use RelatedEntity as normal nested entity, but don't add it to xml 2016-06-05 04:13:55 +02:00
Benjamin Neff
e5203182bf replace invalid characters from xml 2016-05-31 04:25:43 +02:00
Benjamin Neff
653b0fe276 instantiate nested entities if they are provided as hash
also add debug logging to entity constructor
2016-05-30 03:23:57 +02:00
Benjamin Neff
4ded6da139 Entity#to_h returns nested entities as hash 2016-05-30 03:22:07 +02:00
Benjamin Neff
38922d5f30 add string representation to entities for better and easier logging 2016-05-15 00:11:04 +02:00
Benjamin Neff
58b22df9c5 convert entity name to needed format for fetching 2016-05-14 17:56:34 +02:00
Benjamin Neff
458265b78f fix rubocop offenses for rubocop 0.40.0 2016-05-11 02:22:48 +02:00
Dennis Schubert
594529fc15 Optimize test description...
[ci skip]
2016-05-10 00:30:01 +02:00
Benjamin Neff
2ffc7e3814 add re-raise specs for receiver 2016-05-08 22:37:26 +02:00
Benjamin Neff
a0f39b4f3a Revert "add ParentNotFound error, if parent can't be fetched"
This reverts commit 5a9ba266b4.

There is already a NotFetchable error ...
2016-05-07 12:44:58 +02:00
Benjamin Neff
5a9ba266b4 add ParentNotFound error, if parent can't be fetched 2016-05-07 03:12:33 +02:00
Benjamin Neff
c9d0b978d4 add validators for empty arrays 2016-04-29 03:59:24 +02:00
Benjamin Neff
28ab54abef use default values after parse xml 2016-04-29 02:59:09 +02:00
Benjamin Neff
8aa353a438 add validator for poll_answers 2016-04-29 01:32:49 +02:00
Benjamin Neff
53ba96acca simplify diaspora ID regex
hostname doesn't allow underscores, fixes #33
2016-04-23 23:48:03 +02:00
Benjamin Neff
0c4307a4de better logging for receiving 2016-04-03 03:34:53 +02:00
Benjamin Neff
a8af94f192 validates entity on receive if it can be public but is not 2016-04-03 00:01:50 +02:00
Benjamin Neff
c8be9083f0 move sender_valid? logic to Retraction and Relayable 2016-04-02 22:14:38 +02:00
Benjamin Neff
05cd90f073 validate sender for retraction and relayable 2016-04-01 03:51:24 +02:00
Benjamin Neff
c7c2957b07 fetch from remote if parent unknown locally 2016-03-31 04:33:52 +02:00
Benjamin Neff
6ef1545fd0 cleanup parent_type for relayables 2016-03-29 03:45:32 +02:00
Benjamin Neff
aac2a1652e create expect_callback() spec-helper 2016-03-29 03:14:01 +02:00
Benjamin Neff
1d4d3d732d use shorter callback keys for key-callbacks 2016-03-29 02:42:19 +02:00
Benjamin Neff
2db0931ce5 write more tests for retractions 2016-03-29 02:30:43 +02:00