Benjamin Neff
32a49cc549
Get optional props from validated object
...
This is much easier and safer than "guessing" the class name based on
the validator name. That can cause a problem when another class with the
same name is found. The "guessing" was only added because we used
OpenStruct in the tests, but we shouldn't change the code only to make
tests run. I changed the tests to use the real entities, with
auto-validation disabled in the constructor, so we can test the
validator manually.
2018-02-14 01:37:20 +01:00
Benjamin Neff
e663a65c7e
Remove not_nil for diaspora IDs from validators
...
The diaspora ID validator now is not nil by default.
Also:
* mark root_author as optional for reshares.
* make author for profiles mandatory (I don't remember why this was
optional, we never generate a profile without author and we wouldn't
receive a profile without author anyway, because we validate that the
author is the sender).
* refactor validator specs for diaspora IDs
2017-09-12 23:11:05 +02:00
cmrd Senya
5b12afebed
Allow reshares with no root
2017-08-25 10:33:16 +03:00
Benjamin Neff
e6e9893c1f
Make rspec work without rails dependency
2017-04-05 02:02:04 +02:00
Benjamin Neff
184954e09c
Replace factory_girl with fabrication
...
factory_girl has activesupport as dependency
2017-04-04 22:14:13 +02:00
Steffen van Bergerem
e0ab18c0ea
Improve code documentation
2016-07-12 02:08:21 +02:00
Benjamin Neff
c9d0b978d4
add validators for empty arrays
2016-04-29 03:59:24 +02:00
Benjamin Neff
23fc8dc180
use related entity as parent for relayables
2016-03-28 17:46:37 +02:00
Benjamin Neff
5ebda543a1
change diaspora_id to author
...
see #29
2016-02-10 03:17:10 +01:00
Benjamin Neff
583d567d67
bump rubocop and pronto-rubocop
...
make some refactorings for new cops
2016-01-19 01:32:22 +01:00
cmrd Senya
b9b5ee6f7d
Do the same generalization for Relayable for validators taking
...
into account that "author_signature" and "parent_author_signature"
are allowed to be empty, actually.
2015-11-13 17:44:45 +03:00
cmrd Senya
f12a4c21db
Merge all the entities left from the @Raven24's gem.
...
These are: AccountDeletion, Comment, Conversation, Like, Message,
RelayableRetraction, Reshare, Retraction, SignedRetraction
2015-11-06 01:50:04 +03:00
cmrd Senya
761534f13c
DRY specs more by introducing "a property with data-types restriction" shared behavior
2015-11-05 17:27:31 +03:00
cmrd Senya
9391d4b9eb
Reduce the entity stubs initialization calls to a single entity_stub
...
to make the code more DRY
2015-11-03 01:23:10 +03:00
cmrd Senya
9cb6fe4d1b
Some more code merged from the @Raven24's gem. The code is
...
related to the request, status_message, participation, photo and
location entities, its validators and tests for all of the things.
2015-11-03 00:39:30 +03:00
Benjamin Neff
8c63655886
allow nil for diaspora_id in profile
...
refactor some tests
2015-08-06 02:21:49 +02:00
Benjamin Neff
c15fee279c
extend profile validator
2015-07-28 02:06:46 +02:00
Benjamin Neff
c1e700d560
add own URI validation rule that allows nil
2015-07-27 03:47:56 +02:00
Benjamin Neff
d7a5e71ce6
refactor shared examples and use more of them
2015-07-27 01:38:11 +02:00
Benjamin Neff
0deb74c103
refactor: rename diaspora_handle to diaspora_id
...
diaspora uses the new wording "diaspora ID" instead of "diaspora handle"
2015-07-23 01:22:23 +02:00
Benjamin Neff
2301b1433e
add validators from raven24
2015-07-20 03:43:54 +02:00
