Merge pull request #4847 from hincupetru/3692-hashtags-inside-markdown-link

Solved problem with hashtags inside markdown links

Changelog.md

@@ -24,6 +24,7 @@
 * Fixed Atom Feed Error if reshared Post is deleted [#4638] (https://github.com/diaspora/diaspora/issues/4638)
 * Show hovercards in the notification drop-down for users on the same pod [#4843](https://github.com/diaspora/diaspora/pull/4843)
 * The photo stream no longer repeats after the last photo [#4726](https://github.com/diaspora/diaspora/issues/4726)
+* Stop parsing hashtags inside markdown links [#3692](https://github.com/diaspora/diaspora/issues/3692)
 
 ## Features
 * You can report a single post by clicking the correct icon in the controler section [#4517](https://github.com/diaspora/diaspora/pull/4517)

app/assets/javascripts/app/helpers/text_formatter.js

@@ -108,11 +108,16 @@ $(function() {
   };
 
   textFormatter.hashtagify = function hashtagify(text){
-    var utf8WordCharcters =/(\s|^|>)#([\u0080-\uFFFF|\w|-]+|<3)/g
-    return text.replace(utf8WordCharcters, function(hashtag, preceeder, tagText) {
-      return preceeder + "<a href='/tags/" + tagText.toLowerCase() +
-                         "' class='tag'>#" + tagText + "</a>"
-    })
+    var utf8WordCharcters =/(\s|^|>)#([\u0080-\uFFFF|\w|-]+|&lt;3)/g;
+    var linkRegex = /<a[^>]*>(.*?)<\/a>/g;
+
+    if(text.match(linkRegex))
+      return text;
+    else 
+      return text.replace(utf8WordCharcters, function(hashtag, preceeder, tagText) {
+        return preceeder + "<a href='/tags/" + tagText.toLowerCase() +
+                           "' class='tag'>#" + tagText + "</a>"
+      });
   };
 
   textFormatter.mentionify = function mentionify(text, mentions) {

spec/javascripts/app/helpers/text_formatter_spec.js

@@ -238,6 +238,13 @@ describe("app.helpers.textFormatter", function(){
 
         expect(formattedText).toContain("/tags/parties")
       })
+
+      it("doesn't create tag if the text is a link", function(){
+        var link = $('<a/>', { href: 'http://me.co' }).html('#me')[0].outerHTML;
+        var result = this.formatter.hashtagify(link);
+
+        expect(result).toEqual(link);
+      })
     })
   })