nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

in JS, avoid global variables as much as possible

Browse source
This commit is contained in:
lfortin 2011-01-02 19:24:38 -05:00
parent 22a696bcf8
commit efb711963f
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
public/javascripts/stream.js
View file

@ -51,8 +51,8 @@ var Stream = {
// reshare button action
$stream.delegate(".reshare_button", "click", function(evt) {
evt.preventDefault();
button = $(this)
box = button.siblings(".reshare_box");
var button = $(this);
var box = button.siblings(".reshare_box");
if (box.length > 0) {
button.toggleClass("active");
box.toggle();

10
public/javascripts/web-socket-receiver.js
View file

@ -1,6 +1,6 @@
var WebSocketReceiver = {
initialize: function(url) {
ws = new WebSocket(url);
var ws = new WebSocket(url);
//Attach onmessage to websocket
ws.onmessage = WSR.onMessage;
@ -39,9 +39,9 @@ var WebSocketReceiver = {
},
processPerson: function(response) {
form = $('.webfinger_form');
var form = $('.webfinger_form');
form.siblings('#loader').hide();
result_ul = form.siblings('#request_result');
var result_ul = form.siblings('#request_result');
if(response.status == 'fail') {
result_ul.siblings('.error').show();
result_ul.find('.error').text(response.response).show();
@ -88,11 +88,11 @@ var WebSocketReceiver = {
if( $(".comment[data-guid='"+commentId+"']").length == 0 ) {
post = $("*[data-guid='"+postId+"']'");
var post = $("*[data-guid='"+postId+"']'");
$('.comments li:last', post ).before(
$(html).fadeIn("fast", function(){})
);
toggler = $('.show_post_comments', post);
var toggler = $('.show_post_comments', post);
if(toggler.length > 0){
toggler.html(