Benjamin Neff
c2526c6111
Don't wait for .loading class, it's sometimes already removed again
2017-08-12 15:39:27 +02:00
Benjamin Neff
62cb1f99ce
Get current time before the test to be safer on MySQL
2017-08-12 15:39:27 +02:00
Benjamin Neff
605e292589
Wait for image to be uploaded
2017-08-12 15:39:27 +02:00
Benjamin Neff
6b8c2ebe9f
Fix rubocop cop namespace for ExtraSpacing
2017-08-12 15:39:27 +02:00
Benjamin Neff
ec680962ee
Convert CreateSchema migration to real migration with up method
...
Otherwise Rails 5 would ignore the migration version and create the
tables with bitints as IDs on MySQL.
2017-08-12 15:39:27 +02:00
Dennis Schubert
50f1fd304f
Remove UTF8 to UTF8mb4 migration
...
we released that in 0.5.0.0 in 2015, we do not support skipping majors
anyway, and this is broken in Rails 5, so let's remove this. If people
upgrade from before 0.5.0.0, they have to upgrade via 0.6.0.0, but
that's written in the documenation.
2017-08-12 15:39:27 +02:00
Dennis Schubert
5b1be7d8da
Remove the schema.rb from this repo
...
Although this is contrary to rails best-practises, we cannot provide a schema.rb that works for both MySQL and PostgreSQL, so we have no choice. Our migrations are maintained, so it should always be possible to get back to a "clean" database schema anyway.
2017-08-12 15:39:26 +02:00
Dennis Schubert
ef70549832
Replace usages of the deprecated delete_all with conditions
2017-08-12 15:39:26 +02:00
Dennis Schubert
b614237504
Make all current migrations Rails 4.2 based
2017-08-12 15:39:26 +02:00
Dennis Schubert
1f272f5306
Do not touch the schema_migrations table in migrations
...
... this breaks the Rails 5 upgrade, and it's actually no longer needed.
New installations will have the right size anyway, and even if some
older installations miss the migration by not updating for 2 years, it
still doesn't matter since there is no risk that we will ever have
emojis in our migration filenames.
2017-08-12 15:39:26 +02:00
Benjamin Neff
b203862ca3
Workaround for bootstrap-sass
...
The change in assets.rb should be enough, but it doesn't work, because
sprockets `after_initialize` runs before it and initializes sprockets
with unfiltered paths.
But the trick with the underscore works, because bootstrap-sass has
named the file `_bootstrap.scss`, and rails-assets-bootstrap has
`bootstrap.scss`, so with `_bootstrap` it uses the correct bootstrap.
2017-08-12 15:39:26 +02:00
Benjamin Neff
b80d324504
Fix some failing cukes because they were too fast
2017-08-12 15:39:26 +02:00
Benjamin Neff
ff3bd1f59b
Fix post service spec
...
* load records to array to check them
* test that only 15 people are returned
2017-08-12 15:39:25 +02:00
Benjamin Neff
33e3e3a14d
Fix person spec, use first(15) instead of slice(0..14)
2017-08-12 15:39:25 +02:00
Benjamin Neff
f4136d4559
Fix post spec
...
* don't use `double` for queries
* use `second` instead of `at()`.
2017-08-12 15:39:25 +02:00
Benjamin Neff
29ab4d8242
Fix querying spec, remove (Post)
2017-08-12 15:39:25 +02:00
Benjamin Neff
63e342e6c4
Use aspect_ids for visible_shareables
2017-08-12 15:39:25 +02:00
Benjamin Neff
d62772f9c0
Replace Fixnum with Integer
2017-08-12 15:39:25 +02:00
Benjamin Neff
ca8974d4a0
Use ActionDispatch::TestRequest in NotificationSerializer spec
2017-08-12 15:39:24 +02:00
Benjamin Neff
b61536ff06
Remove unused formatted_birthday from profile model
2017-08-12 15:39:24 +02:00
Benjamin Neff
77951c4657
Fix user removal spec
2017-08-12 15:39:24 +02:00
Benjamin Neff
1adb4837ef
Fix OpenID Connect TokenEndpoint when client id is not found
2017-08-12 15:39:24 +02:00
Benjamin Neff
385ab76077
Refactor OpenID specs to prevent duplicate client names
2017-08-12 15:39:24 +02:00
Benjamin Neff
27f3b68f54
Copy headers in OpenidConnect TokenEndpointController
2017-08-12 15:39:24 +02:00
Benjamin Neff
9626c77a1c
Remove skip_fallback from post fetcher
2017-08-12 15:39:23 +02:00
Benjamin Neff
621fdda197
New syntax for request specs
2017-08-12 15:39:23 +02:00
Benjamin Neff
7c9590a27c
Use .reload instead of (true) in specs
...
Or remove it where not needed
2017-08-12 15:39:23 +02:00
Benjamin Neff
2a6515fab9
Add params keyword to controller specs
2017-08-12 15:39:23 +02:00
Benjamin Neff
955ef43a0e
Replace use_transactional_fixtures with use_transactional_tests
2017-08-12 15:39:23 +02:00
Benjamin Neff
5335ee86d6
Mobile fails now with ActionController::UnknownFormat
2017-08-12 15:39:22 +02:00
Benjamin Neff
4f5b1dd845
Fix creating share visibilities
...
Validation fails because there is no user set.
2017-08-12 15:39:22 +02:00
Benjamin Neff
d5f24021a7
Replace render text: ... with render plain: ...
2017-08-12 15:39:22 +02:00
Benjamin Neff
4bbc51bfb9
Remove return in scope block
...
Return in scope fails with `LocalJumpError: unexpected return`
2017-08-12 15:39:22 +02:00
Benjamin Neff
150fea6edb
Replace render nothing: true with head
2017-08-12 15:39:22 +02:00
Benjamin Neff
80c241bc7a
Replace redirect_to :back with redirect_back
...
Also remove some unused html responses
2017-08-12 15:39:22 +02:00
Benjamin Neff
b8ebb778bf
Refactor federation mappings
...
The hashes don't work properly with rails 5, there are different classes
loaded when called from the rails engine with missing inheritance.
Also the hashes never worked well with spring.
2017-08-12 15:39:21 +02:00
Benjamin Neff
2b911b0131
Permit parameters before using them
...
ActionController::Parameters no longer inherits from HashWithIndifferentAccess
2017-08-12 15:39:21 +02:00
Benjamin Neff
8a5752dd6c
Fix creating a post with poll
...
There were validation errors because `answer.poll` wasn't set.
2017-08-12 15:39:21 +02:00
Benjamin Neff
c382321934
Replace old ..._filter with new ..._action
2017-08-12 15:39:21 +02:00
Benjamin Neff
6e4c5bae29
Replace attribute_changed? with new methods
2017-08-12 15:39:21 +02:00
Benjamin Neff
e076910b74
Prepend protect_from_forgery because this defaults to false now
2017-08-12 15:39:21 +02:00
Benjamin Neff
b9d9a63739
Add rails-controller-testing dependency
...
Needed for `assigns` in controller specs
2017-08-12 15:39:20 +02:00
Benjamin Neff
ee9a299df6
Replace HashWithIndifferentAccess, it is now deprecated
2017-08-12 15:39:20 +02:00
Benjamin Neff
d0b634852b
Fix belongs_to, it is now required by default
2017-08-12 15:39:20 +02:00
Benjamin Neff
eb19c327e2
Add ApplicationRecord
2017-08-12 15:39:20 +02:00
Benjamin Neff
fe57bd88e8
Add ApplicationMailer
2017-08-12 15:39:20 +02:00
Benjamin Neff
4a9548ec1b
Use skip_pipeline: true for asset_url
2017-08-12 15:39:20 +02:00
Benjamin Neff
3d7061b240
Update configs for rails 5
...
Used `rails app:update`
2017-08-12 15:39:19 +02:00
Dennis Schubert
b711a8d4a1
Update binstubs
2017-08-12 15:39:19 +02:00
Dennis Schubert
45de17e1de
Remove test_after_commit
2017-08-12 15:39:19 +02:00
