Commit graph

4829 commits

Author SHA1 Message Date
cmrd Senya
e0e40f73c3
Spec for post creation bad aspects_ids issue 2018-03-25 08:28:59 +02:00
kas70
40fc175d6e
only include mutual sharing contacts in conversations form on contacts page
fixes #7377
2018-03-22 23:15:24 +01:00
Dennis Schubert
3643612b1c
Back to Top: Make sure to re-check the visibility after the scrolling is done
If a user scrolls just below the 1000px threshold and clicks the back-to-top button within 250ms, we'll never hide the button as the scroll event gets throttled away. That's rather inconvenient.

closes #7729
2018-03-07 00:39:36 +01:00
Benjamin Neff
4e5ee36675
Keep order of profile tags
closes #7724
2018-02-27 00:48:42 +01:00
Benjamin Neff
4cd8de5327
Refactor taggable tests to use let 2018-02-27 00:48:08 +01:00
Benjamin Neff
beeb073dbe
Fix followed tags posts in stream for posts with multiple tags
When there were posts with many followed tags they were returned
multiple times, resulting in less than 15 unique posts. That resulted in
some posts to be missed in the stream.

Fixes #4503

closes #7715
2018-02-25 04:35:49 +01:00
Benjamin Neff
f0aca56c8f
Don't retry for PublicKeyNotFound
We only return `nil` when we know the person, but don't know the key or
the key is invalid, so it doesn't make sense to retry in this case. When
the person isn't known and can't be fetched we raise a DiscoveryError
which will be retried.

Also the errors were moved to the `Signable` module in the last release.

closes #7717
2018-02-25 04:34:04 +01:00
Benjamin Neff
602a1dcd55
Store edited_at for relayables in additional_data
closes #7718
2018-02-25 04:33:03 +01:00
Benjamin Neff
0b4b3515a5
Start sending updated_at timestamp as edited_at for profiles
This can be used in later diaspora versions to order the profile updates
so we don't overwrite a newer profile with older data.
2018-02-25 04:32:19 +01:00
Benjamin Neff
c89b2ad809
Prevent duplicate mention notifications when the post is received twice
closes #7721
2018-02-22 00:49:21 +01:00
cmrd Senya
b32c844314
Support for embedding HTML5 media links
Use markdown-it-html5-embed plugin so user can embed audio and
video using the markdown link syntax []() in the HTML5 way.
2018-02-17 19:21:10 +01:00
Benjamin Neff
5e157dc9c3
Send participation after receiving a public post
This is to let the author of the post know, that this pod is interested
in updates about this post.

The sending user is only used to verify that the participation was sent
from this pod, but lets use an admin/podmin account if available.

closes #7708
2018-02-01 23:40:51 +01:00
Benjamin Neff
6c5b8b73af
Fix post_message for posts without text
fixes #7700
closes #7706
2018-02-01 23:39:18 +01:00
Benjamin Neff
a32cac06ab
Retry Contact messages 20 time (about two weeks)
closes #7705
2018-02-01 23:37:53 +01:00
Benjamin Neff
b9787cc632
Start sending the blocking flag 2018-02-01 23:35:35 +01:00
Benjamin Neff
746ff52256
Fix mention in #newhere message when invited by another person
fixes #7701
closes #7702
2018-02-01 23:35:04 +01:00
Brad Koehn
1a3c16eb6e
update to support 280 character Twitter
closes #7694
closes #7662
fixes #7661
2018-01-09 00:05:33 +01:00
Janakas
0347507b20
Delete archive files when closing an account
closes #7684
2018-01-08 21:15:41 +01:00
Janakas
d4e5d13a8f
Remove old export archives after 2 weeks
Fixes #5727
2018-01-08 21:14:06 +01:00
Benjamin Neff
c135ace407
Fix notifications when people remove their birthday date
Some people may remove their birthday date after the notification was
sent, which then breaks the notification page for other users. Let's
just display the date when the notification was created, and not display
the users updated birthday date. When users update from date A to B it
always looks weird anyway, when we display the same new date B twice on
different days, or display two different dates for the same user.

We could remove notifications when users change or remove their
birthday, but that would be way more complex and also we usually don't
remove notifications (not even for deleted posts).

Fixes #7689

closes #7691
2018-01-05 01:50:11 +01:00
Benjamin Neff
e0eb76eb2a
Remove aspect_ids parameter from publisher
closes #7683
2017-12-25 20:54:10 +01:00
Rete2
fc33a2ac5d
Create birthday notification and mailer
closes #7624

fixes #1649
2017-12-18 04:34:35 +01:00
Benjamin Neff
70410d1691
Ignore invalid diaspora:// links
Fixes #7651

closes #7652
2017-10-27 02:26:52 +02:00
cmrd Senya
ad025850ce
Forbid user destruction 2017-10-17 01:38:36 +02:00
cmrd Senya
973e9d98c6
Raise sensible error message when user is missing
That's for the case when podmin has messed up the database
2017-10-17 01:38:36 +02:00
cmrd Senya
f212b51f7f
Check for user existence on aspect membership destruction 2017-10-17 01:38:36 +02:00
Benjamin Neff
a36d22d72b
Handle duplicate account migrations
closes #7641
2017-10-17 01:36:25 +02:00
Benjamin Neff
6d5647ec11
Handle duplicate account deletions 2017-10-17 01:32:14 +02:00
Benjamin Neff
b920ddbff5
Move special and ignored associations to tests 2017-10-17 01:32:14 +02:00
Benjamin Neff
f704f30572
Remove conversation visibilities with standard person associations 2017-10-17 01:32:14 +02:00
Benjamin Neff
f4902421ea
Destroy user and person associations in batches 2017-10-17 01:32:14 +02:00
Benjamin Neff
fd36517dee
Limit the number of parallel exports that are allowed to run
closes #7629
2017-09-28 23:11:46 +02:00
Benjamin Neff
3fafcd9307
The diaspora ID validator now validates if it is lowercase
Relaying relayables will fail with non-lowercase authors.

closes #7625
2017-09-28 23:08:41 +02:00
Benjamin Neff
84b89d5594
Relay likes for comments 2017-09-28 23:04:35 +02:00
Benjamin Neff
5f5d8c5e13
Replace diaspora:// links in the text 2017-09-28 23:04:35 +02:00
Benjamin Neff
4a994b0a48
Creates references for linked posts after create 2017-09-28 23:04:34 +02:00
Benjamin Neff
c82e891c03
Add reference source and target behaviour 2017-09-28 23:04:34 +02:00
Benjamin Neff
28d3271933
Create refereces model 2017-09-28 23:04:34 +02:00
Benjamin Neff
35711606e4
Remove public and provider_display_name from reshares 2017-09-28 23:04:34 +02:00
Benjamin Neff
95fbd3fc66
Don't change the filename of the export everytime the user is touched
closes #7622
2017-09-28 03:28:15 +02:00
Benjamin Neff
ac39e920c8
Add camo to NodeInfo
closes #7617
2017-09-28 03:20:31 +02:00
cmrd Senya
c6ed850a85
Memory usage optimization for archive export
- Removed posts and non contacts from other's data
- Collections are exported in batches to lower memory footprint
- In base exporters create User object instead of keeping instance because it caches all associations

closes #7627
2017-09-26 04:07:18 +02:00
cmrd Senya
ea57fc5d25
Fix mistyped remote person in dispatcher spec 2017-09-26 04:06:43 +02:00
cmrd Senya
9f0b74ebbb
Memory usage test for archive export
It is not included into the main test suite, because it has :performance tag.

One can run this test using command:
$ bin/rspec --tag performance spec/integration/export/memory_usage_spec.rb

This test creates additional fixtures set to speed up repeated runs.
2017-09-26 04:06:43 +02:00
cmrd Senya
265a7ee253
Don't force fixtures rebuild on each rspec run
Main purpose of fixtures for us is to speed up test runs. Rebuilding
fixtures each run makes them pointless. They will be rebuilt automatically
if some of "files_to_check" are changed, so we're protected from the case
when fixtures are outdated and don't load properly.
2017-09-26 04:06:43 +02:00
cmrd Senya
9ee9dbe969
Fix local migration run without old private key
It was possible to run migration locally without providing old private
key. This way migration was performed but not dispatched, which obviously
leads to desynchronization of the federation state so let's validate sender
before performing any actual actions.

closes #7558
2017-09-26 04:06:16 +02:00
Benjamin Neff
655fe2a912
Cleanup invalid polls without status message
closes #7614
2017-09-18 03:24:52 +02:00
Benjamin Neff
e82690963d
Add # frozen_string_literal: true to all files 2017-09-17 19:29:15 +02:00
Benjamin Neff
44ebc7375a
Remove unused spec-doc.rb
closes #7594
2017-09-17 19:27:47 +02:00
Steffen van Bergerem
b77ecd482a
Replace aspect_membership_dropdown with aspect-membership-dropdown 2017-08-31 02:44:54 +02:00
Steffen van Bergerem
473cc2518b
Replace comment_box with comment-box 2017-08-31 02:44:53 +02:00
Steffen van Bergerem
7729635485
Replace publisher_textarea_wrapper with publisher-textarea-wrapper 2017-08-31 02:44:53 +02:00
Steffen van Bergerem
caeaf23d4b
Replace aspect_dropdown with aspect-dropdown 2017-08-31 02:44:53 +02:00
Benjamin Neff
e31c5ff4dc
Handle unauthenticated users for likes/comments of private posts
closes #7583
2017-08-29 12:55:03 +02:00
Benjamin Neff
350e24863f
Allow to load likes and reshares without login 2017-08-29 12:35:48 +02:00
Steffen van Bergerem
d130697ce2
Use Bootstrap 3 progress-bar for polls
closes #7600
2017-08-29 02:17:32 +02:00
Steffen van Bergerem
02d9d350d9
Move person extension for prefills to conversations form view
closes #7599
2017-08-29 02:13:57 +02:00
Steffen van Bergerem
48630b3a04
Fix conversation recipient prefill on contacts page
Use the already available contacts data for the prefill
2017-08-29 02:13:27 +02:00
Steffen van Bergerem
666ada44f1
Fix conversation recipient prefill on profile page
Fixes #7586

Use the already available data about the recipient for the prefill
2017-08-29 02:13:27 +02:00
Benjamin Neff
04035c3eb7
Allow to receive reshares without root
closes #7590
2017-08-29 02:06:08 +02:00
Benjamin Neff
163ffdb19b
Allow multiple reshares without root
Follow-up for #7578

Fixes #7587
2017-08-29 02:05:43 +02:00
Benjamin Neff
6d7ba96c4f
Remove locals option from render_template assertion
The locals option is only supported in ActionView::TestCase, so it is
ignored anyway (even worse, it disabled the complete assertion). I added
some more assertions to ensure the template is rendered with the correct
conversation.

closes #7588
2017-08-29 02:02:03 +02:00
Benjamin Neff
634c13f967
Remove wrong format: :json from status_messages_controller_spec
This was added by accident with the rails5 upgrade
2017-08-29 02:01:43 +02:00
Rete2
b556ad5211
show users vote in poll
closes #7550
2017-08-26 03:16:05 +02:00
Benjamin Neff
b040f85790
Remove root_guid from reshares when post is deleted
And cleanup old reshares with deleted root posts

closes #7578
2017-08-26 03:08:37 +02:00
Benjamin Neff
9240605ad5
Remove internet explorer version check
This was in all stack traces, which confused people ...

We currently only support IE11, so the version check was already old
again ...

When we break old browser versions, we don't check that for other
browsers. So older IE browser just break, like very other older browser
too.

closes #7557
2017-08-24 14:57:43 +02:00
Benjamin Neff
494518def1
Remove old message parameter from invite mail
closes #7571
2017-08-23 21:55:43 +02:00
ivan sebastian
3016280ef1
add jquery are you sure to comment form
closes #7530
2017-08-19 12:31:24 +02:00
Benjamin Neff
a01cc4dfcb
Merge branch 'release/0.7.0.0' into next-minor 2017-08-17 11:42:11 +02:00
Steffen van Bergerem
6ae2df2f9e
Fix missing timeagos for comments in the single post view 2017-08-17 11:40:49 +02:00
Benjamin Neff
685135474b
Merge branch 'release/0.7.0.0' into next-minor 2017-08-17 03:36:38 +02:00
Benjamin Neff
17949ffb4e
Match parameter with match_array to fix order mismatch
closes #7546
2017-08-17 03:27:46 +02:00
Steffen van Bergerem
4cb365a6f4
Fix missing photos in the single post view
closes #7545
2017-08-17 03:25:31 +02:00
Steffen van Bergerem
ff9591aee0
Use gender-neutral forms in comments and specs
closes #7544
2017-08-17 00:50:55 +02:00
Benjamin Neff
2d06b2865f
Handle when the block to delete doesn't exist
closes #7542
2017-08-16 20:40:11 +02:00
Benjamin Neff
a4d1ad160c
Fix stop ignoring from privacy settings and on mobile
Fixes #7541
2017-08-16 20:39:58 +02:00
cmrd Senya
45619cb153
Account migration model and message support
This commit introduces support for AccountMigration federation message
receive. It covers the cases when the new home pod for a user is remote
respective to the recepient pod of the message. It also allows to initiate
migration locally by a podmin from the rails console. This will give the
pods a possibility to understand the account migration event on the
federation level and thus future version which will implement migration
will be backward compatible with the pods starting from this commit.
2017-08-15 01:32:34 +03:00
cmrd Senya
e2979df65a
Add explicit mutual contact to test data
Add explicit mutual contact creation to the DataGenerator#generic_user_data
which is used in account deletion tests.
2017-08-14 19:15:54 +03:00
cmrd Senya
8f46073809
Stop disabling Send workers for each example 2017-08-14 13:54:38 +03:00
Benjamin Neff
a61d5739d4
Re-add disconnect_contacts in AccountDeleter 2017-08-14 04:52:00 +02:00
Benjamin Neff
1bd630d8a1
Merge pull request #7536 from SuperTux88/refactor-publisher-preview
Remove avatar, name, timestamp and interactions from publisher preview
2017-08-14 04:07:56 +02:00
Benjamin Neff
dd6cbbbb8e
Remove avatar, name, timestamp and interactions from publisher preview
This doesn't add any value in the post preview:
* Avatar is already at the left-hand side of the publisher
* Timestamp is always "less than a minute ago"
* Interactions are disabled in the preview anyway

We don't display these things in the comment preview either, they only
need space and don't add any value to the preview.
2017-08-14 02:21:28 +02:00
Benjamin Neff
172f80bcae
Handle unexpected errors while exporting userdata or photos
Otherwise the export stays soft-locked and the podmin needs to reset it
manually.

Fixes #6225
2017-08-14 00:36:52 +02:00
Benjamin Neff
7ffd7878d0
Use person for AccountDeleter
Also remove `disconnect_contacts` methods, because contacts are already
removed with aspects memberships in `before_destroy`.
2017-08-13 20:10:07 +02:00
Benjamin Neff
245ad9e04d
Remove diaspora_handle from AccountDeletions and add unique index 2017-08-13 19:43:04 +02:00
Steffen van Bergerem
54d70a87ed
Render mentions in comment previews correctly 2017-08-13 13:50:02 +02:00
flaburgan
21cdc6041d
Private profile 2017-08-13 04:53:53 +02:00
Steffen van Bergerem
04735ce9b0
Remove unused interactions method in post controller 2017-08-12 18:09:14 +02:00
Steffen van Bergerem
ad53a43f88
Remove unused post interactions parse method 2017-08-12 18:09:14 +02:00
Steffen van Bergerem
6b162110ce
Add 'show all' links to the SPV to fetch missing likes and reshares 2017-08-12 18:09:13 +02:00
Steffen van Bergerem
0bfc2fdd77
Load likes and reshares in the SPV via gon 2017-08-12 18:09:13 +02:00
Steffen van Bergerem
05d19e69ee
Move ExtremePostPresenter methods into PostPresenter, add #with_initial_interactions method 2017-08-12 18:09:12 +02:00
Benjamin Neff
dc92633dab
Merge pull request #7514 from SuperTux88/rails5
Upgrade to rails 5.1
2017-08-12 15:43:15 +02:00
Benjamin Neff
62cb1f99ce
Get current time before the test to be safer on MySQL 2017-08-12 15:39:27 +02:00
Benjamin Neff
ff3bd1f59b
Fix post service spec
* load records to array to check them
* test that only 15 people are returned
2017-08-12 15:39:25 +02:00
Benjamin Neff
33e3e3a14d
Fix person spec, use first(15) instead of slice(0..14) 2017-08-12 15:39:25 +02:00
Benjamin Neff
f4136d4559
Fix post spec
* don't use `double` for queries
* use `second` instead of `at()`.
2017-08-12 15:39:25 +02:00
Benjamin Neff
29ab4d8242
Fix querying spec, remove (Post) 2017-08-12 15:39:25 +02:00
Benjamin Neff
63e342e6c4
Use aspect_ids for visible_shareables 2017-08-12 15:39:25 +02:00
Benjamin Neff
d62772f9c0
Replace Fixnum with Integer 2017-08-12 15:39:25 +02:00