Commit graph

4580 commits

Author SHA1 Message Date
Steffen van Bergerem
5efb4a912e Prevent scroll to top when clicking 'mark all as read' in the notification dropdown
Fixes #7252

closes #7253
2017-01-10 23:41:35 +01:00
Steffen van Bergerem
fb06d03f49 Close modals at the end of each jasmine spec
closes #7246
2017-01-10 23:32:27 +01:00
Steffen van Bergerem
c164dac7a4
Merge branch 'next-minor' into develop 2017-01-07 18:32:15 +01:00
Frédéric Bolvin
7cc4b46d7e
Replaced fileuploader-custom with FineUploader
closes #7083
2017-01-07 18:32:08 +01:00
Dennis Schubert
2c68c1f142
Merge branch 'next-minor' into develop 2016-12-04 20:10:17 +01:00
Benjamin Neff
6c37171f9f
Change last sentence and fix specs
closes #7238
2016-12-04 20:10:13 +01:00
Benjamin Neff
da52627ab2 Merge branch 'next-minor' into develop 2016-12-02 03:31:45 +01:00
Senya
dd9bda24f4 Remove user_methods require line
No need to explicitly require user_methods.rb since it is already required in spec_helper.rb

closes #7236
2016-12-02 03:24:36 +01:00
Dennis Schubert
af1c992e01
Merge branch 'next-minor' into develop 2016-12-01 03:17:21 +01:00
cmrd Senya
31a31ecbe1
pass "state" parameter back to openid client 2016-12-01 03:16:50 +01:00
Benjamin Neff
bab503d960 Merge branch 'next-minor' into develop 2016-12-01 02:29:00 +01:00
Steffen van Bergerem
00ce187b07 Don't show browser notifications on pageload
closes #7211
2016-12-01 02:27:52 +01:00
Benjamin Neff
3b0c1020c0 Merge pull request #6818 from cmrd-senya/1851-mentions-in-comments.new
Mentions in comments backend changes
2016-11-29 19:31:43 +01:00
Senya
c547e66eb6 Remove a dangling "lola" object creation
It's never used and possibly was left unnoticed by some refactoring.

closes #7230
2016-11-29 17:46:37 +01:00
cmrd Senya
33ad411bbd
Mentions in comments backend changes 2016-11-28 15:56:56 +02:00
cmrd Senya
ef5751b808
Refactor mail workers to use common base
Introduce Workers::Mail::NotifierBase to be a base for all appropriate
mail workers to reduce code duplication
2016-11-28 15:35:46 +02:00
cmrd Senya
0ee34f8590
Remove the photo comment spec
This functionality is not something we support and it doesn't look
it will be reintroduced soon.

see discussion https://github.com/diaspora/diaspora/pull/6818#discussion_r70227392
2016-11-28 15:35:36 +02:00
Justin Ramos
fa71af71c1 require spec_helper in .rspec
closes #7223
2016-11-27 21:27:12 +01:00
Steffen van Bergerem
9f88850faf Fix 500 on mobile commented and liked streams
Fixes #7218, regression from #7036

closes #7219
2016-11-26 02:37:33 +01:00
Steffen van Bergerem
e186811aed Remove unused contacts link methods
closes #7221
2016-11-26 02:25:29 +01:00
Justin Ramos
6c6f9bb982
only show community spotlight link on /contacts if it is enabled
closes #7213
2016-11-25 14:10:58 +01:00
Steffen van Bergerem
0051d6a0b8 Move comment, like and reshare creation error translations
closes #7202
2016-11-22 03:54:56 +01:00
Steffen van Bergerem
f999624967 Use error message from the server when comment failed 2016-11-22 03:53:01 +01:00
Steffen van Bergerem
82e78d3ce8 Use error message from the server when like failed 2016-11-22 03:53:01 +01:00
Steffen van Bergerem
6c5c865b15 Use error message from the server when reshare failed 2016-11-22 03:53:01 +01:00
Steffen van Bergerem
8078c60cee Refactor aspect membership error response handling with flash messages 2016-11-22 03:53:01 +01:00
Steffen van Bergerem
b645541d52 Update notifications when changing the stream
fixes #6473

closes #7199
2016-11-22 03:00:59 +01:00
Steffen van Bergerem
5660d2f4a8 Refactor comment creation in post interactions backbone model
closes #7186
2016-11-19 03:40:42 +01:00
Steffen van Bergerem
ed5f218559 Only clear comment textarea when comment submission was successful
fixes #5094
2016-11-19 03:40:29 +01:00
Augier
af331bfb30
Add collection to app.views.NotificationDropdown and app.views.Notifications
closes #6952
2016-11-18 15:27:37 +01:00
Steffen van Bergerem
9b72527f3e Refactor conversations controller creation specs
closes #7197
2016-11-18 02:14:18 +01:00
Steffen van Bergerem
9bca03d5e9 Refactor ShareVisibilitesController
closes #7196
2016-11-18 02:10:26 +01:00
Steffen van Bergerem
37b34237b9 Force jasmine fails on syntax errors
closes #7185
2016-11-15 22:50:17 +01:00
Steffen van Bergerem
cdce25374f Reduce i18n.load side effects
closes #7184
2016-11-15 22:46:06 +01:00
Steffen van Bergerem
a951c40ba0 Only reload profile header when changing aspect memberships
closes #7183

fixes #7072
2016-11-15 22:37:39 +01:00
Steffen van Bergerem
3930069e67 Leave help view spec with the default locale 2016-11-15 22:36:06 +01:00
Steffen van Bergerem
1863137161 Use string-direction gem for rtl detection
closes #7181
2016-11-15 22:33:56 +01:00
Steffen van Bergerem
457cf2aafb Fix deprecation warnings in conversations controller spec
closes #7187
2016-11-14 03:27:55 +01:00
Steffen van Bergerem
7cd2232812 Only allow conversation creation in controller with mututal contacts 2016-11-14 03:27:15 +01:00
Steffen van Bergerem
117b17e25e Remove unused conversations modal fixture
closes #7129
2016-11-13 20:11:34 +01:00
Steffen van Bergerem
8983554f94 Improve profile header jasmine test
* append html to spec.content() instead of body
* don't append the unused conversations modal fixture
* actually test that showModal has been called
2016-11-13 20:08:59 +01:00
Steffen van Bergerem
cbe3ca5cf6 Improve conversations form jasmine test
* test that tag element are removed when clicking the tag's remove button
2016-11-13 20:08:59 +01:00
Steffen van Bergerem
4c86b64532 Improve contacts page jasmine test
* append html to spec.content() instead of body
* don't append the unused conversations modal fixture
* actually test that showModal has been called
2016-11-13 20:08:59 +01:00
Steffen van Bergerem
9cbadec659 Move 'XSS via name parameter' to mobile conversation specs
because the desktop view doesn't use the name parameter anymore
2016-11-13 20:08:59 +01:00
Augier
f2fdaf1daf Use typeahead on conversations 2016-11-13 20:08:59 +01:00
Steffen van Bergerem
5269a0d3c0
Fix aspect membership view spec syntax
Regression introduced in #7132
2016-11-12 21:37:48 +01:00
Benjamin Neff
851c16d80c
Add setting for a custom changelog url.
fixes #7073

closes #7166
2016-11-06 02:41:42 +01:00
Benjamin Neff
57c0330535
Schedule a connection-check when receiving a message from an offline pod
closes #7158
2016-11-06 02:40:05 +01:00
Steffen van Bergerem
a73e1baaed Show spinner when loading comments
closes #7170
2016-11-03 22:50:03 +01:00
Steffen van Bergerem
e3b3da404f Fetch comments, likes and reshares separately
Fixes #7165

closes #7167
2016-11-02 23:02:32 +01:00
Steffen van Bergerem
98b345305e Remove unused jasmine fixture 2016-11-02 22:59:25 +01:00
Steffen van Bergerem
2ec45317a3 Add new JSON endpoint for reshares 2016-11-02 22:59:25 +01:00
Benjamin Neff
9f38a424e7
Revert "Test token authentication; should allow it"
It shouldn't be allowed!

This reverts commit 46097ba8c8.

closes #7160
2016-10-28 00:36:18 +02:00
Benjamin Neff
d421e42ddb
Remove ability to authenticate with auth_token on the frontend
Remove devise-token_authenticatable gem and only generate a token to be
used by the chat.
2016-10-28 00:36:14 +02:00
Benjamin Neff
0dd98a5c13
Bump diaspora_federation
closes #7145
2016-10-27 02:26:11 +02:00
Steffen van Bergerem
f90812671c
Show error messages from server when aspect membership changes fail
closes #7132
2016-10-27 02:24:58 +02:00
Steffen van Bergerem
3bea40b248
Refactor conversations creation
closes #7131
2016-10-27 02:23:35 +02:00
Steffen van Bergerem
0c995eb629
Add JavaScript for mobile alerts 2016-10-27 02:23:26 +02:00
cmrd Senya
a80806ca58
Fix ID token issuer field to match discovery data
OpenID Connect spec says:

"The issuer returned by discovery MUST exactly match the value of iss in the ID Token."

https://openid.net/specs/openid-connect-core-1_0.html#IssuerIdentifier

closes #7081
2016-10-27 02:22:27 +02:00
hilkoc
b7791e6c9d Add user setting for default post visibility
fixes #4319

closes #7118
2016-10-26 02:48:11 +02:00
Benjamin Neff
ac08e9351b
Hide "Follow #tag" button on tag page if not logged in
closes #7155
2016-10-24 00:25:27 +02:00
Augier
8c90e5ac46
Search suggestion can be opened in a new tab + displays contact's hovercard
closes #7134
2016-10-18 15:37:23 +02:00
cmrd Senya
cdcf2d747e
Override forgery settings in controllers
ClientsController and TokenEndpointController are called from the outside,
so CSRF verification prevents them from normal operation.

closes #7062
2016-10-01 10:24:15 +02:00
Benjamin Neff
6ec0fd4b9f
Add nonce to javascript tags 2016-09-30 02:10:37 +02:00
Steffen van Bergerem
35aa0badc5
Refactor stream shortcuts
closes #7127
2016-09-30 01:44:24 +02:00
Steffen van Bergerem
b1a76cac86
Fix spelling in conversations inbox view spec 2016-09-30 00:32:46 +02:00
Augier
e424896822
Fully port conversations to Backbone and drop inbox.js 2016-09-30 00:32:46 +02:00
Benjamin Neff
b8c76a3317
Trigger getting started with backbone 2016-09-28 21:59:08 +02:00
Benjamin Neff
20cdbe262e
Link directly to the comment from notification mails
closes #7124
2016-09-25 23:07:53 +02:00
Dennis Schubert
dfb5b717b6 Add In-Reply-To and References headers to notification mails
closes #7122
2016-09-25 20:15:16 +02:00
Benjamin Neff
fe5811bb65
Don't federate to pods that are offline for more than two weeks
Also fix a case where offline_since can be nil.

fixes #6220

closes #7120
2016-09-25 03:20:41 +02:00
Augier
523f1e848e
Replace .stream_element by .stream-element 2016-09-25 03:12:28 +02:00
Steffen van Bergerem
709547860a
Refactor SPV post interactions
closes #7089
2016-09-25 03:07:02 +02:00
Benjamin Neff
0e5141dd67
Fix mapbox API URL
closes #7066
2016-09-25 02:58:56 +02:00
Steffen van Bergerem
ffb442266f
Remove custom typeahead mouse events
closes #7096
2016-09-20 04:29:43 +02:00
Benjamin Neff
fe071aa2a2
Deliver to each recipient only once
closes #7071
2016-09-20 04:25:04 +02:00
Benjamin Neff
3f2586bc6f
Create share visibilities for photos attached to a private post
Also fixed the "fix public photos"-migration, because it didn't work
with migration-models :/

fixes #6177
2016-09-20 04:24:37 +02:00
Steffen van Bergerem
327cabe6fe Add number of unreviewed reports to admin dashboard and admin sidebar
closes #7109
2016-09-18 22:48:05 +02:00
Benjamin Neff
5837919946
Fix link to comment on report-page
closes #7105
2016-09-18 13:41:44 +02:00
Steffen van Bergerem
dc1bc75303 Fix moving publisher on first click after page load
closes #7094

fixes #7093
2016-09-13 01:02:39 +02:00
Steffen van Bergerem
546f909658 Fix 500 in html requests for post interactions
closes #7085
2016-09-11 00:21:13 +02:00
Steffen van Bergerem
e54077c856 Remove photo_backdrop factories 2016-09-11 00:18:39 +02:00
cmrd Senya
ad596d8df1
Fix tags URLs in hovercards
fixes #7074

closes #7075
2016-09-09 00:53:21 +02:00
Steffen van Bergerem
e27af6ee1a
Redirect logged in users to inviters page when following an invitation link
closes #7061
2016-09-06 05:08:04 +02:00
Benjamin Neff
c5ebea5bda
Fix randomly failing interacted_at spec
also remove some unnecessary Timecop.return

closes #7060
2016-09-05 22:44:52 +02:00
Benjamin Neff
50e7314535
Cleanup invalid unconfirmed emails
Also remove confirm_email_token when unconfirmed_email is removed.

Fixes #7048

closes #7051
2016-09-04 21:40:27 +02:00
Steffen van Bergerem
4d51c02432 Add OpenGraph video support
closes #7043
2016-09-04 03:55:09 +02:00
Benjamin Neff
8c58206e63
Fix links of more-button on mobile streams
Fixes #6999

closes #7036
2016-09-04 03:31:41 +02:00
Benjamin Neff
4fea926057
Only update interacted_at on new comments
I got feedback from many users, that they don't understand how the "my
activity" stream is sorted, because they have posts on the top, but
don't see why. The user doesn't see if a like was added, and it is also
not imported for the user to see the post again then. And we have
notifications if someone likes a users own posts, so no need to move it on
top of the "my activity" stream here too.

closes #7030
2016-09-04 03:29:59 +02:00
Steffen van Bergerem
c3de77e0fc
Send notification mails on CSRF fails
closes #7050
2016-09-04 03:26:42 +02:00
Steffen van Bergerem
6ad9000f8c
Sign out users with wrong CSRF tokens
See http://guides.rubyonrails.org/security.html#cross-site-request-forgery-csrf
2016-09-04 03:26:18 +02:00
Steffen van Bergerem
806de7e9d8
Exclude closed accounts from search
closes #7042
2016-09-04 03:22:58 +02:00
Steffen van Bergerem
9a2cb1517a
Set participations client side when changing post interactions
closes #7040
2016-09-04 03:17:48 +02:00
Steffen van Bergerem
02742a4a8f
Use post controls view for single post moderation 2016-09-04 03:16:24 +02:00
Steffen van Bergerem
8faedd574d
Move post controls to a separate view 2016-09-04 03:16:24 +02:00
Steffen van Bergerem
ffdd5a14ac
Remove deleted comments when loading more comments
closes #7045
2016-09-04 03:15:35 +02:00
Steffen van Bergerem
89b51dddf9
Add application controller specs for grammatical gender 2016-09-04 03:02:27 +02:00
Steffen van Bergerem
08794bc47b
Remove user_photo method from users controller
closes #7049
2016-09-04 03:01:51 +02:00
Steffen van Bergerem
18fbb2a885 Remove useless notifier spec
closes #7056
2016-09-04 02:24:58 +02:00
Benjamin Neff
4b020b8d61 Fix regressions from #6998
* fixed old reshares of reshares
* fixed deleted root of a reshare
2016-08-22 00:43:43 +02:00