Benjamin Neff
c135ace407
Fix notifications when people remove their birthday date
...
Some people may remove their birthday date after the notification was
sent, which then breaks the notification page for other users. Let's
just display the date when the notification was created, and not display
the users updated birthday date. When users update from date A to B it
always looks weird anyway, when we display the same new date B twice on
different days, or display two different dates for the same user.
We could remove notifications when users change or remove their
birthday, but that would be way more complex and also we usually don't
remove notifications (not even for deleted posts).
Fixes #7689
closes #7691
2018-01-05 01:50:11 +01:00
Rete2
fc33a2ac5d
Create birthday notification and mailer
...
closes #7624
fixes #1649
2017-12-18 04:34:35 +01:00
Benjamin Neff
e82690963d
Add # frozen_string_literal: true to all files
2017-09-17 19:29:15 +02:00
cmrd Senya
33ad411bbd
Mentions in comments backend changes
2016-11-28 15:56:56 +02:00
Steffen van Bergerem
1b77258d0e
Set default for post title truncation to 70 characters
...
closes #6022
2015-06-02 12:14:35 +02:00
Steffen van Bergerem
9c22ed6aef
Add year to notifications page
2015-02-16 18:02:50 +01:00
Steffen van Bergerem
f217a5bc11
Add filters to notifications controller
2014-03-19 17:54:22 +01:00
Fabián Rodríguez
8b4aab0780
change #count to #size in notifications_helper to reduce queries
2013-01-29 10:01:09 -02:00
Fabián Rodríguez
232539cdf9
remove unused helpers
2012-11-21 18:26:17 -02:00
Jonne Haß
e70e48d6ca
some refactoring regarding the law of demeter
2012-09-23 19:33:19 +02:00
Steven Fuchs
e882dedd33
remove vanna controller from app, adjust scripts, specs, views and controllers to work.
2012-01-22 17:39:35 -05:00
Jonne Haß
a482d90bf0
do the extra include of language helper for the vanna controller…
2012-01-14 21:59:49 +01:00
danielgrippi
bee8aa8bcd
remove unused files/methods
2012-01-11 02:26:12 -08:00
Ilyaaaaaaaaaaaaa Zhitomirskiy
8c9a585337
reshares now have notifications, slight refactor of the notification helper
2011-08-25 17:16:09 -07:00
Maxwell Salzberg
0473037d1b
fix notification links
2011-08-18 11:12:58 -07:00
Maxwell Salzberg
86e374b8ce
add hovercards back to mentions, reorganized some helpers, made getting started view mobile accessible
2011-08-09 16:54:24 -07:00
Raphael Sofaer
9789d1d6cb
Fix issue #1579 , like.target, not like.post
2011-07-17 21:18:21 -04:00
Raphael Sofaer
14759b2c80
Use person_link in notifications_helper, move hovercard css out to a file
2011-07-12 16:21:03 -07:00
Raphael Sofaer
97ca10ddda
Huge commit I know, but move show and destroy routes into PostsController and PostsController#show into PublicsController
2011-07-10 20:06:31 -07:00
danielgrippi
e994c90559
don't show hovercard for current_user in likes field + fixed hovercard styling in likes field
2011-07-06 21:33:59 -07:00
danielgrippi
fdaa44ca9c
add hovercards to links in likes
2011-07-06 21:09:24 -07:00
Dan Hansen
05688c2f43
notifications wip
2011-07-01 22:46:54 -07:00
Dan Hansen & Michael Sofaer
46c83a7c7d
reset the notifications helper to master's version and monkey patch header
2011-06-27 19:51:35 -07:00
Dan Hansen & Michael Sofaer
8f5358e68f
Move some DB logic from helper to controller
2011-06-27 19:51:35 -07:00
Michael Sofaer
d6ba3c970c
proof of concept for notifications overlay
2011-06-27 19:51:35 -07:00
Maxwell Salzberg
56644c9d1e
use notification people link for likes.... it should now get refactored, but it works nicely now, even with I18n
2011-05-24 21:45:12 -07:00
MrZYX
db22be43a8
really no string concatenation and proper pluralization in notifications helper AKA THE REASON I DIDN'T WANTED TO TOUCH THIS STUFF
2011-05-24 17:03:48 +02:00
Raphael Sofaer
fc7b2cfe3f
Take out some of the concatenation from NotificationsHelper. VSO languages will still be impossible, but our Caucasian friends should now be able to have valid sentences here. I don't particularly like passing a translation into a link helper which is passed into a translation.
2011-05-23 23:09:48 -07:00
Maxwell Salzberg
d776105558
grammer nazi cleanup of notification_people_link and refactor + tests
2011-05-22 17:18:44 -07:00
Maxwell Salzberg
59ae829254
there is a dumb bug where likes are targeting themselves
2011-05-22 15:02:01 -07:00
Maxwell Salzberg
77fc40d404
add application helper to notification helper spec, made the link an object_link rather than status_message_link
2011-05-22 14:59:04 -07:00
Maxwell Salzberg
2f6d079635
added failure test for deleted likes
2011-05-22 14:45:16 -07:00
Maxwell Salzberg
66c28c4caf
notification page now has links for likes
2011-05-22 14:35:35 -07:00
danielgrippi
60a60733df
Merge branch 'master' into follow
...
Conflicts:
app/controllers/aspects_controller.rb
app/controllers/contacts_controller.rb
app/controllers/people_controller.rb
app/controllers/photos_controller.rb
app/controllers/tags_controller.rb
app/helpers/notifications_helper.rb
app/models/notifications/new_request.rb
app/models/user_preference.rb
public/javascripts/view.js
spec/controllers/aspects_controller_spec.rb
spec/controllers/contacts_controller_spec.rb
spec/controllers/home_controller_spec.rb
spec/controllers/post_visibilities_controller_spec.rb
spec/controllers/requests_controller_spec.rb
spec/mailers/notifier_spec.rb
spec/models/user_spec.rb
2011-05-12 15:49:51 -07:00
Raphael Sofaer
b8d9610877
added translation to the likes popup, made the notification models a little clearer
2011-05-11 13:50:26 -07:00
danielgrippi
648a10e6d3
Merge branch 'master' into follow
...
Conflicts:
app/controllers/requests_controller.rb
app/controllers/tags_controller.rb
app/helpers/aspects_helper.rb
app/views/notifications/index.html.haml
config/routes.rb
public/javascripts/aspect-edit.js
public/javascripts/contact-list.js
spec/integration/receiving_spec.rb
spec/models/user/connecting_spec.rb
spec/models/user/posting_spec.rb
2011-05-04 11:35:35 -07:00
Raphael Sofaer
a5f297d7f7
Don't include every helper everywhere, re-organize helpers
2011-04-28 10:38:33 -07:00
maxwell
62c164e1a4
fixed displays of the days based on locale
2011-04-18 18:29:55 -07:00
danielgrippi
2e5b5e1efe
request notification emails -> started sharing notification emails
2011-04-06 13:21:15 -07:00
danielgrippi
b6d5165f2d
scroll to post on page if you can see it (via notification popup)
2011-03-23 17:16:30 -07:00
maxwell
eed32f70be
add a missing space for notifications with less than 4 people
2011-03-17 10:50:11 -07:00
maxwell
2e72fc09c6
made 3+ plus collapse in notifications index
2011-03-14 18:09:51 -07:00
MrZYX
ed8d4db3a8
some reformatting/refactor of en.yml. This might break some translations but I think I've catched the most ones, at least the most important ones
2011-03-12 03:27:28 +01:00
danielvincent
21fd546cd0
posts now have authors instead of people
2011-03-01 18:05:05 -08:00
Raphael Sofaer
00cca370ad
Add translation key method, should be replaced with separate partials.
2011-03-01 11:03:58 -08:00
Raphael Sofaer
1c1fba63e7
Refactor notification to have subclasses, just a start
2011-03-01 10:30:29 -08:00
Raphael Sofaer
736783abd7
You can't call post.person when post is nil. We should probably just reject and delete the invalid notifications in the controller, keeping them in the view is aggravating
2011-02-24 11:13:25 -08:00
zhitomirskiyi
e106ec6a79
added post author to the subject of the also commented email as well as the notification
2011-02-23 13:03:11 -08:00
zhitomirskiyi
d1771bbe17
notifications for mentions
2011-02-10 12:39:05 -08:00
zhitomirskiyi
17a2c9e311
moving over some code migration successful
2011-01-29 23:34:11 -08:00